• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

help converting code for module...

Scheduled Pinned Locked Moved Development
21 Posts 4 Posters 8.0k Views 4 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Offline
    strawberry 3.141 Project Sponsor Module Developer @justjim1220
    last edited by Oct 27, 2018, 12:27 AM

    @justjim1220 I can’t work with your powershell logs. You’re trying to access the variable Temps in js like your first line. var checkSensorTemps = Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"];
    can you do console.log(Temps) so I can see the structure?

    Please create a github issue if you need help, so I can keep track

    J 3 Replies Last reply Oct 27, 2018, 1:02 AM Reply Quote 0
    • J Offline
      justjim1220 Module Developer @strawberry 3.141
      last edited by Oct 27, 2018, 1:02 AM

      @strawberry-3-141

      it throws this error…

      Uncaught (in promise) ReferenceError: Temps is not defined
          at Class.getDom (MMM-PC-Stats.js:103)
          at main.js:110
          at new Promise (<anonymous>)
          at updateDom (main.js:109)
          at Object.updateDom (main.js:514)
          at Class.updateDom (module.js:358)
          at Class.socketNotificationReceived (MMM-PC-Stats.js:218)
          at module.js:246
          at r.<anonymous> (socketclient.js:25)
          at r.emit (index.js:133)
      

      "Life's Too Short To Dance With Ugly People"
      Jim Hallock - 1995

      S 1 Reply Last reply Oct 27, 2018, 1:06 AM Reply Quote 0
      • S Offline
        strawberry 3.141 Project Sponsor Module Developer @justjim1220
        last edited by Oct 27, 2018, 1:06 AM

        @justjim1220 if the variable doesn’t even exist, the rest of the code cannot work at all. first you should make sure that you have your data in the variable and then the second step is displaying it.

        It seems like you’re trying to do the ui before you have the data.

        Please create a github issue if you need help, so I can keep track

        J 1 Reply Last reply Oct 27, 2018, 1:12 AM Reply Quote 0
        • J Offline
          justjim1220 Module Developer @strawberry 3.141
          last edited by justjim1220 Oct 27, 2018, 1:08 AM Oct 27, 2018, 1:06 AM

          @strawberry-3-141

          I defined Temps. then got this in console…

          MMM-PC-Stats.js:104 Uncaught (in promise) TypeError: Cannot read property '
          ootwmi:MSAcpi_ThermalZoneTemperature' of undefined
              at Class.getDom (MMM-PC-Stats.js:104)
              at main.js:110
              at new Promise (<anonymous>)
              at updateDom (main.js:109)
              at Object.updateDom (main.js:514)
              at Class.updateDom (module.js:358)
              at Class.socketNotificationReceived (MMM-PC-Stats.js:213)
              at module.js:246
              at r.<anonymous> (socketclient.js:25)
              at r.emit (index.js:133)
          

          "Life's Too Short To Dance With Ugly People"
          Jim Hallock - 1995

          1 Reply Last reply Reply Quote 0
          • J Offline
            justjim1220 Module Developer @strawberry 3.141
            last edited by Oct 27, 2018, 1:12 AM

            @strawberry-3-141

            I had a syntax error in the declaration of Temps.

            I’m totally thinking this isn’t going to work.

            I will probably need to find a different way,
            figured if I could pull it from the SIMBIOS using a simple script, that maybe it could be pulled using a module for MM.

            there are some open source apps for Windows that work to get the data, I will just have to study them and see what I can come up with.

            Thanks for trying to help.

            "Life's Too Short To Dance With Ugly People"
            Jim Hallock - 1995

            S 1 Reply Last reply Oct 27, 2018, 6:39 AM Reply Quote 0
            • S Offline
              strawberry 3.141 Project Sponsor Module Developer @justjim1220
              last edited by Oct 27, 2018, 6:39 AM

              @justjim1220 if you don’t even have the data in js, you can also execute it in the node helper and parse the response https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

              Please create a github issue if you need help, so I can keep track

              1 Reply Last reply Reply Quote 0
              • J Offline
                justjim1220 Module Developer @strawberry 3.141
                last edited by Oct 29, 2018, 1:33 AM

                @strawberry-3-141

                What are the chances of being able to do what I had been attempting with this?
                https://github.com/moxystudio/node-cross-spawn

                And would it be possible to add to a current node_helper being used for linux, or would a separate node_helper or script need made?

                "Life's Too Short To Dance With Ugly People"
                Jim Hallock - 1995

                ? 1 Reply Last reply Oct 29, 2018, 6:54 AM Reply Quote 0
                • ? Offline
                  A Former User @justjim1220
                  last edited by A Former User Oct 29, 2018, 7:56 AM Oct 29, 2018, 6:54 AM

                  @justjim1220

                  exec(“YOUR-SHELL-COMMAND”, (error, stdout, stderr)=>{
                    console.log(stdout)
                    // do your job with `stdout`
                  })
                  

                  I think you can get the result of any execution of shell script.

                  J 1 Reply Last reply Oct 30, 2018, 12:07 AM Reply Quote 1
                  • J Offline
                    justjim1220 Module Developer @Guest
                    last edited by Oct 30, 2018, 12:07 AM

                    @sean

                    Not sure I follow …

                    what would be my ‘shell command’?

                    "Life's Too Short To Dance With Ugly People"
                    Jim Hallock - 1995

                    ? 1 Reply Last reply Oct 30, 2018, 12:29 AM Reply Quote 0
                    • ? Offline
                      A Former User @justjim1220
                      last edited by A Former User Oct 30, 2018, 12:30 AM Oct 30, 2018, 12:29 AM

                      @justjim1220
                      **
                      PS C:\WINDOWS\system32> get-temperature
                      **
                      I don’t know anything about your intention, but ‘get-temperature’ could be executable in your shell or terminal, it could be the one.

                      J 1 Reply Last reply Oct 30, 2018, 12:45 AM Reply Quote 1
                      • 1
                      • 2
                      • 3
                      • 2 / 3
                      2 / 3
                      • First post
                        13/21
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy