help converting code for module...

[justjim1220]

latest attempt with this code…

var checkSensorTemps = Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"];
if (typeof checkSensorTemps !== "undefined") {

	// Core Temps
	var core0Temp = document.createElement("div");
	core0Temp.classList.add("large", "bright", "core0Temp");
	core0Temp.innerHTML = Stats.cpu.threads[i].name + " &nbsp  @  &nbsp " 
		+ ((Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value / 10) -273.15) + " °C "
		+ ((((Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value / 10) -273.15) * 9/5) + 32) + " °F "
		+ (Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"].value  / 10) + "°K";
	wrapper.appendChild(core0Temp);
}

HELP! LMAO! :face_with_stuck-out_tongue_winking_eye:

[strawberry 3.141]

@justjim1220 do you have a log of the structure of Temps

[justjim1220]

@strawberry-3-141

PS C:\WINDOWS\system32> powershell.exe Get-WmiObject MSAcpi_ThermalZoneTemperature -Namespace "root/wmi"


__GENUS              : 2
__CLASS              : MSAcpi_ThermalZoneTemperature
__SUPERCLASS         : MSAcpi
__DYNASTY            : MSAcpi
__RELPATH            : MSAcpi_ThermalZoneTemperature.InstanceName="ACPI\\ThermalZone\\THRM_0"
__PROPERTY_COUNT     : 12
__DERIVATION         : {MSAcpi}
__SERVER             : DESKTOP-BEUARKC
__NAMESPACE          : root\wmi
__PATH               : \\DESKTOP-BEUARKC\root\wmi:MSAcpi_ThermalZoneTemperature.InstanceName="ACPI\\ThermalZone\\THRM_0
                       "
Active               : True
ActiveTripPoint      : {0, 0, 0, 0...}
ActiveTripPointCount : 0
CriticalTripPoint    : 3762
CurrentTemperature   : 3172
InstanceName         : ACPI\ThermalZone\THRM_0
PassiveTripPoint     : 3882
Reserved             : 0
SamplingPeriod       : 100
ThermalConstant1     : 2
ThermalConstant2     : 10
ThermalStamp         : 25
PSComputerName       : DESKTOP-BEUARKC

[justjim1220]

@strawberry-3-141

this script ran in powershell …

function Get-Temperature {
    $t = Get-WmiObject MSAcpi_ThermalZoneTemperature -Namespace "root/wmi"
    $returntemp = @()

    foreach ($temp in $t.CurrentTemperature)
    {
        $currentTempKelvin = $temp / 10
        $currentTempCelsius = $currentTempKelvin - 273.15
        $currentTempFahrenheit = (9/5) * $currentTempCelsius + 32
        $returntemp += $currentTempCelsius.ToString() + " C : " + $currentTempFahrenheit.ToString() + " F : " + $currentTempKelvin + "K"  
    }
    return $returntemp
}

gives the following output for a single core …

PS C:\WINDOWS\system32> get-temperature
44.05 C : 111.29 F : 317.2K

I’m really only interested in a C and F result, no need for K that I can think of.

[strawberry 3.141]

@justjim1220 I can’t work with your powershell logs. You’re trying to access the variable Temps in js like your first line. var checkSensorTemps = Temps["\root\wmi:MSAcpi_ThermalZoneTemperature"]["ACPI\ThermalZone"]["THRM_0"];
can you do console.log(Temps) so I can see the structure?

[justjim1220]

@strawberry-3-141

it throws this error…

Uncaught (in promise) ReferenceError: Temps is not defined
    at Class.getDom (MMM-PC-Stats.js:103)
    at main.js:110
    at new Promise (<anonymous>)
    at updateDom (main.js:109)
    at Object.updateDom (main.js:514)
    at Class.updateDom (module.js:358)
    at Class.socketNotificationReceived (MMM-PC-Stats.js:218)
    at module.js:246
    at r.<anonymous> (socketclient.js:25)
    at r.emit (index.js:133)

[strawberry 3.141]

@justjim1220 if the variable doesn’t even exist, the rest of the code cannot work at all. first you should make sure that you have your data in the variable and then the second step is displaying it.

It seems like you’re trying to do the ui before you have the data.

[justjim1220]

@strawberry-3-141

I defined Temps. then got this in console…

MMM-PC-Stats.js:104 Uncaught (in promise) TypeError: Cannot read property '
ootwmi:MSAcpi_ThermalZoneTemperature' of undefined
    at Class.getDom (MMM-PC-Stats.js:104)
    at main.js:110
    at new Promise (<anonymous>)
    at updateDom (main.js:109)
    at Object.updateDom (main.js:514)
    at Class.updateDom (module.js:358)
    at Class.socketNotificationReceived (MMM-PC-Stats.js:213)
    at module.js:246
    at r.<anonymous> (socketclient.js:25)
    at r.emit (index.js:133)

[justjim1220]

@strawberry-3-141

I had a syntax error in the declaration of Temps.

I’m totally thinking this isn’t going to work.

I will probably need to find a different way,
figured if I could pull it from the SIMBIOS using a simple script, that maybe it could be pulled using a module for MM.

there are some open source apps for Windows that work to get the data, I will just have to study them and see what I can come up with.

Thanks for trying to help.

[strawberry 3.141]

@justjim1220 if you don’t even have the data in js, you can also execute it in the node helper and parse the response https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback