MMM-DarkSkyForecast - Yet ANOTHER weather module

rudibarani

So beautiful - thank you very much!!
This is more than an adequate replacement for MyWeather. Great job!

I’d like to bring forward three questions:

Does the module support the USER_PRESENCE notification to suspend / resume API calls? If not, it would be nice if you could consider that.
Could you please add an option for a"label_timeFormatSuffix"? It would be nice if the time could be displayed like “14h” if one uses the 24h format.
Could you please add an option to hide the icons above the table (umbrella and wind) to make it more compact, if needed?

j.e.f.f

@rudibarani said in MMM-DarkSkyForecast - Yet ANOTHER weather module:

Does the module support the USER_PRESENCE notification to suspend / resume API calls?

It doesn’t suspend API calls based on user presence. This is intentional. I don’t spend more than about 30 seconds looking at my mirror, so when I do, I want the information that appears to be immediately up to date. By default the module polls every ten minutes for data, so you don’t run the risk of exceeding the 1000 request limit per day, nor are you really burning up a lot of CPU cycles to do so.

@rudibarani said in MMM-DarkSkyForecast - Yet ANOTHER weather module:

Could you please add an option for a"label_timeFormatSuffix"?

This is already possible. Look at the label_timeFormat parameter

@rudibarani said in MMM-DarkSkyForecast - Yet ANOTHER weather module:

Could you please add an option to hide the icons above the table (umbrella and wind) to make it more compact, if needed?

I’ll add this in at some point, but you can do it now in your custom CSS. Just hide the div with the .header-row class, like so:

.MMM-DarkSkyForecast .header-row {
  display: none;
}

rudibarani

Dear @j-e-f-f,
thanks for the quick reply. Today, I tried to get my toes wet with JS coding and added an option to hide the column header icons from the forecast table or optionally show a header above the forecast table. It seems to work as expected and I have created a pull-request to give others access to the feature as well and maybe safe you some time.

I also found a way to hide the vertical lines from the table via the custom.css file and now the module looks even better, if a fullscreen background image is used.

j.e.f.f

@smotx I fixed a bug with the summary display last night. Try doing a git pull in the MMM-DarkSkyForecast directory, then restart MagicMirror. See if that fixes it.

j.e.f.f

@rudibarani I merged your pull request, but then I did a bit of refactoring. I renamed the the parameter forecastTableHeaderText to forecastHeaderText, as it can be used in both the table and tiled views.

I also fixed up how the header is formatted. I’m now using an HTML5 header element and it has two classes: module-header so that it is formatted the same as all of the other module headers, and forecast-header if you want to target it specifically with CSS.

Lastly, this update enables notifications for other modules. The notification is called DARK_SKY_FORECAST_WEATHER_UPDATE and the payload is Dark Sky’s weather JSON object. For details see https://darksky.net/dev/docs.

RedNax

@j-e-f-f :) This looks familiar… well done!

BKeyport

Does it handle midnight properly in 12 hour mode? So darned tired of the 0am stuff the other DarkSky one has. ;)

rudibarani

@j-e-f-f said in MMM-DarkSkyForecast - Yet ANOTHER weather module:

I also fixed up how the header is formatted. I’m now using an HTML5 header element and it has two classes: module-header so that it is formatted the same as all of the other module headers, and forecast-header if you want to target it specifically with CSS.

Thanks for accepting my pull request and your improvements. They help me learn how this all works.

I have some trouble with the animated current conditions icons. Sometimes they do not show up, although configured - and reappear on a restart. Sometimes they are shown only for one instance of MMM-DarkSkyForecast. Do you have any idea, what might be the cause?

A second question: I have limited the max-width of MMM-DarkSkyForecast to 250px as I would like to have my mirror with cascading module widths with in creasing width the lower a module is. This works fine on the left side. If I send MMM-DarkSkyForecast to the right side and the module below is wider, it is aligned on the left side of the right region. Do you have any advice how to right align all modules in the right region?

Hein-Jan

@j-e-f-f ,

I am also stuck at “Loading” actually it says “Bezig met laden…” which is Dutch for “Loading”.

I ran the “git clone…”, switched to the “MMM-DarkSkyForecast” directory, and ran the NPM Install.
I do get this warning: “npm WARN mmm-darkskyforecast@1.0.0 No repository field.”, but I do not know how to act upon it.

The module is making calls to DarkSky, I see that in the Api usage.

The logs show no error.
This is the config:

		{
  			module: "MMM-DarkSkyForecast",
  			header: "Weersverwachting",
  			position: "top_right",
//  			classes: "default everyone",
  			disabled: false,
  			config: {
    				apikey: "XXXXXXXXXXXXX",
    				latitude: "51.5096192",
    				longitude: "5.6364183",      
    				iconset: "1c",
//				maxHourliesToShow: 4,
//				maxDailiesToShow: 4,
//				useAnimatedIcons: true,
    				concise: false,
//				label_timeFormat: "k[h]",
    				forecastLayout: "table"
			}
		},

I am not sure were I went wrong. Can you provide help?

Kind Regards,

Hein-Jan

karsten13

Same here with “Loading” and nothing happens.

Seems to be a problem with lon/lat.

If i provide the example lon/lat it works.