Change Compliments

dgregory19

Thanks everyone! Figured it out. Onto breaking something else…

CheapDad

My apologies for resurrecting a dead thread, but it seemed like keeping all similar questions to one thread might be useful to others.

I was happy with the default compliments, but wanted to customize them to the user. I copied the compliments entries from compliments.js and inserted them into my config.js. I don’t get any errors when I run config:check, but the compliments no longer appear on the screen. Here’s my code:

		{
			module: "compliments",
			position: "lower_third",
			config:  {
				compliments: {
					anytime: ["Hey there Emma!"],
					morning: ["Good morning, Emma!", "Enjoy your day!", "How was your sleep?"],
					afternoon: ["Hello, Emma!", "You look beautiful!", "Looking good today!"],
					evening: ["Wow, you look great!", "You look nice!", "Hi, Emma!"],
					"....-01-01": ["Happy new year!"]
		}
},

sdetweil

@cheapdad u should have gotten an error in the window where u start MM…
I do copying your stuff

		},
		^
SyntaxError: Unexpected token '}'
    at wrapSafe (internal/modules/cjs/loader.js:1060:16)
    at Module._compile (internal/modules/cjs/loader.js:1108:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:10)
    at Module.load (internal/modules/cjs/loader.js:992:32)
    at Module._load (internal/modules/cjs/loader.js:885:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12738)
    at loadApplicationPackage (/home/sam/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js:110:16)
    at Object.<anonymous> (/home/sam/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js:222:9)
    at Module._compile (internal/modules/cjs/loader.js:1152:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1173:10)

and npm config:check says

(base) sam@sams:~/MagicMirror$ npm run config:check

> magicmirror@2.15.0 config:check /home/sam/MagicMirror
> node js/check_config.js

[24.04.2021 15:25.20.258] [INFO]  Checking file...  /home/sam/MagicMirror/config/config.js
[24.04.2021 15:25.20.270] [ERROR] Your configuration file contains syntax errors :(
[24.04.2021 15:25.20.270] [ERROR] Line 56 column 7: Parsing error: Unexpected token {

shorter answer, u are missing a }

CheapDad

@sdetweil That’s the strange thing, I’m not getting any errors when I run npm run config:check.

Unfortunately, I had to rebuild my config.js since I installed a module, edited config.js and ended up with a blank screen that no commenting the config.js entries didn’t fix.

Here’s the new (old) compliments entries:

			module: "compliments",
			position: "lower_third",
			config:  {
				compliments: {
					anytime: ["Hey there Emma!"],
					morning: ["Good morning, Emma!", "Enjoy your day!", "How was your sleep?"],
					afternoon: ["Hello, Emma!", "You look beautiful!", "Looking good today!"],
					evening: ["Wow, you look great!", "You look nice!", "Hi, Emma!"],
					"....-01-01": ["Happy new year!"]
		}
	},

And my npm run config:check:

pi@emmasmagicmirror:~/MagicMirror $ npm run config:check

> magicmirror@2.15.0 config:check /home/pi/MagicMirror
> node js/check_config.js

[24.04.2021 16:58.15.197] [INFO]  Checking file...  /home/pi/MagicMirror/config/config.js
[24.04.2021 16:58.15.352] [INFO]  Your configuration file doesn't contain syntax errors :)
pi@emmasmagicmirror:~/MagicMirror $

sdetweil

@cheapdad

the thing is

{ 
    module:"name",
    position:"...",
    config: { 
        compliments: {
        }   //< ---- this brace is missing
    }
}

get bitvise ssh client, then u can have a file manager view from windows
and use notepad++ to edit  and see the  brace, paren and bracket matching

CheapDad

Forgive me for pursuing this, but I see an opportunity to really learn here. When I look at my code, I have closed all of my braces:

    },
			module: "compliments",
			position: "lower_third",
			config:  {  \\ open
				compliments: {  \\open
					anytime: ["Hey there Emma!"],
					morning: ["Good morning, Emma!", "Enjoy your day!", "How was your sleep?"],
					afternoon: ["Hello, Emma!", "You look beautiful!", "Looking good today!"],
					evening: ["Wow, you look great!", "You look nice!", "Hi, Emma!"],
					"....-01-01": ["Happy new year!"]
		}   \\close
	}, \\close
			module: "weather",

If I add another closing brace, won’t I have an error because there is no opening brace?

On the suggestion for bitvise ssh, I’m working directly off the pi itself. I would love to run the entire MM configuration in a vm until it is right and then simply copy that over to the pi, but that’s a bit beyond my knowledge level.

sdetweil

@cheapdad u are missing the open brace for the module block in this last picture (see my layout above)

if you use bitvise then u dont have to edit ON the pi keyboard…
also gives u an ssh window to execute commands, again NOT on the pi keyboard

u can run raspian x86 in a vm on pc…

CheapDad

I think I figured it out and see where I needed a third closing brace. The weird thing is that Compliments seems to be the only module that doesn’t start with an opening brace, where all the others appear to. If I add an opening brace to it, I get an error. If I leave it out, it runs.

sdetweil

@cheapdad EVERY module MUST start with an opening brace…

ignore any typos you find somewhere else…

see my module diagram above

CheapDad

@sdetweil Got it.