MMM-MyScoreboard

sithas

looks great

could you show us what your "yesterdays’ would look like?
Is it all teams or just your favourite teams ( if i was to have The peguins and Predators would it show 2 or only 1 time ) Not that, that will ever happen Go WILD !

j.e.f.f

@sithas Yesterdays will just look like final scores. There’s no indication that they are from yesterday. The display will change to the actual list of today’s games starting later when the rollover time passes.

This module just shows the games for the teams you want to follow. If you want to see all games then you need to put all teams in the follow list. You’ll only see one game listed if both teams are in your follow list.

Spankythemusical

Jeff,

I have a question/huge favor. I’m trying to add NCAAF to this module. Unfortunately, I have exactly 0.2% experience with js. I can parse the website with Python and get the information I’m looking for, but I do not know how to translate that to js. I have taken your NBA.js and changed it in an attempt to make it work, but I’m sure I’m not even close to where I need to be. When you have a few free moments (i.e. this is not at all an important endeavor), could you look over where I am and point me closer to the right direction? I cannot tell you how much I would appreciate it. (I’ve realized that I cannot upload the text file, but I can copy/paste the code here)

j.e.f.f

@Spankythemusical I’m travelling this week, but I’ll have a look when I get back next week. Is the Fred a public JSON feed or are you scraping the NCAA website?

P-Bo726

Love this module! Does this module allow more than one module to run at a time. I can’t seem to get more than one to run. Config file errors out. Could this feature be added? Why would I need this? I’d like to have one league down the right hand side and one down the left hand side.

Spankythemusical

@j.e.f.f Thank you. Like I said, it’s not a big thing that needs immediate attention. The feed is a public JSON feed from ESPN.

j.e.f.f

@Spankythemusical all of the current sports my module supports use public JSON feeds. If you want, take a look at, say, NBA to get an idea how it works.

j.e.f.f

@P-Bo726 it does not. Since the module takes care of dividing up the sports for you I didn’t see a reason for multiple instances.

Spankythemusical

@j.e.f.f I actually used the MBA section as the template. Unfortunately, I do not have close to enough experience with js to ensure that it is correct. Is there a section of code that controls if the section is hidden or showing? If I could make the section how even without an upcoming game, then I could see if what I’ve done so far is successful.

P-Bo726

@j.e.f.f I’m in the process of building an all sports dashboard and could use multiple instances. I’d benefit from that feature and other may see a use for it as well. Please, Please :)

j.e.f.f

@Spankythemusical you won’t have to touch the front end logic. Your NCAA extension file handles what the front end will receive. Typically the way the other sports work is that the sport is configured with the teams you wish to follow. Then you’ll query for all of “today’s” games, then filter what gets returned to the list of teams to follow. There is a README under the sports directory that goes into more detail about all of this.

You’ll also need to add your sport to the list of supported sports in node_helper.js. It’s an array near the top of the file.

Lastly, in case there are any special CSS requirements for your sport you may need to add some rules to MMM-MyScoreboard.css. But it should look pretty good right out of the box.

In any case I’ll lend a hand when I get back next week.

j.e.f.f

@P-Bo726 I’m travelling all this week but I’ll see what I can do when I get back.

onetwankyfive

+1 to NCAAF
This would be amazing

j.e.f.f

@P-Bo726 So it looks like I’d need to make a pretty significant rewrite to make this module work with multiple instances. Right now my node_helper module stores quite a bit of instance information, including what supported sports modules are required – this part in particular poses a real problem being stored as instance configuration, as opposed to a global module configuration.

I’ll spend some time thinking about how this might be architected, but I don’t think this will happen any time soon, sorry to say.

If you wanted to get your hands dirty, you could manually make multiple instances of this module, but it’s really hacky. Make a copy of the MMM-MyScoreboard directory (Say, MMM-MyScoreBoard2). rename MMM-MyScorboard.js to MMM-MyScoreboard2.js. Do the same to the CSS file and rename it to MMM-MyScoreboard2.css. In the MMM-MyScoreboard2.js file, you’ll need to adjust line 12 Module.register("MMM-MyScoreboard" to read Module.register("MMM-MyScoreboard2" and similarly line 38 return ["MMM-MyScoreboard.css"]; to return ["MMM-MyScoreboard2.css"];

Finally, do a search and replace in MMM-MyScoreboard2.css and replace all instances of MMM-MyScoreboard with MMM-MyScoreboard2.

Now you have two independent modules - MMM-MyScoreboard and MMM-MyScoreboard2 - that you can configure separately in your config file.

You can do this as many times as you like, so long as each time you are using a different name.

P-Bo726

Thank you for the response. I’ll take a look at that hack you provided. If you find some "free’’ time and want to work on the multiple instances I would still find some value in it. No pressure, no hurry. I appreciate all the work you have put into this module and the MM forum in general. Great work!

j.e.f.f

@P-Bo726 Need to get NFL up and running before anything else. Pre-season starts this week!

Krisalexroberts 0

Could you get this working with Pointstreak? Lots of minority leagues/sports use Pointstreak such as the UK Elite Ice Hockey League (EIHL)

j.e.f.f

@Krisalexroberts-0 I’ll take a look to see if there is a public data feed available for this. If so, it should be doable. It will take some time to amass all of the logos and such, but I like the potential for many leagues working with a single API.

I still have to finish with NFL – I had it working with last night’s game, but I’d like to run it against next week’s preseason lineup to see if there are any gotchas before I release it.

So far I have requests for NCAAF, Pointstreak and eSports. Should be an interesting summer!

Krisalexroberts 0

@j.e.f.f you’re a star!

I don’t know if this helps: https://github.com/eikeco/pointstreak-leauge-table

j.e.f.f

@Krisalexroberts-0 it does. Seems to be hit or miss as to which leagues have data feeds. Are there specific leagues that you’re looking to see incorporated? Doesn’t look like I can just incorporate blanket pointstreak support.