MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Changing compliments

    Scheduled Pinned Locked Moved Troubleshooting
    49 Posts 9 Posters 43.1k Views 9 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • A Offline
      AliAS @AliAS
      last edited by

      @AliAS remember after locating and fixing the error to hit ctrl + o to save and ctrl + x to exit nano.

      1 Reply Last reply Reply Quote 1
      • A Offline
        AliAS
        last edited by

        Another suggestion, and someone please correct me if I am wrong, you could delete the config.js file and save as or copy the config-sample.js as a new config.js file. That way you have a functioning config.js. But doing so, you would have to reconfigure all your modules. Does that sound right?

        Mykle1M 1 Reply Last reply Reply Quote 1
        • Mykle1M Offline
          Mykle1 Project Sponsor Module Developer @AliAS
          last edited by

          @AliAS said in Changing compliments:

          Does that sound right?

          Sure, but another idea would be to rename the non-functioning config (so you don’t lose what’s in it) and THEN make a new copy of the config.js.sample and rename it to config.js. :-)

          Create a working config
          How to add modules

          S 1 Reply Last reply Reply Quote 2
          • S Offline
            Stacy @Mykle1
            last edited by

            @Mykle1 Okay. We finally figured it out. We made an external join file for new compliments and that worked. Thank you all SOuch for your help.

            1 Reply Last reply Reply Quote 1
            • Mykle1M Offline
              Mykle1 Project Sponsor Module Developer
              last edited by

              Well done! :-)

              Create a working config
              How to add modules

              1 Reply Last reply Reply Quote 0
              • A Offline
                AliAS
                last edited by

                External join file? Lol, thats way outta my league.

                1 Reply Last reply Reply Quote 0
                • A Offline
                  AliAS
                  last edited by

                  Does anybody know how to use a line break within a compliment? I’ve tried about a dozen different ways to no avail.

                  D 1 Reply Last reply Reply Quote 0
                  • D Offline
                    doubleT Module Developer @AliAS
                    last edited by

                    @AliAS
                    Compliments are included via document.createTextNode(complimentText); which doesn’t allow HTML inside.

                    But you can change the line within getDom: function() {} that includes the compliment from
                    wrapper.appendChild(compliment);
                    to
                    wrapper.innerHTML = complimentText;

                    and then just add a <br /> to the compliment.

                    A 1 Reply Last reply Reply Quote 3
                    • A Offline
                      AliAS
                      last edited by

                      I see. I’ll give it a try. Thank you very much.

                      1 Reply Last reply Reply Quote 0
                      • A Offline
                        AliAS @doubleT
                        last edited by

                        @doubleT That worked perfect. Thanks again!

                        1 Reply Last reply Reply Quote 0
                        • K Offline
                          KC5RIL
                          last edited by

                          Oh, great! Another noob needs help configuring the Compliments module. I’ve sussed through this for two days trying to get this up and running to earn ‘cool dad points.’ I’ve followed along and made changes to the config.js file as described. When I run ‘npm start’ I get the following: ```
                          code_text

                          
                          > magicmirror@2.12.0 start /home/pi/MagicMirror
                          > DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js
                          
                          [2020-08-19 20:06:47.257] [LOG]    Starting MagicMirror: v2.12.0
                          [2020-08-19 20:06:47.264] [LOG]    Loading config ...
                          [2020-08-19 20:06:47.268] [ERROR]  WARNING! Could not validate config file. Starting with default configuration. Please correct syntax errors at or above this line: /home/pi/MagicMirror/config/config.js:68
                          			config: {
                          			^^^^^^
                          
                          SyntaxError: Unexpected identifier
                              at Module._compile (internal/modules/cjs/loader.js:722:23)
                              at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10)
                              at Module.load (internal/modules/cjs/loader.js:645:32)
                              at Function.Module._load (internal/modules/cjs/loader.js:560:12)
                              at Module.require (internal/modules/cjs/loader.js:685:19)
                              at require (internal/modules/cjs/helpers.js:16:16)
                              at loadConfig (/home/pi/MagicMirror/js/app.js:67:12)
                              at App.start (/home/pi/MagicMirror/js/app.js:202:3)
                              at Object.<anonymous> (/home/pi/MagicMirror/js/electron.js:126:7)
                              at Module._compile (internal/modules/cjs/loader.js:786:30)
                          [2020-08-19 20:06:47.269] [LOG]    Loading module helpers ...
                          [2020-08-19 20:06:47.317] [LOG]    Initializing new module helper ...
                          [2020-08-19 20:06:47.318] [LOG]    Module helper loaded: updatenotification
                          [2020-08-19 20:06:47.321] [LOG]    No helper found for module: helloworld.
                          [2020-08-19 20:06:47.322] [LOG]    All module helpers loaded.
                          [2020-08-19 20:06:47.445] [LOG]    Starting server on port 8080 ... 
                          [2020-08-19 20:06:47.458] [LOG]    Server started ...
                          [2020-08-19 20:06:47.459] [LOG]    Connecting socket for: updatenotification
                          [2020-08-19 20:06:47.460] [LOG]    Sockets connected & modules started ...
                          [2020-08-19 20:06:47.556] [LOG]    Launching application.
                          
                          

                          What am I looking at? And how can I correct? Bear with a middle aged noob. You might have to explain this in crayon. Thanks for the help.

                          Mykle1M S 2 Replies Last reply Reply Quote 0
                          • Mykle1M Offline
                            Mykle1 Project Sponsor Module Developer @KC5RIL
                            last edited by

                            @KC5RIL

                            Post your config entry for compliments in a code block

                            Create a working config
                            How to add modules

                            K 1 Reply Last reply Reply Quote 0
                            • S Offline
                              sdetweil @KC5RIL
                              last edited by

                              @KC5RIL > Unexpected identifier

                              90% of the time this means a comma missing on the line above

                              Sam

                              How to add modules

                              learning how to use browser developers window for css changes

                              K 1 Reply Last reply Reply Quote 1
                              • K Offline
                                KC5RIL @sdetweil
                                last edited by

                                @sdetweil Stand by, ya’ll. I’m proofing now. Just caught a misplaced comma.

                                S 1 Reply Last reply Reply Quote 0
                                • S Offline
                                  sdetweil @KC5RIL
                                  last edited by

                                  @KC5RIL npm config:check can show these errors.

                                  has a bug in 2.12, temp fix posted to the top of the troubleshooting section

                                  Sam

                                  How to add modules

                                  learning how to use browser developers window for css changes

                                  1 Reply Last reply Reply Quote 1
                                  • K Offline
                                    KC5RIL @Mykle1
                                    last edited by

                                    @Mykle1 Here’s the code. Figured this seemed like a popular spot to wet my feet. If I could get through this, I could set the rest up.

                                    {
                                    			module: "compliments",
                                    			position: "lower_third"
                                    
                                    			config: {
                                    			 	   compliments: {
                                    			 	   "....-01-01": [
                                    			 	   "Happy New Year!"
                                    				   ],
                                    			    	   "....-01-07": [
                                    				   "Happy Birthday, Matt!"
                                    				   ],
                                    				   "....-01-08": [
                                    				   "Hail to the King, Baby!",
                                    				   "I'm all shook up!",
                                    				   "You ain't nuthin' but a hound dog!"
                                    				   ],
                                    				   "....-01-25": [
                                    				   "yaD etisoppO yppaH"
                                    				   ],
                                    				   "2021-02-02": [
                                    				   "It's Groundhog Day \nAgain!"
                                    			   	   ],
                                    				   "....-02-14": [
                                    				   "Happy Valentine's Day!"
                                    				   ],
                                    				   "2021-02-16": [
                                    				   "Laissez les bon temps rouler!"
                                    				   ],
                                    				   "....-03-14": [
                                    				   "Time for Pi!"
                                    				   ],
                                    				   "2021-03-17": [
                                    				   "Erin Go Bragh!",
                                    				   "Kiss Me! \nI'm Irish"
                                    				   ],
                                    				   "....-04-01": [
                                    				   "Your shoes are untied.",
                                    				   "Made you look.",
                                    				   "April Fools!"
                                    				   ],
                                    				   "2021-04-04": [
                                    				   "Happy Easter!",
                                    				   "Rejoice!",
                                    				   "He is Risen!"
                                    				   ],
                                    				   "....-05-04": [
                                    				   "May the Fourth be with you!"
                                    				   ],
                                    				   "....-05-06": [
                                    				   "Revenge of the Sixth!"
                                    				   ],
                                    				   "....-05-09": [
                                    				   "Happy Mother's Day!"
                                    				   ],
                                    				   "....-05-25": [
                                    				   "Don't forget your towel.",
                                    				   "42!"
                                    				   ],
                                    				   "2021-05-31": [
                                    				   "Happy Memorial Day!"
                                    				   ],
                                    				   "2021-06-20": [
                                    				   "Happy Father's Day!"
                                    				   ],
                                    				   "....-07-04": [
                                    				   "Celebrate your Independence!",
                                    				   "Freedom!",
                                    				   "Happy Fourth of July!"
                                    				   ],
                                    				   "....-07-09": [
                                    				   "Happy Birthday, Noodle!"
                                    				   ],
                                    				   "....-08-14": [
                                    				   "Happy Anniversary!"
                                    				   ],
                                    				   "2021-09-06": [
                                    				   "Happy Labor Day!"
                                    				   ],
                                    				   "....-09-11": [
                                    				   "Never Forget.",
                                    				   "Some gave all",
                                    				   "343/61",
                                    				   "Let's Roll!"
                                    				   ],
                                    				   "...-10-..": [
                                    				   "Boo!"
                                    				   ],
                                    				   "....-11-16": [
                                    				   "Happy Birthday, Susanne!"
                                    				   ],
                                    				   "2021-11-25": [
                                    				   "Gobble! Gobble!",
                                    				   "Happy Thanksgiving!"
                                    				   ],
                                    				   "....-12-07": [
                                    				   "A day that will live in infamy!"
                                    				   ],
                                    				   "....-12-23": [
                                    				   "Time to air our grievances!",
                                    				   "Festivus for the rest of us!"
                                    				   ],
                                    				   "....-12-25": [
                                    				   "Merry Christmas, Charlie Brown!",
                                    				   "Rejoice!",
                                    				   "Christ the Savior is born!"
                                    				   ],
                                    				   anytime: {
                                    				   "Hey!",
                                    				   "Hello.",
                                    				   "Whaddup Dog?",
                                    				   "Dude!",
                                    				   "Hej!",
                                    				   "You stay classy!"
                                    				   ],
                                    				   morning: [
                                    				   "Good Morning!",
                                    				   "Smile \nIt's a beautiful day!",
                                    				   "Rise and Shine!",
                                    				   "Wakey Wakey! \nEggs & Baky!",
                                    				   "Coffee is ready!"
                                    				   ],
                                    				   afternoon: [
                                    				   "Is it beer-thirty, yet?",
                                    				   "What a wonderful day!"
                                    				   ],
                                    				   evening: [
                                    				   "Good Evening."
                                    				   ]
                                    			}
                                    		},
                                    

                                    While ya’ll are looking at that, I’ll check the troubleshooting section. Thanks

                                    S 1 Reply Last reply Reply Quote 0
                                    • S Offline
                                      sdetweil @KC5RIL
                                      last edited by

                                      @KC5RIL

                                      position: "lower_third"
                                      
                                      			config: {
                                      

                                      why did I say?
                                      comma missing on the line before the error

                                      position: "lower_third", // < -----
                                      
                                      			config: {
                                      

                                      Sam

                                      How to add modules

                                      learning how to use browser developers window for css changes

                                      1 Reply Last reply Reply Quote 0
                                      • K Offline
                                        KC5RIL
                                        last edited by

                                        Okay! It’s coming together for me. I’m catching a couple more syntax errors. I’ll keep proofing to see if I catch more.

                                        S 1 Reply Last reply Reply Quote 0
                                        • S Offline
                                          sdetweil @KC5RIL
                                          last edited by sdetweil

                                          @KC5RIL general rules for the value to the right of :

                                          numbers and true/false, no quotes,
                                          otherwise needs quotes, doesn’t matter which as long as they are matched.

                                          be careful on quotes, these curly ones " ’
                                          are no good, but these text mode are
                                          ok

                                          "'
                                          

                                          also if the next line starts with a word, then this line needs a trailing comma

                                          Sam

                                          How to add modules

                                          learning how to use browser developers window for css changes

                                          K 1 Reply Last reply Reply Quote 0
                                          • K Offline
                                            KC5RIL @sdetweil
                                            last edited by

                                            @sdetweil I’ve proofed all I can. I don’t see anymore syntax errors. Still won’t run properly. Here’s the config:check ```
                                            pi@WALL-e:~/MagicMirror $ npm run config:check

                                            magicmirror@2.12.0 config:check /home/pi/MagicMirror
                                            node js/check_config.js

                                            [2020-08-19 21:11:52.797] [INFO] Checking file… /home/pi/MagicMirror/config/config.js
                                            [2020-08-19 21:11:52.858] [LOG] Line 194 col 3 Parsing error: Unexpected token {
                                            /home/pi/MagicMirror/js/check_config.js:66
                                            throw new Error(“Wrong syntax in config file!”);
                                            ^

                                            Error: Wrong syntax in config file!
                                            at /home/pi/MagicMirror/js/check_config.js:66:10
                                            at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
                                            npm ERR! code ELIFECYCLE
                                            npm ERR! errno 1
                                            npm ERR! magicmirror@2.12.0 config:check: node js/check_config.js
                                            npm ERR! Exit status 1
                                            npm ERR!
                                            npm ERR! Failed at the magicmirror@2.12.0 config:check script.
                                            npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

                                            npm ERR! A complete log of this run can be found in:
                                            npm ERR! /home/pi/.npm/_logs/2020-08-20T02_11_52_899Z-debug.log

                                            1 Reply Last reply Reply Quote 0

                                            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

                                            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

                                            With your input, this post could be even better 💗

                                            Register Login
                                            • 1
                                            • 2
                                            • 3
                                            • 2 / 3
                                            • First post
                                              Last post
                                            Enjoying MagicMirror? Please consider a donation!
                                            MagicMirror created by Michael Teeuw.
                                            Forum managed by Sam, technical setup by Karsten.
                                            This forum is using NodeBB as its core | Contributors
                                            Contact | Privacy Policy