how to pull new element added to an array?

justjim1220 · Oct 17, 2018, 5:56 PM

SO, I changed this part of the fetcher, but, after reading your posts, I am not sure if this is what you are talking about…

parser.on("item", function(item) {

			var title = item.title;
			var image = item.image || item.logo || item.img || item.svg || "";
			var description = item.description || item.summary || item.content || "";
			var pubdate = item.pubdate || item.published || item.updated || item["dc:date"];
			var url = item.url || item.link || "";

			if (title && pubdate) {

				var regex = /(<([^>]+)>)/ig;
				description = description.toString().replace(regex, "");

				items.push({
					title: title,
					image: image,
					description: description,
					pubdate: pubdate,
					url: url,
				});

			} else if (logFeedWarnings) {
				console.log("Can't parse feed item:");
				console.log(item);
				console.log("Title: " + title);
				console.log("Image: " + image);
				console.log("Description: " + description);
				console.log("Pubdate: " + pubdate);
			}
		});

It is looking like you are telling me I need to add a new section to the fetcher similar to this, but starting with

parser.on("image", function(image){})
			var title = image.title;
			var image = image.image || image.logo || image.img || image.svg || "";
			var url = image.url || image.link || "";

and would I also need this part?

                        if (image&& url) {

				var regex = /(<([^>]+)>)/ig;
				description = description.toString().replace(regex, "");

				images.push({
					title: title,
					image: image,
					url: url,
				});

			} else if (logFeedWarnings) {
				console.log("Can't parse feed item:");
				console.log(item);
				console.log("Title: " + title);
				console.log("Image: " + image);
				console.log("Description: " + description);
				console.log("Pubdate: " + pubdate);
			}
		});

And, would this be the way to add the image url in the config…

                        {
                                imageUrl: "https://static01.nyt.com/images/misc/NYT_logo_rss_250x40.png",
                                title: "New York Times",
				url: "http://www.nytimes.com/services/xml/rss/nyt/HomePage.xml"
                        },
			{
                                imageUrl: "http://online.wsj.com/img/wsj_sm_logo.gif",
				title: "Wall St. Journal",
				url: "http://www.wsj.com/xml/rss/3_7085.xml"
			},
			{
                                imageUrl: "http://www.gannett-cdn.com/sites/usatnetwork/images/RSS_Syndication_Logo-USATN.png",
				title: "USA Today",
				url: "http://rssfeeds.usatoday.com/UsatodaycomNation-TopStories"
			},
			{
                                imageUrl: "https://news.bbcimg.co.uk/nol/shared/img/bbc_news_120x60.gif",
				title: "BBC World News",
				url: "http://feeds.bbci.co.uk/news/world/rss.xml#"
			}

Sorry, for all the questions, just really trying to learn all this…
AND, thanks for all your help!!! :smiling_face_with_sunglasses:

sdetweil · Oct 17, 2018, 5:57 PM

ok, then to use the definition in the feed entry
modify the node helper

			fetcher = new Fetcher(url, reloadInterval, encoding, config.logFeedWarnings);

			fetcher.onReceive(function(fetcher) {
                                // add code here to run thru the array of feed response items and add the icon url to each entry..
                                // the feed definition was passed in as parm to the containing method..   because this is a callback, you will probably have to bind the feed definition to this function
                                for( var item in fetcher.items())
                                {
                                     item.icon=this.feed_def.icon;
                                 }
				self.broadcastFeeds();
			}.bind({feed_def:feed}))

justjim1220 · Oct 17, 2018, 6:08 PM

@sdetweil

well, sort of lost me there, but also getting a headache.

Gotta run some errands, I’ll look at it some more after a while.

AGAIN, THANK YOU for all the help!!!

sdetweil · Oct 17, 2018, 8:27 PM

@justjim1220 said in how to pull new element added to an array?:

var image = item.image || item.logo || item.img || item.svg || “”;

that looks good, except as you note, these are optional in the response (item) data.

do you want to use the configured url for the feed if not present?

var image = item.image || item.logo || item.img || item.svg || xxxx.yyy.icon || "";

the feed definition is passed into the fetcher function. except that routine could have ended seconds ago, when the parser.on(item) method is called (by the callback)…

so, what should xxxx.yyy be? can’t use the parm feed directly, as the routine could have exited already…

so, javascript gives you the ability to bind (connect) a variable with a routine when it is called asyncronously…

when u bind the variable, it will be accessible in the context of the function, context = this,

so, on the close brace of the function defined on the .on(), add the .bind() clause.

inside the bind clause, you specify the name of the variable INSIDE the function, and connect it to the variable at the time the .on() definition is called… (ie ‘feed’)…

so,

}.bind({feed_var_in_function:feed})

then when the function is called, you can get access to the variable using ‘this’…

this.feed_var_in_function.icon, would be the icon defined for THIS feed

therefore the stmt above would be

var image = item.image || item.logo || item.img || item.svg || this.feed_var_in_function.icon || "";

this says, use any of the optional images in the feed item, if present,
else use the user defined feed icon,
else nothing if not defined…

justjim1220 · Oct 18, 2018, 12:22 AM

@sdetweil

ok, so do I need to add it like this:

parser.on("image", function(image){})
			var title = image.title;
			var image = image.image || image.logo || image.img || image.svg || this.feed_var_in_function.icon || "";
			var url = image.url || image.link || "";

Or, like this:

parser.on("image", function(image){})
			var title = image.title;
			var image = item.image || item.logo || item.img || item.svg || this.feed_var_in_function.icon || "";
			var url = image.url || image.link || "";

cowboysdude · Oct 18, 2018, 1:36 AM

Why are making this so hard?

justjim1220 · Oct 18, 2018, 1:37 AM

@cowboysdude

GOD, I WISH I KNEW!!!

justjim1220 · Oct 18, 2018, 2:00 AM

@sdetweil, @cowboysdude, @Sean

I created a repository, hopefully it will make it easier for you to help.

https://github.com/justjim1220/MMM-NewsFeedTicker

ALL help is MUCH APPRECIATED!!!

I gotta learn this stuff one way or another!

:smiling_face_with_sunglasses:

sdetweil · Oct 18, 2018, 3:20 PM

@justjim1220 I am trying to test my changes, but the module getDom() method is never called…

changed the module name in module.js to match the file name and config module name.

loads with no errors, shows loading the module js and registering the module…

justjim1220 · Oct 18, 2018, 11:38 PM

@sdetweil

What is the possibility of using and array of sorts?

place the logos in a pics folder, call them according to the newsItem[activeItem].title, Ive seen some examples, and tried it a few different ways, but not sure if I am missing something as I can’t get it to work.

recent example tried:
feeds…

            {
                title: "New York Times: ",
                url: "http://www.nytimes.com/services/xml/rss/nyt/HomePage.xml"
            },
            {
                title: "Wall St. Journal: ",
                url: "http://www.wsj.com/xml/rss/3_7085.xml"
            },
            {
                title: "USA Today: ",
                url: "http://rssfeeds.usatoday.com/UsatodaycomNation-TopStories"
            },
            {
                title: "BBC World News: ",
                url: "http://feeds.bbci.co.uk/news/world/rss.xml#"
            }

Array…

iconArray: {
            "USAToday": "USA Today: ",
            "NewYorkTimes": "New York Times: ",
            "WallStJournal": "Wall St. Journal: ",
            "BBCWorldNews": "BBC World News: "
        }

Added this to start function…

 this.logo = {};

sample code…

var logo = this.logo;

            if (this.config.showDescription) {
                var description = document.createElement("div");
                //description.setAttribute("style", "padding-top: 25px");
                description.className = "bright xlarge bold" + (!this.config.wrapDescription ? " no-wrap" : "");
                var txtDesc = this.newsItems[this.activeItem].description;
                description.innerHTML = "<img class = image src=./modules/default/newsfeed/pics/" + logo.icon + ".png height=150px valign=middle>" + "<marquee scrollamount=20 scrolldelay=0 left=500px>" + "<font color=yellow>" + moment(new Date(this.newsItems[this.activeItem].pubdate)).fromNow() + "&nbsp; : &nbsp;" + "</font>" + this.newsItems[this.activeItem].title + "&nbsp; || &nbsp;" + txtDesc + "</marquee>";
                wrapper.appendChild(description);
			}

Any chance this could work easier if I had it coded correctly?

Seems Like I should be declaring the

newsItem[activeItem].title

to equal the icon/logo in some fashion…