Read the statement by Michael Teeuw here.
[Enhancement] Translation system
-
@Wilco89 It looks like you figured it out?
-
It says “finish translation system” but I can’t find any Finish translation.
(sorry ;-) and thanks for the great work) -
@danito lol
-
I’ve updated fr.json file on my computer.
I’m also trying to do it on github, but i’m total noob :p
A little hint please ? I’ve tried to “pull” but not sure i’m doing it right.
Thx -
Michael, I learned that the core translation file is small and already done for a bunch of languages. Should it be expanded in the future, I’d be glad to contribute to the Hungarian translation. I could not figure out in the forum how to get enlisted for such voluntary work, that’s why I write in this post.
Cheers, György -
@lx use github to fork the MM repo, then download your copy using git clone
change/add whatever files need changing
then use git status to see the changed/new filesgit add those files
then use git commit -m " description" to save those files into the local git repo copythen use git push to send them to your fork on github
then on github create a ‘pull request’ (to the dev branch) to tell Mich that you are offering changes
if he approves, he will merge your changes
i expect that you will not understand some of that… google is your friend, search out each step…
-
Sam, thanks for the instruction. You are right, I’m a total newbie here. But your sequence + google is good enough for a start. Cheers, György
-
Hi, I’ve just tried to create a new PR with a new translation for MM. I’ve followed your steps, and everything goes well, but the merge is blocked due to this message:
Enforce Changelog / check (pull_request)
Here is a link to my PR:
https://github.com/MichMich/MagicMirror/pull/2491
I’m a noob on github. What it would be the next step?
Thanks in advance.
-
@qu1que u needed to add the CHANGELOG.md
describing your changeon your same branch on pc edit the file, commit and push it. the existing PR will be updated and retested
-
Yeah, it seems now is working. Thanks!