MMM-MyCommute

leem2000

Hi, I’m new to Pi and MM. I’ve installed few modules and got them working. MMM-MyCommute looks to be a very useful module but can’t get it to work. I installed it following the instructions on its git page. It’s failing to load. I get “Loading…”.

I’m running with unmodified config from the git module page with my apiKey and hideDays set to []. The API key works as I have tested it with another module and also with https://maps.googleapis.com/maps/api/directions/json?origin=Disneyland&destination=Universal+Studios+Hollywood&key=. No errors in pm2 logs either. Peeking into the main .js file, there are log statements. I can’t locate a log file. Not familiar with Node or MM. Would appreciate pointers on what to try and where to look next.

Thanks in advance.

sdetweil

@leem2000 for the MMM-MyCommute.js, open the developers window (ctrl-shift-i on the mirror keyboard), select the console tab… u can filter too, enter comm in the filter field to see messages out from only a module with ‘comm’ in its name

leem2000

Thanks @sdetweil. There are some errors logged to the console.

The module it’s trying to access is
http://localhost:8080/modules/MMM-MyCommute/node_modules/moment-duration-format/lib/moment-duration-format.js.
When I put that into the browser I get
Cannot GET /modules/MMM-MyCommute/node_modules/moment-duration-format/lib/moment-duration-format.js

Then for each destination, I get

Clearly, moment.duration format function is missing. I installed node by following manual install instructions in MM install page.

I have the following in node_modules/moment. This is as installed and not modified.

pi@raspberrypi:~/MagicMirror/node_modules/moment $ pwd
/home/pi/MagicMirror/node_modules/moment
pi@raspberrypi:~/MagicMirror/node_modules/moment $ ls
CHANGELOG.md  ender.js  locale  moment.d.ts  package.js    README.md  ts3.1-typings
dist          LICENSE   min     moment.js    package.json  src

Any ideas on how to fix this?

sdetweil

@leem2000its looking for the moment in the MODULE node_modules folder, NOT the base

did u do the npm install in the module folder?

Enter the MMM-MyCommute directory and execute npm install

leem2000

Thanks, that worked! I haven’t been doing “npm install” for the other modules I installed. Is that recommended after each module install?

sdetweil

@leem2000 if it has a package.json file, yes, and if the instructions say so, yes

gotta follow the instructions

requiemmg

Hi,

I have been installing this module on 2 MagicMirrors.
It’s running 24/7 and I check travelling time to 4 destinations (so, 8 with both mirrors).

Today I got an email, that after about only 2 weeks or so, there are just 25€ remaining of my testing period and 300€.

I do not have any other projects and I’ve checked the Dashboard, there have been more than 45000 queries to the directions API so far.

First thing I did: Limited the module on both mirrors to run only at daytime. But as I have different work locations and shifts, this is not so good. And, of course, I dont want to generate queries for a real amount of cash…

What should I do? Is this normal?

sdetweil

@requiemmg yes, I got a warning too from google, 4 mirrors, asking every 5 minutes, the api query counts add up fast… 8,000 calls a week…

requiemmg

Okay, so no way to limit API calls? Would it be possible to call every 10 minutes or so and only every 60 minutes in the “non-active” time?

sdetweil

@requiemmg if someone changes the code, sure. can do almost anything. I support another mirror app which does provide for a interested time period. (rush hour), and doesn’t call API outside that time period if set

requiemmg

Okay, played around a bit. Set the module to show times only from 5am to 5pm. And I added a “pollFrequency: 15 * 60 * 1000,” to my config.
While the first one works (the module disappears at night), the second one does not seem to work:

This is the Traffic from the last 2 days. You can see the requests are paused last night. I made changes to the poll frequency yesterday in the afternoon, no change.

The module used up nearly all of my €300 starting balance. I wonder if this will go on like this.

API calls in the last 48 hours:

API calls in the last ONE hour:

Which I do not understand: No errors. Poll Frequency of every 15 Minutes. 2 Mirrors with 4 destinations each. So 4*8=24 API calls/hour would be what I expect to see…

sdetweil

@requiemmg 352/hour is 5.87 per minute, about once every 12 seconds… once every 24 seconds both of 2 machines.

1 looked at the code, 1 api request per destination.

requiemmg

Raised an issue. Seems like the problem comes with the use of MMM-Pages, so on every reload of the page, the module is loaded and the requests are sent again, even if the data is still up to date. @qistoph was so nice to make a fork to address this issue.

sdetweil

@requiemmg yep, separate instance on every page.

requiemmg

This makes it clear why I had about 50.000 requests, which made my $400 starting balance void…well, with the new fork and some config modifications, this is much better.

mumblebaj

@requiemmg What I have found is if you run the module in the fixed section of MMM-pages it only does the calls every so often as you set them to i.e. the MMM-Openinghours module I run in fixed as I refresh it every 4hrs.

requiemmg

@mumblebaj Right, but in my design it doesn’t fit in this section. Anyhow, @qistoph made a test fork (https://github.com/qistoph/MMM-MyCommute/tree/issue17) which only makes requests if the data is outdated (=longer than set pollFrequency). See the issue thread (https://github.com/qistoph/MMM-MyCommute/issues/17) for further details

lavolp3

It seems @qistoph 's fork is more up to date than the original repo.

I just pushed a PR to the original repo AND to the @qistoph fork.
It provides an origin option to every destination so you can show commuting back home.
Just set any point as ‘origin’ and your home address as ‘destination’

lavolp3

@lavolp3 nevermind, it is already integrated in @qistoph fork it seems :-)
Just not documented in the readme.

matt216

Hi all.
Wondering if there’s a way to hide the arrival time? Can’t see an option in the config.
Thanks