• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Something I'm working on ...

Scheduled Pinned Locked Moved Announcements
39 Posts 12 Posters 36.8k Views 12 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • L Offline
    LukeCodewalker Module Developer
    last edited by Dec 12, 2016, 5:47 PM

    Hey,
    another problem with tables:

    if you use html-tables in your GitHub README.md it’s not displayed the right way.
    Example: http://beta.magicmirror.builders/module/33/soccerlivescore

    M 1 Reply Last reply Dec 13, 2016, 11:47 AM Reply Quote 0
    • C Offline
      chrisfoerg
      last edited by Dec 12, 2016, 9:58 PM

      It is only an idea. In Wordpress the themes have all the same style at the beginning in the css file for the declaration of the theme:

      /*
      Theme Name: Tutorial
      Theme URI: http://wordpress.lernenhoch2.de
      Description: Template zum WordPress Tutorial auf http://wordpress.lernenhoch2.de
      Author: Christian Strang
      Author URI: http://lernenhoch2.de
      */

      https://codex.wordpress.org/Theme_Development#Theme_Stylesheet

      maybe it is something for you to use?

      1 Reply Last reply Reply Quote 0
      • M Offline
        MichMich Admin @LukeCodewalker
        last edited by Dec 13, 2016, 11:47 AM

        @LukeCodewalker It seems the html is malformed and thus the markdown parser in unable to parse it correctly. It looks like the table contains white lines which are not allowed. If you run your markdown thru a markdown linter, you’ll see there is an issue with the markdown of that readme file.

        C 1 Reply Last reply Dec 13, 2016, 12:38 PM Reply Quote 0
        • C Offline
          Cato Module Developer @MichMich
          last edited by Dec 13, 2016, 12:38 PM

          @MichMich I guess both @LukeCodewalker and me have the same issue. I’ve included my markdown below and as far as I can see there should be no issue with it. The only thing might be the inclusion of
          tags for new line.

          Configuration option | Comment | Default 
          ---|---|---
          url | Video Streaming URL.<br><br>You find it in <i>Motion Eye</i> in the <i>Video Streaming Section</i> under <i>Usefull URLs</i> by by clicking the <i>Streaming URL</i> link.<br><br>It should look something like this: `http://motioneye:8081` (probably an IP instead of hostname) | No default
          autoHide | If you want the camera to only be visible on the mirror when there is motion, set this to true. You will then have to enable "Call a Web Hook" in Motion Eye under the Motion Notifications section: <br><br> - Web Hook URL: <b>[http://URL of your mirror]/motioneye</b>. Example: http://192.168.1.11:8080/motioneye<br> - HTTP Method: <b>GET</b><br><br>Remember to update IP white list to enable access from your Motion Eye box.|false
          autoHideDelay|If autoHide is enabled you can decide how long to wait before hiding the camera|60000 (60 seconds)
          width|Width of camera image. You have to try out what fits YOUR monitor | 400px
          debug|Show messages in the log|false
          
          M 1 Reply Last reply Dec 13, 2016, 12:41 PM Reply Quote 0
          • M Offline
            MichMich Admin @Cato
            last edited by Dec 13, 2016, 12:41 PM

            @Cato That’s correct. You’re mixing html and markdown. Which is not supported within a markdown table. The markdown parser is very strict about this due to security reasons. (We want to prevent code injection via a readme file at all costs.)

            I just use the parser used/developed by/for https://www.npmjs.com, so this is not something I can change.

            1 Reply Last reply Reply Quote 0
            • C Offline
              Cato Module Developer
              last edited by Dec 13, 2016, 12:57 PM

              @MichMich Are you sure about that?

              I thought InLine HTML was perfectly allowed. See:

              • https://daringfireball.net/projects/markdown/syntax#html
              • https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#html
              M 1 Reply Last reply Dec 13, 2016, 12:58 PM Reply Quote 0
              • M Offline
                MichMich Admin @Cato
                last edited by Dec 13, 2016, 12:58 PM

                @Cato Yes, it’s allowed, but not within a markdown table.

                1 Reply Last reply Reply Quote 0
                • C Offline
                  Cato Module Developer
                  last edited by Dec 13, 2016, 3:08 PM

                  Ok, I’ll reformat my documentation when I get time.

                  I found this nice tool: https://dlaa.me/markdownlint/ for checking syntax.

                  1 Reply Last reply Reply Quote 0
                  • P Offline
                    paphko
                    last edited by Dec 25, 2016, 12:16 PM

                    Nice step, a dedicated module database :-)
                    However, via chrome for Android, I am not able to upload an image for my module…

                    1 Reply Last reply Reply Quote 0
                    • R Offline
                      roramirez Core Contributors @MichMich
                      last edited by Dec 26, 2016, 5:55 PM

                      @MichMich From some days I’ve been working in design and little code about mention before.

                      I hope soon release something can be stable. At today is state alfa state and not working.

                      I send the URL of project if someone is interested
                      https://github.com/roramirez/MagicMirror-Module-Manager

                      Easy module development with MagicMirror Module Template

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 2 / 4
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy