Read the statement by Michael Teeuw here.
MMM-ProfileSwitcher, A Profile/User/Layout Switching Module
-
@Mar After a helpfull pull request by @Jopyth this line got removed. Try pulling the new changes and let me know if still gives problems! Thank you for letting me know that bug.
@All The module uses lockstrings now! This due to some problems in combination with other modules. Give the README configurables a look if you want to disable this.
Edit: Ugh I just noticed I made a terrible mistake in that line. the
=>
should have been>==
. Thanks again!
Edit 2: Double ugh, read it again and it was right. -
@tosti007 Thanks for the updates, still looks like lines 214 & 218 contain the “=>” were these supposed to be switched to >== also?
So just getting those error so far, but still no luck on the switcher. Im really not sure what I’m doing wrong. I’ve simplified my config file to the following to try make it load the default profile and just switch to ‘PAGE2’. But when the MM loads I get both the clock and weather still on the screen.
modules: [ { module: 'alert', }, { module: "updatenotification", position: "top_bar" }, { module: 'MMM-ProfileSwitcher', config: { // See 'Configuration options' for more information. } }, { module: 'MMM-Buttons', config: { buttons: [ { pin: 5, name: "power", shortPress: { notification: "PROFILE_SWITCH", payload: {action: "PAGE2"} } } ] } }, { module: 'clock', classes: 'default', position: 'top_left', }, { module: 'currentweather', classes: 'PAGE2', position: 'top_right', config: { location: '...', locationID: '...', appid: '...' } }, ]
and when i press the button pm2 logs only shows this but nothing happens on the screen.
0|mm | ** Message: console message: [native code] @0: clock received a module notification: PROFILE_SWITCH from sender: MMM-Buttons
edit: On the main HDMI cable monitor the mirror is showing both modules, but if i go via chrome on my laptop it only shows the clock (but still doesnt switch when pressing the button). The inspector in Chrome shows that its hiding non-default modules…seems like Midori doesnt get to this (but I have no way to check)
-
@Mar
=>
are big arrow functions from ecmascript6, which is the newest standard of javascript -
@strawberry-3.141 Thanks, I never seem to have had any issues with these before but only on my pi zero. Loading up the latest profile switcher (using my simple 2 module) i get this error relating to that line
0|mm | ** Message: console message: http://localhost:8080/modules/MMM-ProfileSwitcher//MMM-ProfileSwitcher.js @214: SyntaxError: Unexpected token '>'
But it seems to work via a remote browser (i.e chrome but switching doesnt work) and not the pi’s midori which still shows both modules.
-
@Mar for me electron is supporting all those es6 features, just heard of that some users had problems with some of my modules with the midori browser
-
@strawberry-3.141 Yeah seems to be a midori thing, unfortunately I’m using a pi zero so need to use midori as it runs pretty amazing with the pi. Electron really slows it down.
Wondering if there is a way around this at all? Maybe breaking out the arrow functions to normal one might work?
-
So ive broken out those functions to the following and now get no errors:
*OLD* value = value.map((x) => { return x === true ? translated : x; }); *NEW* value = value.map( function(x){ return x === true ? translated :x; } ); *OLD* classes.split(" ").forEach((key) => { if (result[key] === undefined) { result[key] = []; } result[key] = result[key].concat(value); }); *NEW* classes.split(" ").forEach( function(key) { if (result[key] === undefined) { result[key] = []; } result[key] = result[key].concat(value); } );
Now the only error i am getting is on line 89
TypeError: undefined is not a function (evaluating 'classes.includes(self.current_profile)')
But im not sure how to fix this one. And this is the function that decides what to show which could be where Midori cannot parse it properly.
-
@Mar that is also an es6 feature try
classes.indexOf(self.current_profile) !== -1
-
@strawberry-3.141 Thanks, I couldnt figure that one out.
return classes.indexOf(self.current_profile) !== -1;
Along with the changes in the previous post I’ve have fully loaded ProfileSwitcher Midori without any errors. It also is showing the correct modules on load (classes = default).
Thanks for the help through this @strawberry-3-141
Managed to figure this all out so thanks to everyone!
-
@strawberry-3-141 thank you for helping @Mar
@All @Mar I didn’t know that that browser doesn’t support those features. I will rewite those parts so then it should work out of the box.