MMM-NewsAPI

[bugsounet]

@mumblebaj if you want MMM-News, just tell me, I offer it!
I can transfert it to your git hub account ;)

[mumblebaj]

@bugsounet Thanks bugsounet. I would never be able to maintain your very awesome module. The added functionality that you offer in yours is amazing and I would probably just end up messing up you great work. :pensive_face:

[cowboysdude]

@mumblebaj well it’s how you learn! Just keep a backup of the original and you’ll never go wrong!

[mumblebaj]

@cowboysdude Thanks dude. :ok_hand:

[bugsounet]

@cowboysdude that why I want to offer it. Because I will delete it soon

After if want want it, no problem I can transfert

[mumblebaj]

@bugsounet Thanks Bugs. You can transfer. I will dig through the code and try to make sense of all your awesome work. I am humbled. :person_bowing:

[bugsounet]

@mumblebaj I have transert it to your github account.
Just accept it ;)

[mumblebaj]

@bugsounet I can’t seem to find it nor can I see any notifications for it to accept.

[swvalenti]

@mumblebaj @bugsounet MMM-News still works for me when you say you will delete it does that mean it will stop working? If so NBD I will use my man @mumblebaj module

[mumblebaj]

@swvalenti The module will not stop working.

[swvalenti]

@mumblebaj Whatever you do don’t update the module, mmm remote control showed update I just did that and it deprecated the module and no longer works!

[mumblebaj]

@swvalenti You can clone the module from here:
MMM-News
The config should still work.

[swvalenti]

@mumblebaj gave yours a try but get this error?

MMM-NewsAPI.js:129 Uncaught TypeError: Cannot read property 'sourceId' of undefined
    at Class.draw (MMM-NewsAPI.js:129)
    at Class.socketNotificationReceived (MMM-NewsAPI.js:96)
    at module.js:245
    at Socket.<anonymous> (socketclient.js:38)
    at Socket../node_modules/component-emitter/index.js.Emitter.emit (index.js:145)
    at Socket.emit (typed-events.js:46)
    at Socket.emitEvent (socket.js:263)
    at Socket.onevent (socket.js:250)
    at Socket.MMSocket.socket.onevent (socketclient.js:32)
    at Socket.onpacket (socket.js:214)

Config

                module: "MMM-NewsAPI",
                header: "news",
                position: "bottom_bar",
                config: {
                        apiKey: "super duper secret",
                        type: "horizontal",
                        choice: "headlines",
                        pageSize: 9,
                        className: "NEWS",
                        drawInterval: 1000*30,
                        templateFile: "template.html",
                        fetchInterval: 1000*60*60,
                        query: {
                                country: "us",
                                //category: "",
                                //q: "covid",
                                //qInTitle: "",
                                sources: "Fox News",
                                domains: "foxnews.com",
                                //excludeDomains: "",
                                language: "en"
                        },
                }
},

[mumblebaj]

@swvalenti said in MMM-NewsAPI:
The issue is with sources “Fox News”. That is not a valid source. Remove it and it should work fine with just the domain of foxnews.com

[swvalenti]

@mumblebaj said in MMM-NewsAPI:

@swvalenti said in MMM-NewsAPI:
The issue is with sources “Fox News”. That is not a valid source. Remove it and it should work fine with just the domain of foxnews.com

Understood, works great now. Nice module good job!!!

[bugsounet]

@mumblebaj, perfect, that i see Transfert is now done ;)

Happy coding,
@bugsounet

[mumblebaj]

@bugsounet Thank you. I have received.

[swvalenti]

@mumblebaj Module stopped working you working on it?

[swvalenti]

No errors just doesn’t show in region

[mumblebaj]

@swvalenti I will have a look shortly. It is running just fine on my mirror. Will start another instance and see