MMM-NewsAPI

mumblebaj

@swvalenti The module will not stop working.

swvalenti

@mumblebaj Whatever you do don’t update the module, mmm remote control showed update I just did that and it deprecated the module and no longer works!

mumblebaj

@swvalenti You can clone the module from here:
MMM-News
The config should still work.

swvalenti

@mumblebaj gave yours a try but get this error?

MMM-NewsAPI.js:129 Uncaught TypeError: Cannot read property 'sourceId' of undefined
    at Class.draw (MMM-NewsAPI.js:129)
    at Class.socketNotificationReceived (MMM-NewsAPI.js:96)
    at module.js:245
    at Socket.<anonymous> (socketclient.js:38)
    at Socket../node_modules/component-emitter/index.js.Emitter.emit (index.js:145)
    at Socket.emit (typed-events.js:46)
    at Socket.emitEvent (socket.js:263)
    at Socket.onevent (socket.js:250)
    at Socket.MMSocket.socket.onevent (socketclient.js:32)
    at Socket.onpacket (socket.js:214)

Config

                module: "MMM-NewsAPI",
                header: "news",
                position: "bottom_bar",
                config: {
                        apiKey: "super duper secret",
                        type: "horizontal",
                        choice: "headlines",
                        pageSize: 9,
                        className: "NEWS",
                        drawInterval: 1000*30,
                        templateFile: "template.html",
                        fetchInterval: 1000*60*60,
                        query: {
                                country: "us",
                                //category: "",
                                //q: "covid",
                                //qInTitle: "",
                                sources: "Fox News",
                                domains: "foxnews.com",
                                //excludeDomains: "",
                                language: "en"
                        },
                }
},

mumblebaj

@swvalenti said in MMM-NewsAPI:
The issue is with sources “Fox News”. That is not a valid source. Remove it and it should work fine with just the domain of foxnews.com

swvalenti

@mumblebaj said in MMM-NewsAPI:

@swvalenti said in MMM-NewsAPI:
The issue is with sources “Fox News”. That is not a valid source. Remove it and it should work fine with just the domain of foxnews.com

Understood, works great now. Nice module good job!!!

bugsounet

@mumblebaj, perfect, that i see Transfert is now done ;)

Happy coding,
@bugsounet

mumblebaj

@bugsounet Thank you. I have received.

swvalenti

@mumblebaj Module stopped working you working on it?

swvalenti

No errors just doesn’t show in region

mumblebaj

@swvalenti I will have a look shortly. It is running just fine on my mirror. Will start another instance and see

swvalenti

sorry I meant to say MMM-News but also NewsAPI just shows gray line and News heading and nothing else

mumblebaj

@swvalenti MMM-News can be cloned from the following repo:

MMM-News

I have made a change to MMM-NewsAPI which resolves CSS conflicts and it should now work when running MMM-News at the same time.

swvalenti

@mumblebaj sent you a pm chat

sdetweil

@swvalenti if u look in the developers window, console tab, are there any errors?

is the module listed in the sources list, and is the content in the elements tab, but maybe marked display:none?

swvalenti

@sdetweil I got it all squared away thanks Sam!

mwm341

Will MMM-NewsAPI allow displaying full articles in an iFrame?

mwm341

@mwm341 said in MMM-NewsAPI:

Will MMM-NewsAPI allow displaying full articles in an iFrame?

Maybe an answer:
Gonna try splicing template.html into a responsive iFrame.

Wish me luck!

mumblebaj

@mwm341 It is not setup for that at the moment but, you are more than welcome to make a PR. :winking_face:

mumblebaj

The following updates have been made to the module. Please feel free to do a git pull and then an npm install in the module directory.

Removed the request module and replaced with node-fetch due to request being deprecated.
Update to the config.js. You have to remove the following line from you config.js.

className: "News"

The CSS has been changed to avoid conflicts with other modules. Hence the above className is no longer required and must be removed from the config.js.