After update 2.23.0 crash

sdetweil

@JoeFranz on what module?

JoeFranz

@sdetweil MMM-PIR-Sensor

Wenike

@sdetweil By chance, do you know of a command I can run to kill any running Node processes? I’m trying to run your upgrade script and its unable to upgrade Node because a process is already running. Googling gives me code to use within an application but that doesn’t seem like it’ll work from the CLI.

doing test run = false
update log will be in /home/pi/MagicMirror/installers/upgrade.log
Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v16.13.1
Installed Node version: v10.24.1
Node should be upgraded.
A Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
running process(s) are
pi 881 879 0 09:05 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js

mumblebaj

@JerryP Always use Sam’s update script. I used it last night and updated from 2.21.0 to 2.23.0 no issues. Often modules with a package.json requires an npm install in that folder and the upgrade script takes care of all of that.

sdetweil

@Wenike do this

from a terminal window

ps -ef | grep node

this will show you the node processes running and parms to what they are running (file path)

if all looks understandable and u can’t terminate them thru app shutdown (pm2 stop all will stop all.managed apps, mm included), do

ps -ef | grep node | awk '{ print $2 }' | xargs kill -9

this will hard kill all the node processes

sdetweil

@JoeFranz

the script does a new npm install in modules that have a package.json

but I know the post install process is wrong for this module

my fork fixes that
https://github.com/sdetweil/MMM-PIR-Sensor

Wenike

@sdetweil Perfect, fixed it. Thanks!

sdetweil

@JerryP said in After update 2.23.0 crash:

sudo git pull

just one more thing

NEVER use sudo with MM no need for it.
all it does is lead to trouble

hrjmsh

@sdetweil Thank you very much. Had the same error (cannot find module envsub) on updating the MagicMirror to the new version and this step (rm -rf node_modules and then npm install again) solved the issue for me.

sdetweil

@hrjmsh you should use my upgrade script