Read the statement by Michael Teeuw here.
MMM-doomsDay - The countdown module,
-
i just checked before running off to work. Yesterday, I set a an event for today so that I could see the end result but the module still displays “1 Day Left” as it does in the picture above. The only thing I changed in the sample config was the date of the event and what it should say when the event arrived. I left the time untouched as you suggested. I have a short work day today so I’ll take a look at it when I get home
-
@Mykle1 humm, okey, probably because the function to round it up thinks it’s more than 0.5 days left and thus rounds it up to 1 instead of down to zero.
Have to adjust the code a bit
-
@Mykle1 My advent module? Even though @broberg hasn’t mentioned it, it seems he based his work on that module.
A feature suggestion from my side: It would feel more like an urgent thing closing in, if it could also show hours/minutes/seconds, too. Maybe use a formatting string for a
moment.js
duration? If I have some time, I might make a PR. -
@Mykle1 Okey, I changed up some variables and I’m not able to test them myself, when you get home, could do a
git pull
on the doomsday module and test it out for me? -
@Jopyth Yes, I stripped out that module for this one, kept the start function and removed the rest since It was a bit over my head at the moment :)
Took me a lot longer than I’m willing to admit just to get the code to compare dates!
Actually thought about the hour/minute countdown as well, but decided to keep it real basic.
I figured you don’t really put that many hours in front of the mirror that it would be that important to see so much detail of the countdown. (And if you look the update interval is set to 5 hours just to keep it in the ballpark) -
@Jopyth said in MMM-doomsDay - The countdown module,:
My advent module?
Yes, that was it. :thumbsup_tone1:
-
@broberg said in MMM-doomsDay - The countdown module,:
when you get home, could do a git update on the doomsday module and test it out for me?
This is what I get when I attempted a git update as you suggested.
pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $ git update
git: ‘update’ is not a git command. See ‘git --help’.Did you mean this?
update-ref
pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $I don’t want to mess anything up so I’ll wait till you advise further, thanks
-
@Mykle1 git pull
-
@Mykle1 sorry my bad mixing up stuff,
git pull
is the command to use in the Mmm-doomsday folder -
A second to slow,@strawberry-3-141 beat me to it :)