MMM-Remote-Control

sdetweil

@rkorell I was just about to add that you needed to redo the npm install for the module after deleting the node_modules folder
else you were trying to run the new dependencies with the old code

but you fixed it…

rkorell

@sdetweil
Yes :-)

In fact I’ve used

npm ci --omit=dev

this does the deletion of the node_modules folder inherently AFAIK …

Thanks again, dear Sam!

Ralf

sdetweil

@rkorell said in MMM-Remote-Control:

npm ci

be careful… the package.json was built and tested on a cloud based virtual machine.
pi and other hardware types MAY need a different version of a dependency, i’ve only seen it myself twice in 6 years, but

npm ci uses the exact package.json
npm install will get the appropriate for this platform, even if the version changes.

anyhow… I use npm install --omit=dev when I do the installs script or MMM-Config

rkorell

@sdetweil
OK; thanks for this hint.
May npm install has avoided the resulting error which I had to solve…

Anyway: Thanks a LOT!
Regards,
Ralf

KristjanESPERANTO

Thanks for the feedback!

Since Sam has already addressed some of the issues, I won’t go into them again.

A few problems were mentioned, some of which I have just addressed with v4.1.0. E.g.:

Restart/Shutdown: Should now also work on systems without PM2.
Minimize: Now says “restart to restore” so you know how to undo it.

About the monitor control issue:

This would be tricky to get running by default everywhere because every system uses different commands (X11/Wayland/etc). You have to check the Monitor Control docs and configure the right commands for your specific setup - the defaults won’t work everywhere.

About the “npm install/npm ci” topic:

Yes, npm ci can be problematic for modules with native dependencies that need platform-specific builds. However, MMM-Remote-Control only uses pure JavaScript dependencies (marked, qrcode, simple-git, swagger-ui-dist, uuid) - no native modules that require compilation.

For this module, npm ci is actually the better choice because:

Guarantees exact tested versions which the developers released
Faster installation (no dependency resolution)
Same behavior in CI and production

So the warning about npm ci is valid in general, but doesn’t apply here.

About the microupdates. Since the test suite does not a lot parts yet, some details simply go unnoticed after major changes. If you are not experiencing any problems with the module, you do not need to install every update.

About node update: I recommend using nvm for node updates. This is also what is offered as default for Linux on the official download page. This makes many things easier - like if something does not work after an update, you can easily switch back to the previous node version. So you don’t need to be so afraid of updates.

KristjanESPERANTO

@S374n said in MMM-Remote-Control:

First update changes my main.css - took me a while to figure it out and redo all my customizations.

You should not change main.css. All customizations should be made in custom.css: https://docs.magicmirror.builders/modules/customcss.html#custom-css

sdetweil

@KristjanESPERANTO n also allows you to change version on the fly.