Too many API calls in default weather module after update

[sdetweil]

@Perilax @kristjanesperanto will have to answer, there was a big rewrite of the data collector side of weather.

[stephanvdplas]

@Perilax

I think you need these parameters:

			updateInterval: 60 * 60 * 1000,
			retryDelay: 60 * 60 * 1000,          // retry only once per hour

[Perilax]

@stephanvdplas

Is „retryDelay“ really working ? I can‘t find it in the documentation.

I have two modules where I request the API every 10 minutes. So it should be around 300 requests per day.
By far less than 1000.

[KristjanESPERANTO]

Sam is right, that was caused by the big rewrite (which resolved other issues, particularly a fundamental architectural one).

A fix is already in the develop branch: https://github.com/MagicMirrorOrg/MagicMirror/pull/4092

Are you familiar enough with Git to test the develop branch?

[evroom]

@perilax
Or just a quick work-around as the default for updateInterval for openweathermap is 10 minutes anyway.
Try to comment out those 2 lines with //.

@kristjanesperanto
Quick response; quick fix 👍

[Perilax]

@KristjanESPERANTO

I’ll test the develop branch tomorrow.
Thanks for the quick reply.

@evroom I added updateInterval to my config.js only after the problem occurred, because I thought it might be causing the issue.

[sdetweil]

@Perilax see this link for how to get the develop branch
https://forum.magicmirror.builders/post/86422

[Perilax]

@KristjanESPERANTO

The develop branch is working. API requests are back to normal.

Can I make this change manually on the master branch for now, or do I need to let the develop branch run until the next update ?

Thanks again for the quick help.
Also to @sdetweil

[sdetweil]

@Perilax i would let the develop branch run. We are discussing a point release to pick up a few fixes.

If you use my upgrade script when next version is ready, it will switch you back to master

[Perilax]

@sdetweil

I can´t use your update script, because I installed my MM with the proxmox helper script.