MMM-MyCommute

[rudibarani]

Hi @j.e.f.f,
is there a way to localize the output of MMM-MyCommute? I noticed that MMM-MyWeather uses a translate folder that contains a file for each supported language. Maybe something similar would be possible here, too. I am happy to provide German translations if you like.
Related to that would be adhering to the timeformat set in a users config.js. Currently, the module seems to only support the 12 hour am/pm-format. Having a 24h format as in my other modules would be great.
Thanks for caring to think about this!

[j.e.f.f]

@rudibarani This module doesn’t print out many literal strings, except for error messages in the console, and the two words “Error” (easily localized) and “min.” (e.g. 33 min). Everyting else is either configured text or data from the API response. Are you looking to translate the route summary? eg: The grey text below the title in the image below:

If so, this is provided by Google in the response from the directions API. It is supposed to localize automatically based on where it determines your location to be, but I’m not sure if that’s just for returning otherwise ambiguous directions or if it’s supposed to give you the route in the localized language. That said, it request accepts an explicit region parameter. I could expose that and you could set it to see if that addresses this.

As for the time format, the module is not presenting any time in 12 hour AM/PM format. It is calculating the total number of minutes to get to the destination and presenting it in a built string – calculatedTimeInMinutes + " min". This will ALWAYS be a sum of minutes (e.g.: 90 min, not 1 hr 30 min – this is to save space). I could expose a string format parameter that has a placeholder for the number of minutes, so you could specify something like timePredictionFormat: "%MINUTES% m" (module would replace %MINUTES% with calculatedTimeInMinutes, and would render as 33 m, for example). Would this work for what you’re trying to do?

[rudibarani]

@j.e.f.f Thanks for the clarifications. Both of my questions seem to relate to grey text you referred to. In my case, it shows an english route summary including the departure times in the 12 hour format:

Having this string in German with 24h time format would be great. Maybe the region parameter could be a solution.

[j.e.f.f]

@rudibarani Ah I forgot about that part! Yeah that should be doable… The time in 12 hour format is provided by Google as-is, but I should be able to convert it. I can make this entire string a time format string. That way it can be translated in whatever context and order you need.

something like nextTransitVehicleSummaryFormat: "[next at] HH:mm".

That way you could translate it any way you like or change it any way you like.

[rudibarani]

@j.e.f.f Great idea!!! Thanks for trying :)

[j.e.f.f]

@rudibarani Ok give it a shot now. I add a config option called nextTransitVehicleDepartureFormat.

Here’s an example:

    {
      module: 'MMM-MyCommute',
      position: 'top_left',
      classes: 'default everyone', 
      header: 'Commute',
      config: {
        apikey: 'SECRET',
        origin: 'SECRET',
        ...
        nextTransitVehicleDepartureFormat: "[Next:] HH:mm",
        destinations: [
          ...
        ]
      }
    },

[rudibarani]

@j.e.f.f said in MMM-MyCommute:

nextTransitVehicleDepartureFormat: “[Next:] HH:mm”,

It works like a charme. Thanks a lot!!

[BanksyPaint]

@j.e.f.f Hi there! I know the original post you replied to is a little dated, though I’m experiencing this as well. I’ve taken the config you have posted here:
https://github.com/jclarke0000/MMM-MyCommute
With the changes you also suggested for the header and text, and inserted my API key, and I’m seeing nothing appear. I’ve taken the OP’s suggestion, rm’ing the folder, re-cloning and re-installing, though it isn’t working for me. Any ideas on what it could be?

Here’s the output from MM, and it looks normal? I tried another user’s suggestion of rebooting the pi, and sadly that didn’t work for me :(

Initializing new module helper ...
Module helper loaded: MMM-MyCommute
All module helpers loaded.
Starting server on port 8080 ... 
Server started ...
Connecting socket for: updatenotification
Connecting socket for: MMM-MyCommute
====================== Starting node_helper for module [MMM-MyCommute]
Sockets connected & modules started ...
Launching application.

[strawberry 3.141]

@BanksyPaint can you check your electron logs by starting the mirror with npm start dev

[j.e.f.f]

@BanksyPaint hey are you seeing nothing appear or is it stuck on “Loading”? The module is designed to hide itself if it is outside the time frame window you set in the config, in which case you’ll see nothing at all. If there’s a problem during initialization, then it will be stuck on “Loading”.

Otherwise, can you send me your config? I’ll give it try on my side.