[MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras

shbatm

@barnosch said in [MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras:

Also your new VLC based module sounds great.
But i guess, you maybe should create a whole new module for it?

The plan right now was to just leave it as another option for the localPlayer. OMXPlayer will still be an option for now as well. I don’t know if I’ll have time to split it out completely, but that would be much cleaner.

shbatm

@cr4z33

You’ll want the following settings which should give you 1 blank video box that does not show anything until you press play.

autoStart: false,
rotateStreams: true,
rotateStreamTimeout: 0,
localPlayer: 'omxplayer',
remotePlayer: 'none',
showSnapWhenPaused: false,
remoteSnaps: false,

I’m assuming you’re seeing the same glitch that is plaguing the last OMXPlayer version of this module. I’m working on it today to try and find what I broke. In the meantime, try reverting back and seeing if that fixes the issue. I just tested the following notification on the VLC version and it worked as expected, so it’s got to be something with omxplayer.

{
notification: "RTSP-PLAY",
payload: "stream3"
}

Cr4z33

@shbatm although I am not a developer I agree with you.
Whenever I tried something different from normal module usage involving omxplayer it always ended up with a mess lol! :grinning_face_with_smiling_eyes:

Going to try what you are suggesting here.

Can’t wait to see the VLC implementation (it just works as intended). :smiling_face_with_heart-eyes:

Cr4z33

@shbatm nope the simultaneous streams have now dropped from 7 to 2, but still not what I want (aka a single stream). :smiling_face_with_open_mouth_cold_sweat:

Gonna try the develop branch and see how it is doing right now.

shbatm

@cr4z33 Still looking into it, but I just thought of something… it doesn’t look like you’re calling RTSP-STOP on the old stream anywhere when changing channels so right now it’s going to keep starting streams every time–there’s no “1 at a time” method when controlling it from notifications… yet.

Cr4z33

This post is deleted!

shbatm

@djuscha I’ve reverted the changes that I think broke the master channel. Please try updating your module to the current master branch and test.

shbatm

@cr4z33 ~~Added something that might help. Please use the develop branch and update your change channel commands to :~~

{
~~notification: “RTSP-PLAY”,~~
~~payload: { stream:“stream1”, stopOthers: true }~~
}

EDIT: Nevermind, don’t do that. I fixed the glitch on the develop channel that was starting more than one stream when rotateStreams: true was set. Please try that and see if it works now.

anthony6608

@shbatm Hey, I updated issue #33 with the errors I am seeing when you have a chance. Also, should I run this update although I am using the VLCplayer method? Let me know what you think. Thanks again for all your help!

BKeyport

I’m unable to get this module to load and run with FFMPeg anymore - as of 3PM 1/4/19 (Pacific Time (Seattle))

Update was applied as of that time.

I don’t know how to retrieve logs.

– Bug filed on github - https://github.com/shbatm/MMM-RTSPStream/issues/34

shbatm

@djuscha, @Cr4z33 @barnosch @anthony6608 @bhepler @evroom, and anyone else using this module:

I just pushed a bunch of bug fixes for OMX Player to the develop branch. Please test and let me know if you are still seeing the same issues.

Fixes include:

App closing now spawns a new process to actually kill the OMX streams, it was getting cut off in the middle of closing everything due to it being an async process and leaving streams open.
Wait for DOM to be shown before calling to start the streams–this was causing the Fullscreen on Resume problems.
Only start one stream at a time if we’re in RotateStreams mode
Can jump to a specific stream in RotateStreams mode using notifications
Fixed and cleaned up all notifications and control from other modules
Fixed broken key bindings after MMM-KeyBindings upgrade
Fixed issue where module was trying to connect to PM2 while it was already connected (e.g. stop stream 1 and start stream 2 back to back).

To switch branches:

cd ~/MagicMirror/modules/MMM-RTSPStream
sudo rm -R node_modules/
git fetch --al
git checkout develop
git pull
npm install

evroom

@shbatm
I installed the new changes according your procedure.
I am using omxplayer for a RTSP stream of a IP cam.
I do not use rotation or any other fancy stuff.
I see the same issue as before: omx_stream1 has status stopped and when I click on the play button it also will not start.
I stopped and started mm 2 times and even did a complete reboot
It only can be started using

$ pm2 start omx_stream1

Another restart of mm shows that the omx_stream1 is being stopped, but never restarted.
After ever mm restart I will need to perform:

$ pm2 start omx_stream1

evroom

I noticed this in pm2 logs (do not see this after every mm restart):

0|mm  | Connecting socket for: MMM-RTSPStream
0|mm  | PM2: Stopping all OMXPlayer Streams...
0|mm  | Sockets connected & modules started ...
0|mm  | Launching application.
0|mm  | PM2: Checking if omx_stream1 is running...
0|mm  | PM2: Stopping omx_stream1...
PM2      | Stopping app:omx_stream1 id:1
1|omx_stream1  | Video codec omx-h264 width 640 height 360 profile 77 fps 30.000000
1|omx_stream1  | Subtitle count: 0, state: off, index: 1, delay: 0
1|omx_stream1  | V:PortSettingsChanged: 640x360@30.00 interlace:0 deinterlace:0 anaglyph:0 par:1.00 display:0 layer:0 alpha:255 aspectMode:0
1|omx_stream1  | have a nice day ;)
PM2            | App [omx_stream1:1] exited with code [1] via signal [SIGINT]
PM2            | pid=2104 msg=process killed

In this case it was tried to start the stream, but it exited.
Starting it by hand makes it work again.

Cr4z33

@shbatm I ran the develop update.

With omxplayer (and autoStart: false) I see stream labels changing when giving a voice command, but then no stream is starting.

With vlc nothing happens, not a single stream starting by voice command.

djuscha

@shbatm

have made yesterday update without develoop only

git pull
npm install

everything runs :)

 Name        │ id │ mode │ status │ ↺      │ cpu │ memory │
├─────────────┼────┼──────┼────────┼────────┼─────┼────────┼──────────┤
│ mm          │ 0  │ N/A  │ fork   │ online │ 0   │ 0%     │ 2.5 MB   │
│ omx_stream1 │ 1  │ N/A  │ fork   │ online │ 17  │ 0%     │ 2.8 MB   │
│ omx_stream2 │ 2  │ N/A  │ fork   │ online │ 6   │ 0%     │ 2.8 MB

Many Thanks .

shbatm

@evroom said in [MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras:

after every mm restart

There was a problem with the steams not stopping on a restart, so the module sends a stop command first whenever it starts, do you have autoStart: true in your config?

shbatm

@cr4z33 said in [MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras:

With omxplayer (and autoStart: false) I see stream labels changing when giving a voice command, but then no stream is starting.

OK. I’ll check this later today, the notification RTSP-PLAY should switch and start the stream so that’s an issue.

shbatm

@Cr4z33 ~~try inserting this.playing = true; at Line 574 as the first line in the if statement and see if that works. I’ll test later today.~~

EDIT: Just pushed an update. Please try the latest release in develop

evroom

@shbatm said in [MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras:

There was a problem with the steams not stopping on a restart, so the module sends a stop command first whenever it starts, do you have autoStart: true in your config?

Yes, I have.

Just to understand, when you start fresh, there is no omx_stream1 under pm2 list.
When you start your first stream, it is first visible under pm2 list, right?

Till now I was able to start the stream with pm2 start, but after removing the stream (pm2 remove omx_stream1), I cannot get it to work anymore.
MM restart, reboot, nothing helps.
And pm2 start now says:

pi@MagicPi:~ $ pm2 start omx_stream1
[PM2][ERROR] script not found : /home/pi/omx_stream1
script not found : /home/pi/omx_stream1
┌──────────┬────┬─────────┬──────┬─────┬────────┬─────────┬────────┬─────┬──────────┬──────┬──────────┐
│ App name │ id │ version │ mode │ pid │ status │ restart │ uptime │ cpu │ mem      │ user │ watching │
├──────────┼────┼─────────┼──────┼─────┼────────┼─────────┼────────┼─────┼──────────┼──────┼──────────┤
│ mm       │ 0  │ 2.5.0   │ fork │ 811 │ online │ 0       │ 4m     │ 0%  │ 2.5 MB   │ pi   │ disabled │
└──────────┴────┴─────────┴──────┴─────┴────────┴─────────┴────────┴─────┴──────────┴──────┴──────────┘

Which makes sort of sense.

After MM restart, pm2 logs shows:

0|mm  | Connecting socket for: MMM-RTSPStream
0|mm  | PM2: Stopping all OMXPlayer Streams...
0|mm  | Sockets connected & modules started ...
0|mm  | Launching application.

Will revert back to the master branch and try again.

shbatm

@evroom said in [MMM-RTSPStream] - Video Streaming from Live Feeds & Security Cameras:

Will revert back to the master branch and try again.

Yes, the omx_stream1 is created the first time you play a stream with the module.

Please use the develop branch with omxplayer. It was working on my machine the last time I started.