Input...What do you think?

cowboysdude

Thanks to Mykle we’ve changed the api call and NOW it should cover just about the entire world … well if you have a pws close by you :)

Thanks to @Snille and @Mykle1 for their help… like I said didn’t plan on releasing this and honestly only asking for what others thought of it but hey looks like once the bugs are all ironed out it’ll be coming to a mirror near you…

barnosch

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.

show: "F".toLowerCase(), // show F or C Temps

Mykle1

@barnosch said in Input...What do you think?:

Guess your are still in the middle of development.

You don’t have to guess. All you have to do is actually read what he wrote in the post above yours. :-)

cowboysdude

cowboysdude

@barnosch said in Input...What do you think?:

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.
show: "F".toLowerCase(), // show F or C Temps

In your config.js file at the top…

    ```timeFormat: 12,  // change that to a 24 ;) ```

cowboysdude

Hot off the presses … Swedish translation :) Thanks again @Snille

[If anyone would be kind enough to do the German translation I’d appreciate it!! PM me!]

cowboysdude

@barnosch said in Input...What do you think?:

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.
show: "F".toLowerCase(), // show F or C Temps

Done… in the config file it’s
format: "12" or "24"

testing

barnosch

Thanks. I already fixed it at my mirror with
(config was already in 24hours mode)
changeing this line

//  time = time.toLocaleString('en-US', { hour: 'numeric',minute:'numeric', hour12: true });
       time = time.toLocaleString('de-DE', { hour: 'numeric',minute:'numeric', hour24: true });

which did the job

And for the sunset and sunrise i just changed to

H:mm

Ugly and hardcoded but worked for me. with my low programming skills.

How is the correct way to update the repository via git? I’m kind of new to this stuff.

Snille

@cowboysdude Ah, Thank you! Looking good. I’ll pull when I have some time. :)

cowboysdude

@barnosch said in Input...What do you think?:

Thanks. I already fixed it at my mirror with
(config was already in 24hours mode)
changeing this line
//  time = time.toLocaleString('en-US', { hour: 'numeric',minute:'numeric', hour12: true });
       time = time.toLocaleString('de-DE', { hour: 'numeric',minute:'numeric', hour24: true });
which did the job

And for the sunset and sunrise i just changed to
H:mm
Ugly and hardcoded but worked for me. with my low programming skills.

How is the correct way to update the repository via git? I’m kind of new to this stuff.

No you did great but I will put in a fix for it and you can do a git pull later :)

Ok the fix is in… the time will automatically read your language in the config.js file and adjust itself accordingly… However you will want to keep your sunrise/sunset ‘fix’ for now because I did not change that. :)

planet4

This post is deleted!

planet4

@cowboysdude Looking forward to this but it should be prognos and not prognås right? In the swedish translation.

Snille

@planet4 “Prognås” is my bad… :) Sorry… You are correct. I thought it looked strange. :)

cowboysdude

@barnosch said in Input...What do you think?:

Thanks. I already fixed it at my mirror with
(config was already in 24hours mode)
changeing this line
//  time = time.toLocaleString('en-US', { hour: 'numeric',minute:'numeric', hour12: true });
       time = time.toLocaleString('de-DE', { hour: 'numeric',minute:'numeric', hour24: true });
which did the job

And for the sunset and sunrise i just changed to
H:mm
Ugly and hardcoded but worked for me. with my low programming skills.

How is the correct way to update the repository via git? I’m kind of new to this stuff.

Ok so it’s all updated.

As I said above the time zone will adjust automatically and to show the AM/PM on the Sunrise/Sunset time is now a config option [See Readme on Github].

To update go to:

~MagicMirror/modules/MMM-NOAA
type: git pull

That should update for you ;)

Snille

@cowboysdude Hmm… I’m thinking maybe you are working double here… There should be a “global” locale variable you can use. That’s set in the top of the config file. You should be able to use that one some how. I just don’t know how. :)

cowboysdude

@Snille said in Input...What do you think?:

@cowboysdude Hmm… I’m thinking maybe you are working double here… There should be a “global” locale variable you can use. That’s set in the top of the config file. You should be able to use that one some how. I just don’t know how. :)

Not sure either :) So what I did was to use the ‘language’ and ‘format’ from the top of the config.js file because it was there … HAHA. So I took advantage of this:

language: 'en',
timeFormat: 12,
units: 'imperial'

If something comes to mind please feel free! Always looking for a better way :) Honestly I dislike making config options … too many is not a good thing I think.

strawberry 3.141

@cowboysdude you can access the global config by config.timeFormat instead of the local module config this.config.timeFormat

cowboysdude

@strawberry-3.141 said in Input...What do you think?:

config.timeFormat

Thank you for that!!! One config option gone :) There now the time function is all automatic :) ALL controlled by the users input here:

    language: 'en',
    timeFormat: 12,

Ok I’ve had my tea and toast so I must head out the door for the day :)