MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-NOAA - Another Weather Module

    Scheduled Pinned Locked Moved System
    690 Posts 77 Posters 2.7m Views 70 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • B Offline
      barnosch
      last edited by barnosch

      uncomment the “air stuff” for the moment

       /*    if (this.config.useAir != false || aquis != undefined) {
                  var aqius = this.air.aqius;
                  var aqi = document.createElement("div");
                  aqi.classList.add("xsmall", "bright");
                  if (aqius < 51) {
                      aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
                  } else if (aqius > 50 && aqius < 101) {
                      aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
                  } else if (aqius > 100 && aqius < 151) {
                      aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
                  } else if (aqius > 150 && aqius < 201) {
                      aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
                  } else {
                      aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
                  }
                  wrapper.appendChild(aqi);
              } */
      

      @cowboysdude needs to check it, since the “aquis” variabel is undefined it quits. Had the same error and i needed some time to find the cause

      edit: while i am reading i guess it is just a typo in the first line. should be “aqius” instead of “aquis” ;)

      edit2: yes. thats it. just change
      the line

      if (this.config.useAir != false || aquis != undefined) {
      

      to

      if (this.config.useAir != false || aqius != undefined) {
      

      and you are good to go again.

      Sadly i have no idea how to push the fix to the git repository

      Nystro0mN Mykle1M B 3 Replies Last reply Reply Quote 2
      • Nystro0mN Offline
        Nystro0m @barnosch
        last edited by

        @barnosch

        It did work like a charm, thanks alot dude!
        Also thanks to @Mykle1 for chatting with me and updating me on the social status of @cowboysdude hehe.
        For a first time post, i must say you guys have impressed me of how welcoming a Forum can be. It’s rare from my experience.

        Mykle1M 1 Reply Last reply Reply Quote 1
        • Mykle1M Offline
          Mykle1 Project Sponsor Module Developer @barnosch
          last edited by

          @barnosch said in MMM-NOAA - Another Weather Module:

          and you are good to go again.
          Sadly i have no idea how to push the fix to the git repository

          Nice catch you guys.

          Nice remedy @barnosch

          If you go to the modules repo https://github.com/cowboysdude/MMM-NOAA
          and click on the file you want to fix, then click on the “pencil” icon to the right, github will fork the repo for you. There you can make the edit and submit a pull request which will go to cowboysdude

          Create a working config
          How to add modules

          1 Reply Last reply Reply Quote 0
          • Mykle1M Offline
            Mykle1 Project Sponsor Module Developer @Nystro0m
            last edited by

            @Nystro0m said in MMM-NOAA - Another Weather Module:

            Also thanks to @Mykle1 for chatting with me and updating me on the social status of @cowboysdude hehe.

            I just finishing texting with @cowboysdude. I told him, “Don’t rush home from work. Someone else fixed your $h1t”.

            :^)

            Create a working config
            How to add modules

            1 Reply Last reply Reply Quote 1
            • B Offline
              barnosch @barnosch
              last edited by

              cool. thats easy.
              Thanks for the explanation. Fix added ;)

              Mykle1M 1 Reply Last reply Reply Quote 2
              • Mykle1M Offline
                Mykle1 Project Sponsor Module Developer @barnosch
                last edited by

                @barnosch said in MMM-NOAA - Another Weather Module:

                cool. thats easy.
                Thanks for the explanation. Fix added ;)

                You’re welcome.

                I’m sure @cowboysdude will appreciate it

                Create a working config
                How to add modules

                1 Reply Last reply Reply Quote 1
                • cowboysdudeC Offline
                  cowboysdude Module Developer
                  last edited by

                  Thank you @Mykle1 and @barnosch

                  Merged the pull request! :)

                  Mykle1M 1 Reply Last reply Reply Quote 1
                  • Mykle1M Offline
                    Mykle1 Project Sponsor Module Developer @cowboysdude
                    last edited by

                    @cowboysdude said in MMM-NOAA - Another Weather Module:

                    Merged the pull request! :)

                    He ran all the way home just to fix his module.

                    Yeah, he’s that good! :^)

                    And, well done @barnosch !

                    Create a working config
                    How to add modules

                    1 Reply Last reply Reply Quote 1
                    • B Offline
                      barnosch
                      last edited by

                      thanks guys. Very nice to have some guys like you here. Like this it’s fun.

                      1 Reply Last reply Reply Quote 1
                      • pjkoelemanP Offline
                        pjkoeleman @cowboysdude
                        last edited by pjkoeleman

                        @cowboysdude said in MMM-NOAA - Another Weather Module:

                        Please PM me if you’d be interested in making any other translation files for this

                        Just send you the dutch translation by Github. Don’t now if I did it the right way, so here it is as well.

                        {
                        "GATHERING WEATHER STUFF": "Ontvangen weerdata...",
                        "Currently: ": "Actueel: ",
                        "Current Temp: ": "Huidige temperatuur: ",
                        "UV Index: ": "UV-Index: ",
                        "Wind: ": "Wind: ",
                        "From: ": "van: ",
                        "Barometer: ": "Barometer: ",
                        "Monday": "Maandag",
                        "Tuesday": "Dinsdag",
                        "Wednesday": "Woensdag",
                        "Thursday": "Donderdag",
                        "Friday": "Vrijdag",
                        "Saturday": "Zaterdag",
                        "Sunday": "Zondag",
                        "High:  ": "Hoog: ",
                        "Low:  ": "Laag: ",
                        "Humidity: ": "Luchtvochtigheid: ",
                        "Safe": "Veilig",
                        "Moderate": "Gemiddeld",
                        "Very High": "Zeer hoog",
                        "Extreme": "Extreem",
                        "Sunset": "Zonsondergang",
                        "Sunrise": "Zonsopgang",
                        " hours ": " Uren ",
                        " minutes ": " Minuten ",
                        "Amount of Daylight": "Aantal uren daglicht",
                        "Good Morning ":"Goedemorgen ",
                        "Good Afternoon ": "Goedenmiddag ",
                        "Good Evening ": "Goedenavond ",
                        "Air Quality Index: ":"Luchtkwaliteitsindex: "
                        }
                        
                        cowboysdudeC 1 Reply Last reply Reply Quote 1
                        • 1
                        • 2
                        • 7
                        • 8
                        • 9
                        • 10
                        • 11
                        • 68
                        • 69
                        • 9 / 69
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy