MMM-NOAA - Another Weather Module

tbbear

Hello,
i love ur weather modul but i am from Germany so a few settings do not fit for my country.
i already made a few changes to fix them so maybe i can help u in ur german version. Also u should
update ur readme cause it took me a long time to find out where to get the key for the air values.
I made a new translation for ur module according to the french one and i also changed a few lines in ur xx.js.
Please let me know if its ok and u maybe like assistance for ur german version.

{
"GATHERING WEATHER STUFF": "Empfange Wetterdaten...",
"Currently: ": "Aktuell: ",
"Current Temp: ": "Momentane Temperatur: ",
"UV Index: ": "UV-Index: ",
"Wind: ": "Wind: ",
"From: ": "von: ",
"Barometer: ": "Barometer: ",
"Monday": "Montag",
"Tuesday": "Dienstag",
"Wednesday": "Mittwoch",
"Thursday": "Donnerstag",
"Friday": "Freitag",
"Saturday": "Samstag",
"Sunday": "Sonntag",
"Overcast": "Bedeckt",
"Cloudy": "Wolkig",
"Rain": "Regen",
"Clear": "Klar",
"Partly Cloudy": "Teilweise bewÃ¶lkt",
"Snow showers": "Schneeschauer",
"High:  ": "Hoch: ",
"Low:  ": "Niedrig: ",
"Humidity: ": "Feuchtigkeit: ",
"Safe": "Sicher",
"Moderate": "Moderat",
"Very High": "Sehr hoch",
"Extreme": "Extrem",
"Sunset": "Sonnenuntergang",
"Sunrise": "Sonnenaufgang",
" hours ": " Std. ",
" minutes ": " Min. ",
"Amount of Daylight": "Stunden mit Tageslicht",
"Good Morning ":"Guten Morgen ",
"Good Afternoon ": "Guten Nachmittag ",
"Good Evening ": "Guten Abend ",
"Air Quality Index: ":"LuftqualitÃ¤tsindex: "
}
this was my new translation
and this i changed in your ...js

	var curCon = document.createElement("div");
	curCon.classList.add("xsmall", "bright");
	curCon.innerHTML = this.translate("Currently: ") + this.translate(current.weather);
	wrapper.appendChild(curCon);

cowboysdude

@tbbear said in MMM-NOAA - Another Weather Module:

{
“GATHERING WEATHER STUFF”: “Empfange Wetterdaten…”,
"Currently: ": "Aktuell: ",
"Current Temp: ": "Momentane Temperatur: ",
"UV Index: ": "UV-Index: ",
"Wind: ": "Wind: ",
"From: ": "von: ",
"Barometer: ": "Barometer: ",
“Monday”: “Montag”,
“Tuesday”: “Dienstag”,
“Wednesday”: “Mittwoch”,
“Thursday”: “Donnerstag”,
“Friday”: “Freitag”,
“Saturday”: “Samstag”,
“Sunday”: “Sonntag”,
“Overcast”: “Bedeckt”,
“Cloudy”: “Wolkig”,
“Rain”: “Regen”,
“Clear”: “Klar”,
“Partly Cloudy”: “Teilweise bewÃ¶lkt”,
“Snow showers”: “Schneeschauer”,
"High: ": "Hoch: ",
"Low: ": "Niedrig: ",
"Humidity: ": "Feuchtigkeit: ",
“Safe”: “Sicher”,
“Moderate”: “Moderat”,
“Very High”: “Sehr hoch”,
“Extreme”: “Extrem”,
“Sunset”: “Sonnenuntergang”,
“Sunrise”: “Sonnenaufgang”,
" hours ": " Std. ",
" minutes ": " Min. ",
“Amount of Daylight”: “Stunden mit Tageslicht”,
"Good Morning ":"Guten Morgen ",
"Good Afternoon ": "Guten Nachmittag ",
"Good Evening ": "Guten Abend ",
"Air Quality Index: ":"LuftqualitÃ¤tsindex: "
}

So this is German? :)

Nystro0m

@cowboysdude Haha yes! That is for sure German :)

cowboysdude

@Nystro0m LOL right now I barely know what direction I’m going… I am SO busy with work… I will make the changes… LOL

Would be SUPER easier if it were done on github with a pull request ;)

Nystro0m

@cowboysdude Im reinstalling my Mirror to .2.10 through ssh. So alot of waiting. Got a fresh cup of tea. Im on IT!

Mykle1

@Nystro0m said in MMM-NOAA - Another Weather Module:

Im reinstalling my Mirror to .2.10 through ssh. So alot of waiting. Got a fresh cup of tea

Don’t forget Electron 1.4.15.

Tea just won’t get it done for me after today! :^)

Nystro0m

@Mykle1 And all the modules etc.
I started of migrating all of my modules and main css-changes to a custom CSS.
And now this gah, i will grab a beer after this tea. That will do it!

cowboysdude

@Nystro0m You have NO idea how much I appreciate that! THANK YOU and Tea is the nectar of the gods :)

Nystro0m

@cowboysdude No worries!
Im not sure about this one that @tbbear. So i leave that to you.

var curCon = document.createElement("div");
	curCon.classList.add("xsmall", "bright");
	curCon.innerHTML = this.translate("Currently: ") + this.translate(current.weather);
	wrapper.appendChild(curCon);

cowboysdude

@Nystro0m I will look at that this evening…Promise!

Mykle1

@Nystro0m said in MMM-NOAA - Another Weather Module:

I started of migrating all of my modules and main css-changes to a custom CSS.

You made main.css changes? Bad boy!

Nystro0m

@cowboysdude No worries! I also added the missing part in the Swedish translation.
Anything else i can help with?

cowboysdude

@Nystro0m Well if you have the winning lottery numbers that would be a big help LOL

No if you want feel free to look at it and if you have suggestions or changes let me know! :)

I started building this just for me…but after some requests I posted it… right now I"m working on turning the bottom forecast into a table so it looks better…

Nystro0m

@Mykle1 Well… You cant understand how everything works right away!
I though i needed to copy all CSS from main to custom. So i made a local backup of the Main.css instead.

I now know better! lol

Mykle1

@Nystro0m

He’s not even kidding. @cowboysdude is one of the hardest working people I know.

And then he does this for fun?

Sheeeesh!

cowboysdude

There in is MOST of my problem… I am HORRIBLE at CSS… just can’t seem to get it …

Mykle1

@cowboysdude said in MMM-NOAA - Another Weather Module:

Well if you have the winning lottery numbers that would be a big help LOL

I do have a Lottery module that might help you with that! ;^)

cowboysdude

@Mykle1 Yeah I remember that… LOL

cowboysdude

I apologize for this… I’m tired and memory is failing but… in the new version we only need a very minimal translation file… the weather will adjust automatically to the language you have selected in your config.js file ;) Here’s an example:

So there’s no need in adding to the translation files :) AND for this:

	curCon.classList.add("xsmall", "bright");
	curCon.innerHTML = this.translate("Currently: ") + current.weather;
	wrapper.appendChild(curCon);

Is correct because the variable current.weather will show in the chosen language all by itself :)

Hang in there I"m trying to finalize what I’m working on now.

tbbear

Thanks for the new translations, now only a few topics do not fit for german users.

we would not say “Anzahl der Tageslicht” we say “Stunden mit Tageslicht”
Not “11 Std. 48 Protokoll” we say “11 Std. 48 min”
we dont measure airpressure in “psi” like 29.99 here i also think this is same in a lot of countries our value is “hPa” which means “HectoPascal”
in your last post u said that my change is not necessary any more but when i remove it i still get only english actual weather so i keep it

U did and do a great Job and i hope u are not angry about my comments, but i only try to help.
So one last topic:
i saw an issue at github that people have problems installing the module and i think i know why.
If u look at your readme file it lookes like that the apiKey and the airKey are the same keys and thats wrong they are differen keys from different websites. U grab the useAir from “http://api.airvisual.com” so a user has to sign in there and get the airKey from this side but their is no hint in your readme about this.
Hope i could help.