MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    [Enhancement] Translation system

    Scheduled Pinned Locked Moved Core System
    13 Posts 9 Posters 10.0k Views 9 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • MichMichM Offline
      MichMich Admin
      last edited by paviro

      I’ve just finished the translation system which now includes core translations files and a solid fallback mechanism. This way your modules can benefit from existing translations (in the core translations files).

      All the translations used by the default modules are defined in the core translation files, making is easy to translate the core of the system. Of course, 3rd party modules should use their own translation files.

      The translation files can be found in /translations . Pull request with new or improved translations are more than welcome!

      Note: although comments are officially not supported in JSON files, MagicMirror allows it by stripping the comments before parsing the JSON file. Comments in translation files could help other translators.

      If you built your own module, and you run into translation strings from which the core system could benefit (generic texts), feel free to send a PR with updated translation files.

      1 Reply Last reply Reply Quote 1
      • paviroP Offline
        paviro Admin
        last edited by

        Nice work! Thanks a lot! :smiley:

        We're all stories in the end. Just make it a good one, eh?

        – The Doctor

        1 Reply Last reply Reply Quote 0
        • Wilco89W Offline
          Wilco89
          last edited by

          Nice Job!

          how to make a pull request?

          MichMichM 1 Reply Last reply Reply Quote 0
          • MichMichM Offline
            MichMich Admin @Wilco89
            last edited by

            @Wilco89 It looks like you figured it out?

            1 Reply Last reply Reply Quote 0
            • D Offline
              danito
              last edited by

              It says “finish translation system” but I can’t find any Finish translation.
              (sorry ;-) and thanks for the great work)

              MichMichM 1 Reply Last reply Reply Quote 0
              • MichMichM Offline
                MichMich Admin @danito
                last edited by

                @danito lol

                1 Reply Last reply Reply Quote 0
                • N Offline
                  ninja
                  last edited by ninja

                  I’ve updated fr.json file on my computer.
                  I’m also trying to do it on github, but i’m total noob :p
                  A little hint please ? I’ve tried to “pull” but not sure i’m doing it right.
                  Thx

                  1 Reply Last reply Reply Quote 0
                  • L Offline
                    Lx
                    last edited by

                    Michael, I learned that the core translation file is small and already done for a bunch of languages. Should it be expanded in the future, I’d be glad to contribute to the Hungarian translation. I could not figure out in the forum how to get enlisted for such voluntary work, that’s why I write in this post.
                    Cheers, György

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @Lx
                      last edited by

                      @lx use github to fork the MM repo, then download your copy using git clone

                      change/add whatever files need changing
                      then use git status to see the changed/new files

                      git add those files
                      then use git commit -m " description" to save those files into the local git repo copy

                      then use git push to send them to your fork on github

                      then on github create a ‘pull request’ (to the dev branch) to tell Mich that you are offering changes

                      if he approves, he will merge your changes

                      i expect that you will not understand some of that… google is your friend, search out each step…

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      qu1queQ 1 Reply Last reply Reply Quote 0
                      • L Offline
                        Lx
                        last edited by Lx

                        Sam, thanks for the instruction. You are right, I’m a total newbie here. But your sequence + google is good enough for a start. Cheers, György

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy