Read the statement by Michael Teeuw here.
Changing icons of the modules Current Weather and Weather Forecast
-
@sdetweil ok I do it
-
@sdetweil I say yes or no?
-
@Manu85 well, you have 3 files of ours that will be changed
main.css
and weather.js and calendar.jsthose changes will be lost, unless you know what you changed and why…
in general you NEVER edit any of our files…
ALL config goes in config.js
ALL css goes in custom.cssreply no… also, I am adding a new check in test run mode…
these changed files is the EXACT reason for test mode.
otherwise those changes would be lost and your mirror might be broken -
@sdetweil I may have moved something before meeting you, but in any case, I didn’t do anything that was important, now I know that I only touch config.js and css.custom!
to carry out a test I pass the same line? -
@Manu85 said in Changing icons of the modules Current Weather and Weather Forecast:
to carry out a test I pass the same line?
you just DID the test pass…
if you want to see what changed in those files , for each do
git diff thefilename
for example
git diff css/main.css
-
@sdetweil I certainly didn’t understand…when I place the order I get this
pi@MagicMirror:~ $ git diff css/main.css Not a git repository To compare two paths outside a working tree: usage: git diff [--no-index] <path> <path>
-
@Manu85 again have to be IN the MagicMirror folder
-
@sdetweil I think it’s because I wasn’t in the MM folder, now I have this
-
@Manu85 red is old, green is new…
SO, if you want to KEEP those, then they have to move to custom.css
do the same for the other files… needs the full path
modules/default…
-
@sdetweil ok if I understand correctly, I do this for all modules which presented a problem, putting the full address for each module? example :
git diff modules/default/calendar/calendar.js
, I just