MMM-News

uros76

Ok @Sean understand the drawbacks of MM structure and thanks for all the work on this module.
It was just a thought if its possible. I will live with use of two modules :)

sdetweil

@Sean I added support in my MyCovid19 module for multiple instances… it was different, but not hard

on all modlename.js sendSocketNotificatons, add the module identifier
on all node_helper sendSocketNotifications, send it back

in modulename.js , CHECK all receiveSocketNotifcation messages to see if its intended for this instance, as the sendSocketNotification from the node_helper goes to ALL modulename.js instances at once.

then in node_helper I cached the data (as u proposed with the server instance), and for every request fordata from the modulename.js, I check to see if the data has arrived,

if not, the 1st instance to arrive calls the api to get the data, all others block in Promise
once the data arrives, all get resolved() with the data
if the data is already here, then I resolve() with the data

in my production system I have 11 charts drawn, and have 2 extra browser windows open to the MM server, so 33 charts in all, served by one node_helper all sharing one data source, and only making 1 api call for the data

A Former User

@sdetweil
I don’t want to make an argument about your success. The difficulty is always relative. :)

As you’ve said, all cloned modules should manage their own ID by themselves. (not only for the one device but also for each clients if multi-devices are working under server-clients)
It could not be difficult, frankly, usual web sites/applications/components are developed like that.
But the MM… hmmm. I always consider MM would be a standalone running device. Even though there exist some server/client usecases, most of the modules are developed as standalone. Using H/W peripheral(like GPIO or mic) is an example.
Of course, we, developers can make the module clonable from the early stage of development. But I often have a question it’s worthy.

For an imaginary use-case of other users, should I consider to make module clonable? Always my answer for this MM was… no.
Because;

I’m not using clones. If I need something similar, I would make a new module, which might be able to manage multi-views(like CALEXT2) or to share some resources.(AMK2 and HOTWORDS), but it makes things too complex. I hate this way.
I feel some cul-de-sac from MM legacy. MM needs to provide more friendly way to reuse modules. At this moment, not. So that’s why I haven’t considered cloning. and why I lost interest in MM.

Anyway, to say shortly. This module is not made for that purpose. Unless modification by myself or somebody, not possible. That’s all.

sdetweil

@Sean yes, I understand. I have made a couple this way , because the use case shows multiple instances very quickly.

but many do not, if they are hardware constrained…

swvalenti

git pull and npm install says it updated packages but when I check the version in the package.json it shows 2.0.0? What am I doing wrong? Thanks

pi@raspberrypi:~ $ cd MagicMirror 
pi@raspberrypi:~/MagicMirror $ cd modules pi@raspberrypi:~/MagicMirror/modules $ cd MMM-News pi@raspberrypi:~/MagicMirror/modules/MMM-News $ git pull Updating 081fcb2..bff080d 
pi@raspberrypi:~/MagicMirror/modules/MMM-News $ npm install audited 95 packages in 3.8s found 0 vulnerabilities>\

swvalenti

Anyone having an issue of news feed working then not working…just a black screen in the mirror portion position.

A Former User

Yes, i have this problem this week, don’t know really why.
i have not read log for debugging it

Next time, if i have this problem i will see what happen

swvalenti

@Bugsounet ok thanks, let me know if I can do anything to help.

swvalenti

Anything I can do in the mean time to troubleshoot to help get this resolved. It is happening now, I looked in the dev window but didn’t see any errors. I don’t know where else to look. Attached should show the news on the bottom bar but nothing there. Thanks, Scott

swvalenti

@Bugsounet Just circling back on this…would it be easier if I created an issue on github or leave it here?

sdetweil

@swvalenti whos news? did u look in the console window where u started MM?

or pm2 logs if using pm2?

news and calendar use the node_helper to fetch info…

swvalenti

Thanks Sam, checked the pm2 logs and unbeknownst to me…they now went to a paid tier api it seems!


1|MagicMir | [2020-11-17 16:23:16.523] [LOG]    [NEWS] Error :  https://newsapi.org/v2/top-headlines?country=us&pageSize=20&apiKey=99d1bd76c7f140f58c237d54c41ab334 result.code:You have made too many requests recently. Developer accounts are limited to 100 requests over a 24 hour period (50 requests available every 12 hours). Please upgrade to a paid plan if you need more requests.

sdetweil

@swvalenti said in MMM-News:

50 requests available every 12 hours

change the refresh rate to 15 minutes that would be 48 per 12 hours

swvalenti

@sdetweil I don’t see that as an option in the config…

sdetweil

@swvalenti edit line 48 of node_helper.js

change

    this.scanInterval = 1000*60*10

to this

    this.scanInterval = 1000*60*15

A Former User

@sdetweil yes, it’s new they have limited request. So I will add new part of code for define interval, quickly

A Former User

Hi, I have upgraded to v2.1.2 with personal fetch interval.
By default i put 30 min in default config

swvalenti

@Bugsounet thank you very much

swvalenti

@Bugsounet still getting the same error in the logs and news not displaying because of it. Below is my config. Any ideas?

},
		{
  		module: "MMM-News",
  		position: "bottom_bar",
  		config: {
    		apiKey : "XXXXXXXXX",
    		type: "horizontal",
    		query : [
      		{
        	sources: "fox-news, fox-sports",
},
      {
        country: "us",
        className: "redTitle",
      },
    ],
	touchable: false,
	scanInterval: 1000*60*15
  }
},

swvalenti

Not sure what it means but says initialized with 10 query

/home/pi/.pm2/logs/MagicMirror-out.log last 15 lines:
1|MagicMir | [2020-11-22 18:00:23.595] [LOG]    MMM-PGA Retrieving Tounament List
1|MagicMir | [2020-11-22 18:00:24.198] [LOG]    MMM-PGA retrieving Tournament Data
1|MagicMir | [2020-11-22 18:05:22.126] [LOG]    Use existing calendar fetcher for url: https://www.calendarlabs.com/ical-calendar/ics/76/US_Holidays.ics
1|MagicMir | [2020-11-22 18:05:22.134] [INFO]   Calendar-Fetcher: Broadcasting 2 events.
1|MagicMir | [2020-11-22 18:05:22.391] [INFO]   Calendar-Fetcher: Broadcasting 2 events.
1|MagicMir | [2020-11-22 18:05:24.044] [LOG]    MMM-PGA retrieving Tournament Data
1|MagicMir | [2020-11-22 18:05:24.437] [LOG]    MMM-PGA Retrieving Tounament List
1|MagicMir | [2020-11-22 18:07:49.476] [LOG]    Use existing calendar fetcher for url: https://www.calendarlabs.com/ical-calendar/ics/76/US_Holidays.ics
1|MagicMir | [2020-11-22 18:07:49.477] [INFO]   Calendar-Fetcher: Broadcasting 2 events.
1|MagicMir | [2020-11-22 18:07:49.481] [LOG]    MMM-PGA config received
1|MagicMir | [2020-11-22 18:07:49.485] [LOG]    [NEWS] MMM-News Version: 2.1.2
1|MagicMir | [2020-11-22 18:07:49.486] [LOG]    [NEWS] Initialized with 10 query
1|MagicMir | [2020-11-22 18:07:49.720] [LOG]    MMM-PGA Retrieving Tounament List
1|MagicMir | [2020-11-22 18:07:49.804] [INFO]   Calendar-Fetcher: Broadcasting 2 events.
1|MagicMir | [2020-11-22 18:07:50.969] [LOG]    MMM-PGA retrieving Tournament Data