@sdetweil said in Failed update:

@DarrenHill said in Failed update:

tr

rerun, I had to fix the order of parms on the npm install

just updated use force at the end now as 2.21 is installed but not setup

I assume you mean

bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)" force

It ran, but didn’t seem to help. Still got the same in the logs. Also tried “apply force” at the end just in case, no different.

The script also did display Unknown command: “dev” after each module listing, which may relate to your second post above? An example below - the same appears for all the modules.

No LSB modules are available.
doing test run = false
update log will be in /home/pi/MagicMirror/installers/upgrade.log
Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v16.9.1
Installed Node version: v16.17.1
No Node.js upgrade necessary.
Check current NPM installation ...
NPM currently installed. Checking version number.
Minimum npm version: V7.11.2
Installed npm version: V8.15.0
No npm upgrade necessary.

saving custom.css
(23) Failed writing body
upgrading from version 2.21.0 to 2.21.0
fetching latest revisions
updating MagicMirror runtime, please wait
Unknown command: "dev"

To see a list of supported npm commands, run:
  npm help
Checking for modules with removed libraries
processing dependency changes for active modules with package.json files

processing for module MMM-ModuleScheduler please wait
----------------------------------
Unknown command: "dev"

Just tried to update my mirror (running on a Pi3) using the update script and now just getting the RaspiOS desktop.

In the error log I’m getting this:

/tmp/start-ae66716a.sh: 1: /tmp/start-ae66716a.sh: ./node_modules/.bin/electron: not found
/tmp/start-5f9bf958.sh: 1: /tmp/start-5f9bf958.sh: ./node_modules/.bin/electron: not found
/tmp/start-61e117a4.sh: 1: /tmp/start-61e117a4.sh: ./node_modules/.bin/electron: not found
/tmp/start-d066481b.sh: 1: /tmp/start-d066481b.sh: ./node_modules/.bin/electron: not found
/tmp/start-e2a8c45b.sh: 1: /tmp/start-e2a8c45b.sh: ./node_modules/.bin/electron: not found
/tmp/start-811c1067.sh: 1: /tmp/start-811c1067.sh: ./node_modules/.bin/electron: not found
/tmp/start-0200e581.sh: 1: /tmp/start-0200e581.sh: ./node_modules/.bin/electron: not found
/tmp/start-b6c97c53.sh: 1: /tmp/start-b6c97c53.sh: ./node_modules/.bin/electron: not found
/tmp/start-1e98fa17.sh: 1: /tmp/start-1e98fa17.sh: ./node_modules/.bin/electron: not found
/tmp/start-e0978d33.sh: 1: /tmp/start-e0978d33.sh: ./node_modules/.bin/electron: not found
/tmp/start-23891cd1.sh: 1: /tmp/start-23891cd1.sh: ./node_modules/.bin/electron: not found
/tmp/start-425db6c2.sh: 1: /tmp/start-425db6c2.sh: ./node_modules/.bin/electron: not found
/tmp/start-4430a341.sh: 1: /tmp/start-4430a341.sh: ./node_modules/.bin/electron: not found
/tmp/start-be15a75e.sh: 1: /tmp/start-be15a75e.sh: ./node_modules/.bin/electron: not found

And there is indeed no electron in there, although there is .electron-7jst2j2U -> …/electron/cli.js ?

pi@mirrorpi:~/MagicMirror/node_modules/.bin $ ls -al
total 44
drwxr-xr-x   2 pi pi  4096 Oct  2 17:59 .
drwxr-xr-x 587 pi pi 36864 Oct  2 17:59 ..
lrwxrwxrwx   1 pi pi    18 Jul  3 12:40 .acorn-IIB8cHVa -> ../acorn/bin/acorn
lrwxrwxrwx   1 pi pi    18 Jul  3 12:40 .electron-7jst2j2U -> ../electron/cli.js
lrwxrwxrwx   1 pi pi    23 Jul  3 12:40 .eslint-UE4ITVWN -> ../eslint/bin/eslint.js
lrwxrwxrwx   1 pi pi    21 Sep  2  2020 extract-zip -> ../extract-zip/cli.js
lrwxrwxrwx   1 pi pi    25 Jan  9  2022 js-yaml -> ../js-yaml/bin/js-yaml.js
lrwxrwxrwx   1 pi pi    14 Jul  3 12:40 mime -> ../mime/cli.js
lrwxrwxrwx   1 pi pi    20 Apr  2  2022 mkdirp -> ../mkdirp/bin/cmd.js
lrwxrwxrwx   1 pi pi    23 Jul 25  2021 node-which -> ../which/bin/node-which
lrwxrwxrwx   1 pi pi    16 Jul 25  2021 rimraf -> ../rimraf/bin.js
lrwxrwxrwx   1 pi pi    23 Jul 25  2021 semver -> ../semver/bin/semver.js
lrwxrwxrwx   1 pi pi    21 Jul 25  2021 uuid -> ../uuid/dist/bin/uuid

Any tips to get things up and running again?
The script itself seemed to run fine and finished back to the command prompt as expected.

To add - I checked via the web link (in Chrome) and both keys give exactly the same response:

Original:

{"status":"ok","totalResults":10,"articles":[{"title":"Charles formally confirmed as king in ceremony televised for first time","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T09:22:16.0519529Z","url":"http://www.bbc.co.uk/news/uk-62860893"},{"title":"Kharkiv offensive: Russia surprised as Ukraine takes several towns - UK","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T08:37:17.1082493Z","url":"http://www.bbc.co.uk/news/world-europe-62860774"},{"title":"Sir Elton John pays tribute to Queen Elizabeth II","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T01:22:23.3573709Z","url":"http://www.bbc.co.uk/news/entertainment-arts-62860047"},{"title":"In pictures: Queen Elizabeth II in North America","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T21:37:18.1845741Z","url":"http://www.bbc.co.uk/news/world-us-canada-62854864"},{"title":"What do we call the Royal Family now?","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T18:22:20.0913328Z","url":"http://www.bbc.co.uk/news/uk-62854804"},{"title":"In pictures: King Charles' first full day on the throne","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T17:07:22.1996941Z","url":"http://www.bbc.co.uk/news/in-pictures-62797450"},{"title":"Six times the Queen made us laugh","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T16:22:20.8594645Z","url":"http://www.bbc.co.uk/news/uk-62849166"},{"title":"Outpouring of sympathy across the Commonwealth","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T12:52:20.8883515Z","url":"http://www.bbc.co.uk/news/world-62852412"},{"title":"Queen Elizabeth II: Your tributes to UK's longest-reigning monarch","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T09:07:26.059624Z","url":"http://www.bbc.co.uk/news/live/uk-62847455"},{"title":"Royal rebranding: What will happen to stamps, coins, banknotes and passports?","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T07:22:20.9827975Z","url":"http://www.bbc.co.uk/news/uk-59596996"}]}

New:

{"status":"ok","totalResults":10,"articles":[{"title":"Charles formally confirmed as king in ceremony televised for first time","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T09:22:16.0519529Z","url":"http://www.bbc.co.uk/news/uk-62860893"},{"title":"Kharkiv offensive: Russia surprised as Ukraine takes several towns - UK","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T08:37:17.1082493Z","url":"http://www.bbc.co.uk/news/world-europe-62860774"},{"title":"Sir Elton John pays tribute to Queen Elizabeth II","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-10T01:22:23.3573709Z","url":"http://www.bbc.co.uk/news/entertainment-arts-62860047"},{"title":"In pictures: Queen Elizabeth II in North America","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T21:37:18.1845741Z","url":"http://www.bbc.co.uk/news/world-us-canada-62854864"},{"title":"What do we call the Royal Family now?","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T18:22:20.0913328Z","url":"http://www.bbc.co.uk/news/uk-62854804"},{"title":"In pictures: King Charles' first full day on the throne","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T17:07:22.1996941Z","url":"http://www.bbc.co.uk/news/in-pictures-62797450"},{"title":"Six times the Queen made us laugh","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T16:22:20.8594645Z","url":"http://www.bbc.co.uk/news/uk-62849166"},{"title":"Outpouring of sympathy across the Commonwealth","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T12:52:20.8883515Z","url":"http://www.bbc.co.uk/news/world-62852412"},{"title":"Queen Elizabeth II: Your tributes to UK's longest-reigning monarch","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T09:07:26.059624Z","url":"http://www.bbc.co.uk/news/live/uk-62847455"},{"title":"Royal rebranding: What will happen to stamps, coins, banknotes and passports?","author":"BBC News","source":{"Id":"bbc-news","Name":"BBC News"},"publishedAt":"2022-09-09T07:22:20.9827975Z","url":"http://www.bbc.co.uk/news/uk-59596996"}]}

So the data is there, it’s not the module or the code, so it must be the API response specifically to my IP address or set-up. And if it is, we’re stuck and I guess I’ll just have to remove the module from my set-up.

@sdetweil - thanks - tried your API key and it gives exactly the same results as my original one.

I also put my original API key into the chat, if you have time and are able could you test it for me?

I’m starting to think that for some reason NewsAPI cannot provide a proper service to UK IP addresses or something like that.

And I guess if that’s the case then we’re stuck, as everything provided by MM and you guys is all working fine, it’s just their API data that is for some reason messed up.

By the way, can I take this moment to also thank both you and @mumblebaj for the support to look into this.

@mumblebaj - Yes, as I said I’m starting to think that your modules are both working fine, but the API feed I’m getting from NewsAPI is somehow corrupted and they are universally having issues with it.

I can’t create a new API key as it won’t let me (it says they don’t support UK now if you try and create a new key from here), and I guess that might be related somehow?

So I think we might be at a dead end here unfortunately with anything that’s using that API as its source.

@mumblebaj - Thanks for the support, and for both modules.

Unfortunately that gives me a headline in Spanish (I think) about Apple iPhone 14 with “undefined” below it.

I also tried your everything example configs from your GH page and got a similar layout (headline and undefined).

I’m beginning to think NewsAPI itself is screwed for me unfortunately, so we may be onto a loser here regardless of module.

@mumblebaj - Thanks, no need to apologise.

I tried the other module, and it also doesn’t show anything besides it’s “News” header title.

The config I tried was:

        {
            module: "MMM-NewsAPI",
            header: "News",
            position: "bottom_center",
            config: {
                apiKey : "<my API key>",
                domains: "bbc.co.uk",
                language: "en"
                }
        },

And also I tried replacing the domains: with sources: “bbc-news” and that gave the same results.

There’s nothing in the logs, aside from confirming that the module is loading (as can be seen from the displayed title too).

I tried to register for a new api key, but when I tried it told me that they don’t support the UK (where I am) so I wonder if that somehow has something to do with it.

This has obviously changed since I first registered, and given I’m getting some response from the API it is at least partially working, but besides that I have no idea…

@MMRIZE said in MMM-News and BBC:

@DarrenHill
Ok, I found something. I don’t know why, but your result has “articles.source.Name” instead of “articles.source.name” that makes this error.

Anything I can do to overcome that?

No idea why I’m getting different API returns to you guys…?

@sdetweil I get this (for the relevant bit):

[06.09.2022 21:11.46.552] [LOG]   fetch result= {
  status: 'ok',
  totalResults: 10,
  articles: [
    {
      title: 'Vaping: Juul to pay $438.5 m in youth marketing probe',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T19:52:21.045172Z',
      url: 'http://www.bbc.co.uk/news/business-62813896'
    },
    {
      title: 'Eliza Fletcher: Police identify body found in search for heiress',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T16:52:18.6995928Z',
      url: 'http://www.bbc.co.uk/news/world-us-canada-62811661'
    },
    {
      title: 'Ukraine war: Russians to pay €45 more to enter EU under new rules',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T16:37:23.3671715Z',
      url: 'http://www.bbc.co.uk/news/world-europe-62811675'
    },
    {
      title: 'Fat Leonard: Malaysian businessman linked to US Navy scandal escapes',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T16:22:22.2671956Z',
      url: 'http://www.bbc.co.uk/news/world-us-canada-62764226'
    },
    {
      title: 'Canada stabbings: Police hunt remaining suspect after Saskatchewan attacks',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T15:22:24.1190163Z',
      url: 'http://www.bbc.co.uk/news/live/world-us-canada-62811629'
    },
    {
      title: 'Ukraine: Ben Stiller and Sean Penn latest Americans banned from Russia',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T12:52:14.8462267Z',
      url: 'http://www.bbc.co.uk/news/world-europe-62806655'
    },
    {
      title: "Canada stabbings: Relatives identify 'random' victims of Saskatchewan attack",
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T11:07:21.1055569Z',
      url: 'http://www.bbc.co.uk/news/world-us-canada-62804826'
    },
    {
      title: 'Liz Truss: Boris Johnson to give farewell speech before new PM takes office',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-06T04:37:21.3806544Z',
      url: 'http://www.bbc.co.uk/news/live/uk-politics-62802807'
    },
    {
      title: 'Keith Davis: He was protecting the oceans - then he disappeared',
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-05T20:52:23.0241991Z',
      url: 'http://www.bbc.co.uk/news/world-us-canada-62603911'
    },
    {
      title: "Timed Teaser: How did Putin mark Gorbachev's death?",
      author: 'BBC News',
      source: [Object],
      publishedAt: '2022-09-05T20:37:23.1798468Z',
      url: 'http://www.bbc.co.uk/news/world-us-canada-62763889'
    }
  ]
}
[06.09.2022 21:11.46.635] [LOG]   [NEWS] Error :  https://newsapi.org/v2/top-headlines?sources=bbc-news&pageSize=100&apiKey=<redacted> TypeError: Cannot read properties of undefined (reading 'toString')
    at slugify (/home/pi/MagicMirror/modules/MMM-News/node_helper.js:24:17)
    at cb (/home/pi/MagicMirror/modules/MMM-News/node_helper.js:89:33)
    at getArticles (/home/pi/MagicMirror/modules/MMM-News/node_helper.js:136:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:5)