MMM-MyCommute

[tidus5]

@j.e.f.f Perfect!!!

thanks :-)

[jon11a]

Hi @j.e.f.f
Just wanted to say, thanks so much for spending your time building this module! I have just finished my MagicMirror build and this module is by far the best and most used. I love how much I’m able to customise it to thanks to your hard work.

Now, I wondered if it was easy to add the following… My commute is always over an hour, would it be possible to format the commute time to show 1h 30 min rather than 90 min for example? It would still show just ‘min’ if under an hour (20 min for example).

If it’s not all that easy and you’d rather not alter the code, then that’s fine, I may have a bash at editing the code on my Pi myself.

Thanks again!

[j.e.f.f]

@jon11a It’s certainly possible. But it takes up considerably more space to render “1h 30 min” than it does to render “90 min”. The space that the travel time uses takes away from the space used for the text to its left. That is why I chose to render it that way. Even an extremely long commute of over 2 hours would only take up an extra 8 pixels or so. By doing it this way, it should be more or less the same width for everyone, with less chance of truncating the label.

If you want to change this yourself, it’s a fairly trivial change to the formatTime function in MMM-MyCommute.js. Google returns the travel time in the number of seconds. I’ve just done a simple division by 60 to get the number of minutes. You can just do a little more math and re-jig the formatting as you’d like.

Happy to hear that you like the module!

-Jeff

[jon11a]

@j.e.f.f Thanks for your quick response Jeff. I thought that might be the reason behind your decision to just use mins. It does make sense to me.

I think I will have a go at changing mine, will be a good little challenge for me as I’m learning more and more programming skills!

Thanks again and I look forward to see what you come up with next ;)

[j.e.f.f]

@jon11a Fair warning: this module was also the result of me wanting to change a thing or two to suit my own needs ;). Before I knew I had something completely new! It shares little resemblance with the module I originally forked from mrx-work-traffic.

Have fun. I can’t wait to see how it evolves!

-Jeff

[jon11a]

@j.e.f.f
Managed to do it and pretty pleased with myself :)

Here’s what it looks like:

I had to edit the css file to move the destination-label slightly as you mentioned:

margin-right: 70px;

I edited your formatTime function to format the time in hours and minutes or just minutes if it’s less than an hour in total.
Below is the code for that function with my bits added, I am sure it could be better but I think I did ok!

formatTime: function(time, timeInTraffic) {

    var timeEl = document.createElement("span");
    timeEl.classList.add("travel-time");
    if (timeInTraffic != null) {
      var minutes = Math.floor(Number(timeInTraffic) /60);
      var h = Math.floor(minutes /60);
      var m = Math.floor(minutes %60);
      if (h == 0) {
        timeEl.innerHTML = m + " min";
      } else {
        timeEl.innerHTML = h + "h " + m + " min";
      }
      var variance = timeInTraffic / time;
      if (this.config.colorCodeTravelTime) {
        if (variance > this.config.poorTimeThreshold) {
          timeEl.classList.add("status-poor");
        } else if (variance > this.config.moderateTimeThreshold) {
          timeEl.classList.add("status-moderate");
        } else {
          timeEl.classList.add("status-good");
        }
      }
    } else {
      var minutes = Math.floor(Number(time) /60);
      var h = Math.floor(minutes /60);
      var m = Math.floor(minutes %60);
      if (h == 0) {
        timeEl.innerHTML = m + " min";
      } else {
        timeEl.innerHTML = h + "h " + m + " min";
      }
      timeEl.classList.add("status-good");
    }

Thanks for your help Jeff, learned some more programming skills too so I’m happy! :)

[joela85]

startTime & endTime query.

I’ve tried setting these times up for the morning time before going to work and after testing it hides itself but it never re-appeared this morning?
Has anyone else had this issue?

module: 'MMM-MyCommute',
  position: 'bottom_right',
  config: {
    showHeader: true,
    headerText: 'Traffic',
    apikey: 'API_KEY_FROM_GOOGLE',
    origin: 'My Address',
    startTime: '06:00',
    endTime: '09:00',
    destinations: [
                   etc...

It would also be good if you could set it to run on Mon-Fri as well.
If not possible I could use the MMM-Scheduler to do this instead, it’s just a bit tidier in this module.

[Blackmirror]

This module is great, but it was nicer, to take starttime and endtime for the different destinations.
So, I will go to work in the morning, soIneed this only between 5.00 and 6.00 o’clock and if I will go to the salsa party I need this only in the evening.

[j.e.f.f]

@joela85 I just did a quick test on my laptop by changing the clock to mover forward a day at a time, and I had the module disappear and reappear consistently. I’ve set my config to startTime: '06:00' and endTime: '09:00' and I’ll let it run overnight to see if I can recreate your issue.

I also like the Mon-Fri idea, as well as the individual time windows per destination. Will work on them over the next few days.

[j.e.f.f]

@Blackmirror I ran a test overnight and my module came back on when it should have. But I did realize there is a fundamental problem with how I’ve architected the data pull. Are you using two instances of this module? If so I’m thinking that may be causing problems and possibly yours. I’m going to write an update soon, and I’ll have you try again.