MMM-cryptocurrency - v1.4

strawberry 3.141

@ArkantosArk Yes, midori doesn’t support ES6 and the module makes use of it. Try to run it and access it via a browser on another machine for testing purposes it should probably work.

matteodanelli

@ArkantosArk As @strawberry-3-141 mentioned, I use ES6 in the module and so some old browsers aren’t working. Midori uses an old version of the web engine, but I know that it’s the best browser on the RPi1.

However, I tried to replace in my module a function which creates a problem. I am not sure to have solved totally the problem because I cannot test on Midori.
I’ve updated the module so you can test it now, hoping that it’s working, or at least it shows less problems :)

Let me know!

ArkantosArk

@matteodanelli Now it’s working! thanks a lot for this I feel really privileged!. Thanks for taking the effort to update the module just for this.

canadrian

Thank you for this module.
In order to add a new coin, I’ve added into sparklineIds the id, eg. chainlink: 1975,
ran an nmp install into the MMM-cryptocurrency module, but still no luck,
sparklineId is correct, am I missing something?
Thanks in advance.

matteodanelli

@canadrian said in MMM-cryptocurrency - v1.1:

chainlink: 1975

Hi,
I had configured module to get only top 25 currencies, in order to be more efficient.
Now I’ve updated module in order to get all 100. If you want to check it out last version you should be able to get it.

canadrian

@matteodanelli works great, thank you!

SvenSommer

Hey @matteodanelli ,
thank you for this great module.
I added an alternative display mode to see the changes within the logo view.

I made a pull request. Here are the changes:

1 hour , 1 day and 7days changes can be displayed by adding ‘logoWithChanges’ as display type.
option and screenshots added to README.md

matteodanelli

@SvenSommer Thank you! Great additions!

rmeskill

Is there a way to add a custom page within the module? I’m specifically looking to add more coins of my own that you don’t include by default, but every time I do it gets overwritten by a pull.

matteodanelli

@rmeskill Hi, sure! You can contribute to the project if you want :)

You can either create a fork of my repository and develop it with your needs. But you’ll lose my updates.
Else, to keep updated, fork the repository and then make a pull request to merge your fork with my repository.
I’ll accept it and everyone will have your useful work :)

fox

@SvenSommer Amazing Changes.
Thank you both. My question:
How to change the font size?
I was in MMM-cryptocurrency.css but there is no font.
thanks

edit: i found it

.mmm-cryptocurrency-icon > tr > td {
    padding-bottom: 10px;
    text-align: left;
	font-size: 80%;
}

How can i show other graphs?
Bild Text

matteodanelli

@fox Hi,
About the graphs, you should add your currency inside sparklineIds array (in Js file), which have to be taken directly from coinmarketcap.com.

Let me know if it works!

fox

@matteodanelli thank you.
But i dont know where the sparkline Id is written in coinmarketcap.
e.g. for IOTA: https://coinmarketcap.com/currencies/iota/#tools ?

matteodanelli

@fox You can find id in the homepage of coinmarketcap. Just get the link of the image of the graph of the desired currency.

EG. For IOTA, link is https://files.coinmarketcap.com/generated/sparklines/1720.png, so id is 1720.

fox

@matteodanelli Thank you! It worked and again - what an amazing module. Thank you very much.

fox

@matteodanelli , @Klizzy
a portfolio view would be amazing, what do you think?
Like on the iOS app delta or on cryptocompare or etc. portfolios.
But its harder to implement i think because its the view of each MagicMirror User’s portfolio ?!

canadrian

@fox said in MMM-cryptocurrency - v1.4:

@matteodanelli , @Klizzy
a portfolio view would be amazing, what do you think?
Like on the iOS app delta or on cryptocompare or etc. portfolios.
But its harder to implement i think because its the view of each MagicMirror User’s portfolio ?!

alternate way, use maybe coinfolium.com, generate your link and use iframe in the mirror

fox

@canadrian
thank you i will give it a try. But i have to maintain the link after every trade?

@matteodanelli
what is my problem with bitcoin-gold?

: {
  currency: [
           "bitcoin",
            "monero",
            "iota",
            "eos",
             "bitcoin-gold"
 ],

and the

  sparklineIds: {
    bitcoin: 1,
    ethereum: 1027,
    ripple: 52,
    litecoin: 2,
    'ethereum-classic': 1321,
    nem: 873,
    stratis: 1343,
    iota: 1720,
    monero: 328,
    eos: 1765,
    'bitcoin-cash': 1831,
    'bitcoin-gold': 2083
  },

Logo is bitcoin-gold.png

But is does not appear on my Magic mirror :/

matteodanelli

@fox Because in the ranking is too low. You should change limit from 100 to at least 1000 in getTicker function to get it working.

canadrian

@fox said in MMM-cryptocurrency - v1.4:

@canadrian
thank you i will give it a try. But i have to maintain the link after every trade?

Yes, you have to update your portfolio (holdings) and coinfolium url changes.