• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-KVV - Local Karlsruhe transport (KVV) departure times

Scheduled Pinned Locked Moved Transport
9 Posts 5 Posters 5.0k Views 5 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • Y Offline
    yo-less Module Developer
    last edited by yo-less Aug 25, 2016, 3:48 PM Aug 25, 2016, 3:45 PM

    First of all, a big shout out to @ronny3050 for his impressive helpfulness in getting me started. I came across a really weird problem when I started developing this module and his willingness to help a newbie right away, made me feel very welcome here :).

    Secondly, I want to thank @MichMich for his willingness to share his work and ideas. Trying to find a nice bathroom mirror and quite unhappy with the mirrors that are available on the market, I came across your project by chance and immediately fell in love with your invention. You could have easily used your idea to make a lot of money with your mirror, but instead you chose to share the fruits of your labor with the world. I hope that many, many others will follow your lead in the years to come :).

    I only code in my spare time and have so far mostly worked on some simple web pages, but this project has pushed me to try and acquire a lot of new skills in a very short span of time. Github, npm, node.js, … . For the first few days I felt like I was drowning in a sea of information I couldn’t, for the life of me, get a grasp on, but now my first JavaScript modules are done, and I couldn’t be prouder :). So thanks to all of you for your great attitude and help.

    Anyway, here’s my first module:

    [card:yo-less/MMM-KVV]

    0_1472139897715_screenshot_en.png

    MMM-KVV shows departures times for any given stop of the Karlruhe local transport network on your mirror.

    It is pretty customizable and I have tried to explain its installation and configuration on the Github page. Even though there may not be that many users here from the Karlsruhe area (if any), I look forward to hearing from you, should you come across any bugs or problems or should you find this module useful.

    J 1 Reply Last reply Oct 13, 2016, 10:09 AM Reply Quote 3
    • S Offline
      strawberry 3.141 Project Sponsor Module Developer
      last edited by Aug 25, 2016, 4:18 PM

      two weeks ago i was in karlsruhe, could have need your module back then :D

      ps there are leftovers of your inspirational modules like this

      Please create a github issue if you need help, so I can keep track

      1 Reply Last reply Reply Quote 0
      • Y Offline
        yo-less Module Developer
        last edited by Aug 25, 2016, 4:41 PM

        Does this mean you carry your MagicMirror with you, wherever you go? :D

        Thanks for your pointing it out :). Yeah, in the beginning I wildly added and deleted code lines from existing modules to try and understand how the whole thing worked, in the end you end up with a nice compilation of code lines.

        1 Reply Last reply Reply Quote 0
        • J Offline
          Jay
          last edited by Oct 13, 2016, 9:09 AM

          As a Karlsruher I have to say, the MMM-KVV Script runs like a charm, big thanks to @yo-less !
          One or two annotations and suggestions:
          For me, it seems like that the maxConn (maximum amount of displayed connections) is limited to 10 even if a value higher than 10 is stated. So in practice, if you have to walk 7-8 minutes to the station, every of the 10 trains already departed. As a workaround, I determined a specific direction to get more possible choices, but only the amount of the 10 trains which head to the specified direction appear (mostly 4-6 connections).
          Is there any way to exclude departure times (like exclude: now to departure in 5 minutes) or to extend the displayed connections further than 10?

          Y 1 Reply Last reply Oct 13, 2016, 4:51 PM Reply Quote 0
          • J Offline
            Jopyth Moderator @yo-less
            last edited by Jopyth Oct 13, 2016, 10:10 AM Oct 13, 2016, 10:09 AM

            @yo-less Nice module you have here, it would be a shame if someone … would steal it. :)

            I am currently working on a departure time module for Berlin/Brandenburg, I like the layout of your module and would like to use a similar layout, and I guess the MIT license says yes, but I would still like to ask.

            Also I have a few suggestions, which I either implemented already, or are going to implement for my module. Maybe you want some of these options, too.

            You could allow users to use a custom header, maybe they want a custom name instead of the station name? E.g. check if this.data.header is set, and if yes, do not create your own one.
            Also when version 2.1.0 of the MagicMirror is released, you can use the https://github.com/MichMich/MagicMirror/tree/develop/modules#getheader function.
            And no matter which of these methods you use in the future, it might be nice to have an optional small appendix (last updated: 12:30) to the header with the time the data was last updated at, e.g. something like a font awesome refresh symbol + the time in case of connection issues.

            Helpful sticky: How to troubleshoot

            Y 1 Reply Last reply Oct 13, 2016, 5:12 PM Reply Quote 0
            • Y Offline
              yo-less Module Developer @Jay
              last edited by yo-less Oct 13, 2016, 5:01 PM Oct 13, 2016, 4:51 PM

              @Jay Thanks for your kind words, I’m happy to hear somebody else is running the module on their mirror, I’ve been wondering whether someone else from our our region might eventually turn up here :). Should you run into any issues, feel free to report them here or over on the Github page.

              Unfortunately, there is very little I can do to help you with your request. The data is pulled from the same dataset as the results you can see listed on http://live.kvv.de - try it for your stop and you will see that the maximum number of connections is 10 in your web browser as well. This is the way the service is designed, so if the KVV people decide to change their API at some stage to allow for more connections, the module should automatically pick that up and offer you more connections as well. If your stop is in the inner-city area, you are bound to end up with trams and trains that depart within the next few minutes. If your stop is only serviced by one line, you can normally see pretty well into the future :).

              It would be possible to add a config option to only show trams that depart in, say, 5 minutes or later, but this would only shorten your list to the few of the 10 given trams that depart in 5 minutes or later. There is no way for me to add an option to extend the list of trams into the future by cutting the first few connections. This is something the API people would have to do.

              I thought I had added this information to the readme, but I’ve just notice that I hadn’t, so thanks for that, will add this piece of information.

              1 Reply Last reply Reply Quote 0
              • Y Offline
                yo-less Module Developer @Jopyth
                last edited by yo-less Oct 13, 2016, 5:13 PM Oct 13, 2016, 5:12 PM

                @Jopyth Thanks for your interest in my module. As it says in the license, all you have to do is include the copyright notice, should you decide to base your module on mine. Good luck with your module development :).

                Also, feel free to play around with it and submit a pull request, should you add additional features.

                Thanks as well for your ideas on improving the module. I had originally toyed with the idea of allowing custom module headers but then decided against it as the way it works right now, you automatically notice should you have entered the wrong stop id, which is something that happened to me from time to time when I was still developing the module. If some people feel the need to change the header, I could see myself revisiting the idea.

                The update timestamp might be interesting for some people as well, so I’ll consider implementing it. I wanted to have the module as uncluttered as possible and the more info you show, the easier it is to lose sight of what’s relevant.

                Thanks again for your thoughts :). It’s always nice to have some fresh ideas to include in further development stages.

                J 1 Reply Last reply Oct 14, 2016, 8:33 AM Reply Quote 0
                • J Offline
                  Jopyth Moderator @yo-less
                  last edited by Oct 14, 2016, 8:33 AM

                  @yo-less Thanks! And the cluttering is an important aspect, indeed. Should definitely be optional and that is why I would think a symbol is nice, for less space usage.

                  Helpful sticky: How to troubleshoot

                  1 Reply Last reply Reply Quote 0
                  • 4 Offline
                    4thaKids
                    last edited by Jun 18, 2021, 5:17 AM

                    @yo-less I installed your module, but it looks like, that there is an download issue. I will receive the information “loading” only.
                    What could be my problem?
                    thx in advance

                    1 Reply Last reply Reply Quote 0
                    • 1 / 1
                    • First post
                      Last post
                    Enjoying MagicMirror? Please consider a donation!
                    MagicMirror created by Michael Teeuw.
                    Forum managed by Sam, technical setup by Karsten.
                    This forum is using NodeBB as its core | Contributors
                    Contact | Privacy Policy