• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-Tado wrong units

Scheduled Pinned Locked Moved Troubleshooting
28 Posts 3 Posters 4.0k Views 4 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Offline
    sdetweil @Stoffbeuteluwe
    last edited by May 30, 2020, 3:52 PM

    @Stoffbeuteluwe I posted an issue to his repo
    https://github.com/WouterEekhout/MMM-Tado/issues/9

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    1 Reply Last reply Reply Quote 0
    • W Offline
      WouterEekhout
      last edited by May 30, 2020, 8:36 PM

      @Stoffbeuteluwe

      I cannot reproduce the problem. In my case the self.config.units reads out the units from the config.js correctly. If I add var self = this, then it will read out the defaults set in the MMM-Tado.js and not from the config.js.

      My config.js looks like the following:

      var config = {
      ...
      	units: "metric",
      ...
      	modules: [
      ...
      		{
      			module: 'MMM-Tado',
      			position: 'top_right',
      			header: 'My Home',
      			config: {
      				username: 'X',
      				password: 'X',
      				updateInterval: 300000,
      			}
      		},
      ...
      	]
      };
      
      S 1 Reply Last reply May 30, 2020, 9:40 PM Reply Quote 0
      • S Offline
        sdetweil @WouterEekhout
        last edited by May 30, 2020, 9:40 PM

        @WouterEekhout that is not how it works…

        at module startup time, before init is called, the MM module loader will take the module supplied defaults and merge on top the config.js config:{} section for the module. using Object.assign ({}, default, config())
        and CREATE and item in the module namespace called config… it is a replace config =
        Object.assign() is a replace operation, whatever was there before is replace with the same object from the

        // MM/js/module.js
        	setConfig: function (config) {
        		this.config = Object.assign({}, this.defaults, config);
        	},
        

        the statement above creates an empty object {}, then assigns on top the module defaults section,
        then assigns values from the config.js config object on top of those (replacing any same named items)

        your module does not HAVE a config object defined… it has a defaults object, which is not touched…

        the problem is at start time in your module
        self has not been explicitly set. so, you have NO idea where it is pointing, but this IS set,
        and this.config is the merged result from the setConfig function above…
        so, you stomp on (replace, not merge) the this.config object with whatever is pointed to by self.config.

        AFTER getDom() is called once (long after start) then self is set

        /// MMM-Tado.js
            // Override dom generator.
            getDom: function () {
                let self = this;
        

        now this and self point to the same thing, the instance of module which is MMM-Tado.js AND including the dynamically created (and over written in start) config object.

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • W Offline
          WouterEekhout
          last edited by WouterEekhout May 30, 2020, 9:59 PM May 30, 2020, 9:57 PM

          @sdetweil I don’t think we are on the same page. Your solution is not working for me, therefor I cannot reproduce it.

          I tested it by setting my units in the config.js as following:

          var config = {
          ...
             units: 'lipsum',
          ...
          }
          

          I add your recommendation and debug it:
          2d91064e-ad55-478b-9bb9-f5da377194df-image.png

          As you can see, the self.config.units is not ‘lipsum’.

          If I keep my code like it is now:
          7bdf2312-7cba-47db-910a-466b09598448-image.png

          As you can see now self.config.units contains ‘lipsum’. Also the output on the screen is correct (It shows the temp in fahrenheit, because it is not equal to ‘metric’).

          I might be overlooking something. But as far as I am seeing, it works correctly.

          S 1 Reply Last reply May 30, 2020, 10:36 PM Reply Quote 0
          • S Offline
            sdetweil @WouterEekhout
            last edited by sdetweil May 30, 2020, 10:46 PM May 30, 2020, 10:36 PM

            @WouterEekhout according to the doc

            https://docs.magicmirror.builders/development/core-module-file.html#available-module-instance-properties

            this.config	Boolean	The configuration of the module instance as set in the user's config.js file. This config will also contain the module's defaults if these properties are not over-written by the user config.
            

            and my experience matches this and depends on it.
            from my 2.11 system with your latest module installed
            config

            		{
                    module: 'MMM-Tado',
                    position: 'top_right', // This can be any of the regions.
                    config: {
                        username: 'your_tado_username',
                        password: 'your_tado_password',
                        updateInterval: 300000,
                        units:"freddy"
                    }
                }
            

            this.config
            this.config1.png

            self.config
            self.config1.png

            notice that self.config is THE mm config.js in object form and it HAS a ‘units’ value, so when the assignment happens
            this.config.units=self.config.units
            units will change from ‘freddy’ to ‘metric’

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • W Offline
              WouterEekhout
              last edited by May 31, 2020, 9:16 AM

              @sdetweil Thank you for the clarification. Now it is clear why there is miscommunication. I use the units from the general config settings: https://docs.magicmirror.builders/getting-started/configuration.html#general .

              To clarify my config looks like this:

              var config = {
              	address: "localhost", 
              	port: 8080,
              	ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1"],
              
              	language: "en",
              	timeFormat: 24,
              	units: "metric",
              
              	modules: [
              		{
              			module: 'MMM-Tado',
              			position: 'top_right',
              			header: 'My Home',
              			config: {
              				username: 'x',
              				password: 'x',
              				updateInterval: 300000,
              			}
              		},
              	]
              
              };
              

              Notice that the units-config is outside modules-config. And not in the module-config. I think this makes more sense. Because of this self.config.units does contain the correct value. I will update the readme about the units-config, so it will be more clear.

              S 1 Reply Last reply May 31, 2020, 11:52 AM Reply Quote 0
              • S Offline
                sdetweil @WouterEekhout
                last edited by sdetweil May 31, 2020, 11:54 AM May 31, 2020, 11:52 AM

                @WouterEekhout ok, but… i don’t think that is what the USER wanted… their system is in metric, but they wanted your module display to be Fahrenheit, so I would use some other varname, and check to see if they specified that, and use IT over the system value…

                or because u have it as a default, if u set it to some invalid value, then check if its what you allow,
                then if invalid, use system, otherwise allow users value…

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                1 Reply Last reply Reply Quote 0
                • W Offline
                  WouterEekhout
                  last edited by May 31, 2020, 12:28 PM

                  @sdetweil I disagree, it is unclear if the current config is not working or if he wanted a custom units setting for the app. @Stoffbeuteluwe Can you clarify if you wanted to set a different unit for the app?

                  S 1 Reply Last reply May 31, 2020, 12:54 PM Reply Quote 0
                  • S Offline
                    Stoffbeuteluwe Project Sponsor @WouterEekhout
                    last edited by May 31, 2020, 12:54 PM

                    @WouterEekhout I am from Germany and I need metric unit but Sam helped me to fix and now it’s working for me.
                    It would be cool to have the choice in module config. Metric or imperial
                    Thanks to you guys

                    S 1 Reply Last reply May 31, 2020, 12:55 PM Reply Quote 0
                    • S Offline
                      sdetweil @Stoffbeuteluwe
                      last edited by May 31, 2020, 12:55 PM

                      @Stoffbeuteluwe what is your main config.js units set to? up near address:

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      S 1 Reply Last reply May 31, 2020, 2:18 PM Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 1 / 3
                      1 / 3
                      • First post
                        9/28
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy