Any plan to replace "request" and "moment"?

[BKeyport]

@cowboysdude Been playing with changing over anyway (to luxon), and all I’ve been able to do for sure is make MM not come up at all.

There needs to be MUCH better documentation on how to build out with external modules. It don’t make sense.

[sdetweil]

@bkeyport explain more. externals are used in node_helper, and some can be used in module name.js as loaded by getScripts()

if the lib shows useage as a < script … />
link, then u can use it in getScripts

[BKeyport]

@sdetweil I’m trying to get luxon up and running.

Supports Node.js 6+. Install via NPM:

npm install --save luxon

const { DateTime } = require("luxon");

Do I need to use node_helper to get it going, then?

https://moment.github.io/luxon/#/install

[sdetweil]

@bkeyport require only works in node_helper

the doc also gives u a < script approach

still npm install
then getScripts to load the file from node_modules folder/luxon folder

the use in modulename.js as shown for browser

[BKeyport]

@sdetweil Oh, so I set up the require in node_helper, and use it accordingly in the main module script? Nice.

[sdetweil]

@bkeyport no. one OR the other

[BKeyport]

@sdetweil OK, I’m lost.

If Moment goes away, I’ll delete my modules.

[sdetweil]

@bkeyport if you don’t have a node_helper, the you use the getScripts approach

if u have both, then u have to do both

[BKeyport]

@sdetweil

I give up.

Suggestion for the main app -

Create a date-time service that hides what library you’re using. If you decide to replace the library in the future, you’ll need to update only one file.

That way, we don’t have to move at all - just convert from accessing moment directly to accessing the internal service.

In the meantime, I’m indeed dropping it.

[sdetweil]

@bkeyport I don’t understand dropping the library…

sadly its never that easy. code has to change.

as for the other.
can u do all you app in the browser side (module name.js)

if so then u load the new moment library with
npm install --save libname
and then (check syntax)

getScripts:
  return [ this.file("node_modules/libname/....")]
     // the file is whatever would be in the script tag

of u need to use node_helper, and need moment like stuff,

const ???? = require('libname')

if u need both, then u have to do both

[BKeyport]

Dropping it = Not going to bother until I have to.

[mumblebaj]

EDIT: Reference path to luxon.min.js
@bkeyport I think the following should work for you.
Add luxon.min.js to your project in the root of your project.
Then add the following to you project, I have used your MMM-Multimonth as an example project.

getScripts: function() {
              return[this.file("/node_modules/luxon/build/global/luxon.min.js")]
      },

Once added you should be able to use it like this:
In your project you have the following for moment:

monthTitle = moment().add(-1, "month").format("MMMM YYYY")

You an now do the following in luxon:

const luxMonth = luxon.DateTime.now().plus({month: -1}).toFormat("MMMM yyyy")

Hope this gives you a start in the right direction.

You can find luxon.min.js here

[sdetweil]

@mumblebaj don’t copy the file to the root of your module. just use it from the linstalled location.

[mumblebaj]

@sdetweil I have now found it in the /node_modules/luxon/build/global

I should have searched some more. :beaming_face_with_smiling_eyes:
But, yes, you are correct. You can just point to that location.

[BKeyport]

@mumblebaj Yeah, I got irritated enough that it wasn’t working I realized I was being a total idiot and not pointing at the JS correctly. Why the hell it’s buried so deep, well…

[sdetweil]

@bkeyport

why is it buried so deep?

cause everybody does their own thing

[BKeyport]

@sdetweil heh.

Now, I’m down to the javascript exploding bug. A <= B == Crash. 😢

Oh well. Shelved.

I’ll tackle it when/if the main switches.

[mumblebaj]

@bkeyport You doing date comparison?

[mumblebaj]

@bkeyport Can you adapt the following and see if it works for you?

var startDate = DateTime.fromISO("2021-09-06T17:22:49.916+02:00");
var someDate = DateTime.fromISO("2021-03-06T17:22:49.916+02:00");
var result = startDate.startOf("day") <= someDate.startOf("day");
console.log("Date Comparison Result: ", result) // => true;

[BKeyport]

@mumblebaj I’ll play with it later, We’ve hijacked the thread enough.