remoteFile in compliments module

jcorraliza

Hi there, just want to add that I am also unable to get the remoteFile to work. I have it configured as specified above using the currentweather items, but my mirror still shows the default phrases.

strawberry 3.141

@jcorraliza can you show your config for compliments module and the path where you placed the file?

jcorraliza

@strawberry-3.141 Sure, I placed the compliments.json file in ~/MagicMirror/modules/default/compliments directory.

My config.js is as follows:

 {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                remoteFile: 'compliments.json'
                        }
},

My compliments.json file is set up with currentweather arrays:

{
	"day_sunny" : [
	        "The sun is shining today!",
        	"It\'s such a beautiful day",
		"It\'s gorgeous outside, go play!"
    	],
    	"day_cloudy" : [
		"It\'s cloudy out there, but no meatballs",
		"It may be cloudy, but it\'s still nice out!",
		"The sun is hiding right now"
    	],
	"cloudy" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"cloudy_windy" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
	],
	"showers" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"rain" : [
        	"Take your umbrella with you.",
        	"It's wet out there, drive safe!",
	        "It's rainy outside, but you brighten my day."
    	],
	"thunderstorm" : [
	        "Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"fog" : [
	        "Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
   	],
    	"night_clear" : [
  		"You made someone smile today, I know it.",
       		"You are making a difference.",
        	"The day was better for your efforts."
    	],
	"night_cloudy" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"night_showers" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"night_rain" : [
	        "Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
    	],
	"night_thunderstorm" : [
        	"It\'s a stormy night, don\'t be scared",
        	"Thunderstorms tonight, Oliver\'s covering his ears"
    	],
	"night_alt_cloudy_windy" : [
        	"Good morning, sunshine!",
        	"Who needs coffee when you have your smile?",
        	"Go get 'em, Tiger!"
 	]
}

I started filling in custom messages, then decided to copy/paste them all just in case it didn’t work. See anything I’m doing wrong? Thanks!

schlachtkreuzer6

@strawberry-3.141 Hey, hm i think something is wrong^^

pi@MagicMirror:~ $ npm start dev
npm ERR! Linux 4.4.37-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! path /home/pi/package.json
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/npm-debug.log

yawns

@jcorraliza
Hi, I just tried on my computer …

snippit from my config.js

{
	module: 'compliments',
	position: 'lower_third',
	config: {
		remoteFile: 'compliments.json'
	}
},

my compliments.json

{
    "morning" : [
        "heyho"
    ],
    "afternoon" : [
        "home early?"
    ],
    "evening" : [
        "finally home"
    ],
	"fog" : [
		"fog, oh no :("             
	]
}

The compliments.json file is located in ~/MagicMirror/modules/default/compliments
Three things to mention:

Of course you need to use the default “currentweather” module
You need to run the new updated MagicMirror version. Otherwise compliments and currentweather are not interacting
There is a delay loading the compliments file. I added some debug output to track that and as you see MagicMirror starts with default values and takes 30 seconds to load and verify your remote file.

yawns

@schlachtkreuzer6
you are in your home directory, not in your MagicMirror folder.
Run cd MagicMirror first

schlachtkreuzer6

@yawns oh, okay then i get this:

pi@MagicMirror:~/MagicMirror $ npm start dev

> magicmirror@2.1.0 start /home/pi/MagicMirror
> electron js/electron.js "dev"


npm ERR! Linux 4.4.37-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! magicmirror@2.1.0 start: `electron js/electron.js "dev"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the magicmirror package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     electron js/electron.js "dev"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs magicmirror
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls magicmirror
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/MagicMirror/npm-debug.log

npm-debug.log

  GNU nano 2.2.6                                                                 File: npm-debug.log

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start', 'dev' ]
2 info using npm@3.10.9
3 info using node@v6.9.2
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle magicmirror@2.1.0~prestart: magicmirror@2.1.0
6 silly lifecycle magicmirror@2.1.0~prestart: no script for prestart, continuing
7 info lifecycle magicmirror@2.1.0~start: magicmirror@2.1.0
8 verbose lifecycle magicmirror@2.1.0~start: unsafe-perm in lifecycle true
9 verbose lifecycle magicmirror@2.1.0~start: PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/pi/MagicMirror/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
10 verbose lifecycle magicmirror@2.1.0~start: CWD: /home/pi/MagicMirror
11 silly lifecycle magicmirror@2.1.0~start: Args: [ '-c', 'electron js/electron.js "dev"' ]
12 silly lifecycle magicmirror@2.1.0~start: Returned: code: 1  signal: null
13 info lifecycle magicmirror@2.1.0~start: Failed to exec start script
14 verbose stack Error: magicmirror@2.1.0 start: `electron js/electron.js "dev"`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:877:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid magicmirror@2.1.0
16 verbose cwd /home/pi/MagicMirror
17 error Linux 4.4.37-v7+
18 error argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
19 error node v6.9.2
20 error npm  v3.10.9
21 error code ELIFECYCLE
22 error magicmirror@2.1.0 start: `electron js/electron.js "dev"`
22 error Exit status 1
23 error Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the magicmirror package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     electron js/electron.js "dev"
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs magicmirror
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls magicmirror
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

DvdEnde

Friends,

using version 2.1.0 you must have the remoteFile within the configuration of the compliments.js.

the file should start like this:

defaults: {
	updateInterval: 30000,
	remoteFile: 'put your file here',
	fadeSpeed: 4000
},

it is only working with a local file.

in my config/config.js i did not change anything for compliments module.

yawns

@DvdEnde
no, this information is wrong. And you should avoid modifying module files.
Try what I have written above, it is working fine

DvdEnde

@yawns Sorry but your option did not work for me.
Also please check the original compliment.js file:
https://github.com/MichMich/MagicMirror/blob/develop/modules/default/compliments/compliments.js
it is standard prepared there.

Please also check line 50:
if (this.config.remoteFile != null) {

At first I also thought this would be the major config file, but it is not. Its the module.
If you console.log(this.config) it will give you an object like this. All information from the compliment.js

    updateInterval: 30000,
    remoteFile: null,
    fadeSpeed: 4000

That is why i think @schlachtkreuzer6 should give this a try.
You have also the latest version?

I understand that modules should not be changed.

Just trying to help.
Please do correct me if I am wrong!

strawberry 3.141

@DvdEnde the part from the config in the config.js overwrites the values in default with Object.assign()

so when you define remoteFile in the config.js the null value is overwritten

yawns

@DvdEnde Please don’t get me wrong, but this is basic javascript.

this.config.remoteFile != null checks if the variable “remoteFile” is set in your config file. Afterwards you only have two scenarios:

the variable is not set -> this if clause fails and no remote file is loaded.
the variable is set to any value -> this if clause is true and the function complimentFile() is called, which tries to load the file defined in your config file, in my case “compliments.json”.

If loading the remote file fails you see an error message in console output of your browser. Otherwise it does not produce any log.

DvdEnde

@yawns
Don’t worry, i know it is basic javascript.
@strawberry-3-141
i thought so too, but it is NOT

I just now changed the compliment.js (and deleted the remoteFile completly from here) and added this within the config.

My object is simple

    fadeSpeed: 4000
    updateInterval: 30000

On line 33 console.log(this.config.remoteFile) = undefined

jcorraliza

@yawns OK I created a compliments_test.json file and pasted your example into it and it worked. It looks like it just doesn’t work with the currentweather objects in my compliments.json file for some reason. Do I need to nest the currentweather objects within the morning, afternoon, and evening arrays perhaps?

schlachtkreuzer6

@jcorraliza post your config.js and your remotefile pls

jcorraliza

@schlachtkreuzer6 said in remoteFile in compliments module:

@jcorraliza post your config.js and your remotefile pls

Hi there, I posted them a few posts up. It works with the time of day objects, but not with the currentweather objects in my .json file. I’m using v2.1.0, dev branch, and I’m using the currentweather default module.

schlachtkreuzer6

@DvdEnde MM is up to date and every module i git pull the latest version, nope it says it´s a invalid .json in the MM-Admin-Interface. i just can not use this config @yawns post:

{
	module: 'compliments',
	position: 'lower_third',
	config: {
		remoteFile: 'compliments.json'
	}
},

if i try to start MM, it´s showing up, that the config is broken. even when i adjust it to the MM-Admin code:

{
	"module": "compliments",
	"position": "lower_third",
	"config": {
		"remoteFile": "compliments.json"
	}
},

I´m not in javascript or anything coding. But nothing worked for me. maybe my system is somehow broken…

DvdEnde

@schlachtkreuzer6
The way you do it is the way it should be.
BUT i also cannot get it to work like this.

please try following:
Open config/config.js and remove

"config": {
		"remoteFile": "compliments.json"
	}

Then open your compliments.js and check:

defaults: {
		updateInterval: 30000,
		remoteFile: null,
		fadeSpeed: 4000
	},

change remoteFile to a useable name:

defaults: {
		updateInterval: 30000,
		remoteFile: "~/path to your/compliments.json",
		fadeSpeed: 4000
	},

then restart MM (or restart the PI)

schlachtkreuzer6

@DvdEnde i think my mirror has it´s own brain ^^ so i changed it like your post above. but MM just showing the default compliments. I don´t know whats wrong, but i think i will rebuild MM from the ground.

DvdEnde

#@schlachtkreuzer6
If MM is showing the default compliments, where are they?
Please post the complete defaults from your compliments.js AND
the complete part of the json for compliments from your config.js.

also post your jsonfile where to get your custom compliments.

maybe we all misunderstand you?