MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    remoteFile in compliments module

    Scheduled Pinned Locked Moved Troubleshooting
    71 Posts 14 Posters 88.2k Views 15 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • strawberry 3.141S Offline
      strawberry 3.141 Project Sponsor Module Developer @jcorraliza
      last edited by

      @jcorraliza can you show your config for compliments module and the path where you placed the file?

      Please create a github issue if you need help, so I can keep track

      J 1 Reply Last reply Reply Quote 0
      • J Offline
        jcorraliza @strawberry 3.141
        last edited by

        @strawberry-3.141 Sure, I placed the compliments.json file in ~/MagicMirror/modules/default/compliments directory.

        My config.js is as follows:

         {
                                module: 'compliments',
                                position: 'lower_third',
                                config: {
                                        remoteFile: 'compliments.json'
                                }
        },
        

        My compliments.json file is set up with currentweather arrays:

        {
        	"day_sunny" : [
        	        "The sun is shining today!",
                	"It\'s such a beautiful day",
        		"It\'s gorgeous outside, go play!"
            	],
            	"day_cloudy" : [
        		"It\'s cloudy out there, but no meatballs",
        		"It may be cloudy, but it\'s still nice out!",
        		"The sun is hiding right now"
            	],
        	"cloudy" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"cloudy_windy" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
        	],
        	"showers" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"rain" : [
                	"Take your umbrella with you.",
                	"It's wet out there, drive safe!",
        	        "It's rainy outside, but you brighten my day."
            	],
        	"thunderstorm" : [
        	        "Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"fog" : [
        	        "Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
           	],
            	"night_clear" : [
          		"You made someone smile today, I know it.",
               		"You are making a difference.",
                	"The day was better for your efforts."
            	],
        	"night_cloudy" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"night_showers" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"night_rain" : [
        	        "Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
            	],
        	"night_thunderstorm" : [
                	"It\'s a stormy night, don\'t be scared",
                	"Thunderstorms tonight, Oliver\'s covering his ears"
            	],
        	"night_alt_cloudy_windy" : [
                	"Good morning, sunshine!",
                	"Who needs coffee when you have your smile?",
                	"Go get 'em, Tiger!"
         	]
        }
        

        I started filling in custom messages, then decided to copy/paste them all just in case it didn’t work. See anything I’m doing wrong? Thanks!

        yawnsY 1 Reply Last reply Reply Quote 0
        • schlachtkreuzer6S Offline
          schlachtkreuzer6 @strawberry 3.141
          last edited by

          @strawberry-3.141 Hey, hm i think something is wrong^^

          pi@MagicMirror:~ $ npm start dev
          npm ERR! Linux 4.4.37-v7+
          npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
          npm ERR! node v6.9.2
          npm ERR! npm  v3.10.9
          npm ERR! path /home/pi/package.json
          npm ERR! code ENOENT
          npm ERR! errno -2
          npm ERR! syscall open
          
          npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
          npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
          npm ERR! enoent This is most likely not a problem with npm itself
          npm ERR! enoent and is related to npm not being able to find a file.
          npm ERR! enoent
          
          npm ERR! Please include the following file with any support request:
          npm ERR!     /home/pi/npm-debug.log
          
          yawnsY 1 Reply Last reply Reply Quote 0
          • yawnsY Offline
            yawns Moderator @jcorraliza
            last edited by

            @jcorraliza
            Hi, I just tried on my computer …

            snippit from my config.js

            {
            	module: 'compliments',
            	position: 'lower_third',
            	config: {
            		remoteFile: 'compliments.json'
            	}
            },
            
            

            my compliments.json

            {
                "morning" : [
                    "heyho"
                ],
                "afternoon" : [
                    "home early?"
                ],
                "evening" : [
                    "finally home"
                ],
            	"fog" : [
            		"fog, oh no :("             
            	]
            }
            

            The compliments.json file is located in ~/MagicMirror/modules/default/compliments
            Three things to mention:

            1. Of course you need to use the default “currentweather” module
            2. You need to run the new updated MagicMirror version. Otherwise compliments and currentweather are not interacting
            3. There is a delay loading the compliments file. I added some debug output to track that and as you see MagicMirror starts with default values and takes 30 seconds to load and verify your remote file.0_1483870239034_compliments.PNG
            J 1 Reply Last reply Reply Quote 1
            • yawnsY Offline
              yawns Moderator @schlachtkreuzer6
              last edited by

              @schlachtkreuzer6
              you are in your home directory, not in your MagicMirror folder.
              Run cd MagicMirror first

              schlachtkreuzer6S 1 Reply Last reply Reply Quote 1
              • schlachtkreuzer6S Offline
                schlachtkreuzer6 @yawns
                last edited by schlachtkreuzer6

                @yawns oh, okay then i get this:

                pi@MagicMirror:~/MagicMirror $ npm start dev
                
                > magicmirror@2.1.0 start /home/pi/MagicMirror
                > electron js/electron.js "dev"
                
                
                npm ERR! Linux 4.4.37-v7+
                npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
                npm ERR! node v6.9.2
                npm ERR! npm  v3.10.9
                npm ERR! code ELIFECYCLE
                npm ERR! magicmirror@2.1.0 start: `electron js/electron.js "dev"`
                npm ERR! Exit status 1
                npm ERR!
                npm ERR! Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'.
                npm ERR! Make sure you have the latest version of node.js and npm installed.
                npm ERR! If you do, this is most likely a problem with the magicmirror package,
                npm ERR! not with npm itself.
                npm ERR! Tell the author that this fails on your system:
                npm ERR!     electron js/electron.js "dev"
                npm ERR! You can get information on how to open an issue for this project with:
                npm ERR!     npm bugs magicmirror
                npm ERR! Or if that isn't available, you can get their info via:
                npm ERR!     npm owner ls magicmirror
                npm ERR! There is likely additional logging output above.
                
                npm ERR! Please include the following file with any support request:
                npm ERR!     /home/pi/MagicMirror/npm-debug.log
                

                npm-debug.log

                  GNU nano 2.2.6                                                                 File: npm-debug.log
                
                0 info it worked if it ends with ok
                1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start', 'dev' ]
                2 info using npm@3.10.9
                3 info using node@v6.9.2
                4 verbose run-script [ 'prestart', 'start', 'poststart' ]
                5 info lifecycle magicmirror@2.1.0~prestart: magicmirror@2.1.0
                6 silly lifecycle magicmirror@2.1.0~prestart: no script for prestart, continuing
                7 info lifecycle magicmirror@2.1.0~start: magicmirror@2.1.0
                8 verbose lifecycle magicmirror@2.1.0~start: unsafe-perm in lifecycle true
                9 verbose lifecycle magicmirror@2.1.0~start: PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/pi/MagicMirror/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
                10 verbose lifecycle magicmirror@2.1.0~start: CWD: /home/pi/MagicMirror
                11 silly lifecycle magicmirror@2.1.0~start: Args: [ '-c', 'electron js/electron.js "dev"' ]
                12 silly lifecycle magicmirror@2.1.0~start: Returned: code: 1  signal: null
                13 info lifecycle magicmirror@2.1.0~start: Failed to exec start script
                14 verbose stack Error: magicmirror@2.1.0 start: `electron js/electron.js "dev"`
                14 verbose stack Exit status 1
                14 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
                14 verbose stack     at emitTwo (events.js:106:13)
                14 verbose stack     at EventEmitter.emit (events.js:191:7)
                14 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
                14 verbose stack     at emitTwo (events.js:106:13)
                14 verbose stack     at ChildProcess.emit (events.js:191:7)
                14 verbose stack     at maybeClose (internal/child_process.js:877:16)
                14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
                15 verbose pkgid magicmirror@2.1.0
                16 verbose cwd /home/pi/MagicMirror
                17 error Linux 4.4.37-v7+
                18 error argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
                19 error node v6.9.2
                20 error npm  v3.10.9
                21 error code ELIFECYCLE
                22 error magicmirror@2.1.0 start: `electron js/electron.js "dev"`
                22 error Exit status 1
                23 error Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'.
                23 error Make sure you have the latest version of node.js and npm installed.
                23 error If you do, this is most likely a problem with the magicmirror package,
                23 error not with npm itself.
                23 error Tell the author that this fails on your system:
                23 error     electron js/electron.js "dev"
                23 error You can get information on how to open an issue for this project with:
                23 error     npm bugs magicmirror
                23 error Or if that isn't available, you can get their info via:
                23 error     npm owner ls magicmirror
                23 error There is likely additional logging output above.
                24 verbose exit [ 1, true ]
                
                1 Reply Last reply Reply Quote 0
                • D Offline
                  DvdEnde
                  last edited by DvdEnde

                  Friends,

                  using version 2.1.0 you must have the remoteFile within the configuration of the compliments.js.

                  the file should start like this:

                  defaults: {
                  	updateInterval: 30000,
                  	remoteFile: 'put your file here',
                  	fadeSpeed: 4000
                  },
                  

                  it is only working with a local file.

                  in my config/config.js i did not change anything for compliments module.

                  yawnsY 1 Reply Last reply Reply Quote 0
                  • yawnsY Offline
                    yawns Moderator @DvdEnde
                    last edited by

                    @DvdEnde
                    no, this information is wrong. And you should avoid modifying module files.
                    Try what I have written above, it is working fine

                    D 1 Reply Last reply Reply Quote 1
                    • D Offline
                      DvdEnde @yawns
                      last edited by DvdEnde

                      @yawns Sorry but your option did not work for me.
                      Also please check the original compliment.js file:
                      https://github.com/MichMich/MagicMirror/blob/develop/modules/default/compliments/compliments.js
                      it is standard prepared there.

                      Please also check line 50:
                      if (this.config.remoteFile != null) {

                      At first I also thought this would be the major config file, but it is not. Its the module.
                      If you console.log(this.config) it will give you an object like this. All information from the compliment.js

                          updateInterval: 30000,
                          remoteFile: null,
                          fadeSpeed: 4000
                      

                      That is why i think @schlachtkreuzer6 should give this a try.
                      You have also the latest version?

                      I understand that modules should not be changed.

                      Just trying to help.
                      Please do correct me if I am wrong!

                      strawberry 3.141S schlachtkreuzer6S 2 Replies Last reply Reply Quote 0
                      • strawberry 3.141S Offline
                        strawberry 3.141 Project Sponsor Module Developer @DvdEnde
                        last edited by

                        @DvdEnde the part from the config in the config.js overwrites the values in default with Object.assign()

                        so when you define remoteFile in the config.js the null value is overwritten

                        Please create a github issue if you need help, so I can keep track

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 5
                        • 6
                        • 7
                        • 8
                        • 2 / 8
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy