Read the statement by Michael Teeuw here.
remoteFile in compliments module
-
@skr
cd ~/MagicMirror git fetch git checkout develop npm install -
hey,
on the development branch it doesnt work either (git confirms i’m really on the dev branch and files also look like the ones on github). it defaults to the standard values in the module and seems to ignore the remote file argument – but I really dont know javascript (and lack the time atm to get into it), so cannot really debug it. does anyone have it up and running, just to make sure that I’m doing something wrong?
thanks!
Steffen -
@skr I have it running, but then again I developed the remote file capability. So “it works on my machine” is accurate, but not exactly helpful. :)
One thing I was not able to get working properly was making the array names work the same way between the
config.jsand the external file. You must surround the array names (morning, evening, afternoon) with quotes in the external file. This is different then how work in theconfig.js. This catches a few people. Check out the compliments module documentation for examples.If that’s not your issue, post the compliments config from your
config.jsand your external file here and I’ll take a look at it. -
@bhepler HOW???
@schlachtkreuzer6 said in Compliments - remoteFile - How to?!:
Hey guys, i need some help with the remoteFile for the compliments. I tried this:
module: 'compliments', position: 'lower_third', config: { updateInterval: 15000, compliments: { remoteFile: '~/MagicMirror/modules/default/compliments/remote_compliments.json', morning: [ 'Guten Morgen!', 'Wie hast du geschlafen?', 'Ich wünsche dir einen schönen Tag!' ], ...but it´s not working.
Content of remote_compliments.json:
{ "morning" : [ "Du siehst aber gut aus heute !", "Gut geschlafen ?", "Moin, Moin...." ], "afternoon" : [ "Ab Fussball spielen !", "Lass uns auf den Abend vorbereiten....", "Musik hören ?" ], "evening" : [ "Einen Cocktail ?", "Wow, Du bist aber heiss heute...", "Wollen wir heute abend weggehen ?" ] } -
@schlachtkreuzer6 your json file looks good to me, but i would try to change your config
{ module: 'compliments', position: 'lower_third', config: { updateInterval: 15000, remoteFile: 'remote_compliments.json' } }- the remoteFile has to be in the config object and not nested in the compliments object
- it makes no sense to have another compliments in the config, because those will be completely overwritten by using a remoteFile
- after a look in the code, it uses
this.file(this.config.remoteFile)which will generate the correct path, so if you place the remotefile in the compliments directory you should only have to put the name with the extension in there.
-
@strawberry-3.141 thanks for your advice, i tried it but nope ^^
If i only use the remote file, MM stuck loading the other modules down blow. so first, alert, cock, clalendar, compliments but the modules later on are not showing up.{ "module": "compliments", "position": "lower_third", "config": { "compliments": { "remoteFile": "remote_compliments.json", "morning": [ "Guten Morgen!", "Wie hast du geschlafen?", "Ich wünsche dir einen schönen Tag!" ], "afternoon": [ "Guten Tag!", "Du schaust gut aus!", "Wie war dein Tag!" ], "evening": [ "Guten Abend!", "Na wie war dein Tag?", "Du warst heute fleßig!" ] }, "updateInterval": 15000 } }remote_compliments.json
"morning": [ "Test1!", "Test2?", "Test3!" ], "afternoon": [ "Test4!", "Test5!", "Test6!" ], "evening": [ "Test7!", "Test8?", "Test9!" ] -
@schlachtkreuzer6 do you get any errors in the electron console?
-
@strawberry-3.141 how to open the electron console to see those errors? I’m not an expert, sry
-
@schlachtkreuzer6 either start with
npm start devor presscmd+shift+iduring runtimePlease create a github issue if you need help, so I can keep track
-
Hi there, just want to add that I am also unable to get the remoteFile to work. I have it configured as specified above using the currentweather items, but my mirror still shows the default phrases.
-
@jcorraliza can you show your config for compliments module and the path where you placed the file?
-
@strawberry-3.141 Sure, I placed the compliments.json file in ~/MagicMirror/modules/default/compliments directory.
My config.js is as follows:
{ module: 'compliments', position: 'lower_third', config: { remoteFile: 'compliments.json' } },My compliments.json file is set up with currentweather arrays:
{ "day_sunny" : [ "The sun is shining today!", "It\'s such a beautiful day", "It\'s gorgeous outside, go play!" ], "day_cloudy" : [ "It\'s cloudy out there, but no meatballs", "It may be cloudy, but it\'s still nice out!", "The sun is hiding right now" ], "cloudy" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "cloudy_windy" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "showers" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "rain" : [ "Take your umbrella with you.", "It's wet out there, drive safe!", "It's rainy outside, but you brighten my day." ], "thunderstorm" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "fog" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "night_clear" : [ "You made someone smile today, I know it.", "You are making a difference.", "The day was better for your efforts." ], "night_cloudy" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "night_showers" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "night_rain" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ], "night_thunderstorm" : [ "It\'s a stormy night, don\'t be scared", "Thunderstorms tonight, Oliver\'s covering his ears" ], "night_alt_cloudy_windy" : [ "Good morning, sunshine!", "Who needs coffee when you have your smile?", "Go get 'em, Tiger!" ] }I started filling in custom messages, then decided to copy/paste them all just in case it didn’t work. See anything I’m doing wrong? Thanks!
-
@strawberry-3.141 Hey, hm i think something is wrong^^
pi@MagicMirror:~ $ npm start dev npm ERR! Linux 4.4.37-v7+ npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev" npm ERR! node v6.9.2 npm ERR! npm v3.10.9 npm ERR! path /home/pi/package.json npm ERR! code ENOENT npm ERR! errno -2 npm ERR! syscall open npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json' npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json' npm ERR! enoent This is most likely not a problem with npm itself npm ERR! enoent and is related to npm not being able to find a file. npm ERR! enoent npm ERR! Please include the following file with any support request: npm ERR! /home/pi/npm-debug.log -
@jcorraliza
Hi, I just tried on my computer …snippit from my config.js
{ module: 'compliments', position: 'lower_third', config: { remoteFile: 'compliments.json' } },my compliments.json
{ "morning" : [ "heyho" ], "afternoon" : [ "home early?" ], "evening" : [ "finally home" ], "fog" : [ "fog, oh no :(" ] }The compliments.json file is located in ~/MagicMirror/modules/default/compliments
Three things to mention:- Of course you need to use the default “currentweather” module
- You need to run the new updated MagicMirror version. Otherwise compliments and currentweather are not interacting
- There is a delay loading the compliments file. I added some debug output to track that and as you see MagicMirror starts with default values and takes 30 seconds to load and verify your remote file.
-
@schlachtkreuzer6
you are in your home directory, not in your MagicMirror folder.
Runcd MagicMirrorfirst -
@yawns oh, okay then i get this:
pi@MagicMirror:~/MagicMirror $ npm start dev > magicmirror@2.1.0 start /home/pi/MagicMirror > electron js/electron.js "dev" npm ERR! Linux 4.4.37-v7+ npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev" npm ERR! node v6.9.2 npm ERR! npm v3.10.9 npm ERR! code ELIFECYCLE npm ERR! magicmirror@2.1.0 start: `electron js/electron.js "dev"` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the magicmirror package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! electron js/electron.js "dev" npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs magicmirror npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls magicmirror npm ERR! There is likely additional logging output above. npm ERR! Please include the following file with any support request: npm ERR! /home/pi/MagicMirror/npm-debug.lognpm-debug.log
GNU nano 2.2.6 File: npm-debug.log 0 info it worked if it ends with ok 1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start', 'dev' ] 2 info using npm@3.10.9 3 info using node@v6.9.2 4 verbose run-script [ 'prestart', 'start', 'poststart' ] 5 info lifecycle magicmirror@2.1.0~prestart: magicmirror@2.1.0 6 silly lifecycle magicmirror@2.1.0~prestart: no script for prestart, continuing 7 info lifecycle magicmirror@2.1.0~start: magicmirror@2.1.0 8 verbose lifecycle magicmirror@2.1.0~start: unsafe-perm in lifecycle true 9 verbose lifecycle magicmirror@2.1.0~start: PATH: /usr/lib/node_modules/npm/bin/node-gyp-bin:/home/pi/MagicMirror/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games 10 verbose lifecycle magicmirror@2.1.0~start: CWD: /home/pi/MagicMirror 11 silly lifecycle magicmirror@2.1.0~start: Args: [ '-c', 'electron js/electron.js "dev"' ] 12 silly lifecycle magicmirror@2.1.0~start: Returned: code: 1 signal: null 13 info lifecycle magicmirror@2.1.0~start: Failed to exec start script 14 verbose stack Error: magicmirror@2.1.0 start: `electron js/electron.js "dev"` 14 verbose stack Exit status 1 14 verbose stack at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16) 14 verbose stack at emitTwo (events.js:106:13) 14 verbose stack at EventEmitter.emit (events.js:191:7) 14 verbose stack at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14) 14 verbose stack at emitTwo (events.js:106:13) 14 verbose stack at ChildProcess.emit (events.js:191:7) 14 verbose stack at maybeClose (internal/child_process.js:877:16) 14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) 15 verbose pkgid magicmirror@2.1.0 16 verbose cwd /home/pi/MagicMirror 17 error Linux 4.4.37-v7+ 18 error argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev" 19 error node v6.9.2 20 error npm v3.10.9 21 error code ELIFECYCLE 22 error magicmirror@2.1.0 start: `electron js/electron.js "dev"` 22 error Exit status 1 23 error Failed at the magicmirror@2.1.0 start script 'electron js/electron.js "dev"'. 23 error Make sure you have the latest version of node.js and npm installed. 23 error If you do, this is most likely a problem with the magicmirror package, 23 error not with npm itself. 23 error Tell the author that this fails on your system: 23 error electron js/electron.js "dev" 23 error You can get information on how to open an issue for this project with: 23 error npm bugs magicmirror 23 error Or if that isn't available, you can get their info via: 23 error npm owner ls magicmirror 23 error There is likely additional logging output above. 24 verbose exit [ 1, true ] -
Friends,
using version 2.1.0 you must have the remoteFile within the configuration of the compliments.js.
the file should start like this:
defaults: { updateInterval: 30000, remoteFile: 'put your file here', fadeSpeed: 4000 },it is only working with a local file.
in my config/config.js i did not change anything for compliments module.
-
@DvdEnde
no, this information is wrong. And you should avoid modifying module files.
Try what I have written above, it is working fine -
@yawns Sorry but your option did not work for me.
Also please check the original compliment.js file:
https://github.com/MichMich/MagicMirror/blob/develop/modules/default/compliments/compliments.js
it is standard prepared there.Please also check line 50:
if (this.config.remoteFile != null) {At first I also thought
thiswould be the major config file, but it is not. Its the module.
If you console.log(this.config) it will give you an object like this. All information from the compliment.jsupdateInterval: 30000, remoteFile: null, fadeSpeed: 4000That is why i think @schlachtkreuzer6 should give this a try.
You have also the latest version?I understand that modules should not be changed.
Just trying to help.
Please do correct me if I am wrong! -
@DvdEnde the part from the config in the config.js overwrites the values in default with
Object.assign()so when you define
remoteFilein the config.js thenullvalue is overwritten
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login