Any plan to replace "request" and "moment"?

BKeyport

@mmrize said in Any plan to replace "request" and "moment"?:

Once (yesterday), I’ve tried to rewrite clock module and calendar module
without momentjs or any other 3rd party library, only with Date and Intl.

The start was not so bad. I could rewrite many features with only Date and Intl.
Where I stuck was the showWeek config feature. It has to show the ordinal number of weeks of the year. To calculate ISOweek is not difficult. But in some areas, like the US. they never use the ISO system. damn!. To calculate the conventional US week number, additional pieces of information are needed. (read this.) Current Intl has not yet that feature. I’m waiting for Temporal and enhanced Intl releasing.

Where I’m getting stuck with Luxon is basic comparision of dates:

Is this time the same or before that time? 
Moment: m1.isSameOrBefore(m2) (works) 
Luxon:  dt1 <= dt2 (Crashes jsfiddle)

and querying luxon for the locale’s weekday strings is always returning Monday as first, even though it will treat the week correctly otherwise.

luxon.info.weekdays('short') == Mon

BKeyport

@mmrize said in Any plan to replace "request" and "moment"?:

@sdetweil said in Any plan to replace "request" and "moment"?:

what day of the week is 1/1, subtract that from 7, and then that is the start of the weekly cycle.

ISOWeek is easy. Conventional week is the problem.

For example, in the United States, Sunday is the first day of the week. The week with January 1st in it is the first week of the year.

In France, Monday is the first day of the week, and the week with January 4th is the first week of the year. It means January 1st could be the last week of the last year sometimes. And Jan. 10th could be the first week in certain year.

And in other countries, there is also their own rule.

This might be important in some European countries, because they use week number in real life (“my vacation ends 23. Weeks“)

Moment handles this automatically. Everyone else, not so much.

0m4r

@bkeyport many do, and you are not alone.
But how many people are running MM in a safari browser?

I guess this is the relevant point here :)

BKeyport

@0m4r When I’m testing something, I’ll load it up on my local machine, which is a Mac, and yes, I use Safari. :)

0m4r

@bkeyport same for me, even tho I am aware like 99% of MM users are running it out of a raspberry pi with a Chromium browser.
That is the reason I say the main focus could be on Chromium-based browsers rather than others.

cowboysdude

I’m using Brave which is Chrome based without all the tracking and such ;)

0m4r

@cowboysdude technically it is based on Chromium (https://www.chromium.org/).

cowboysdude

@bkeyport I wouldn’t worry about it. Moment will be around for a while. Easy to use and yes you can add it to your own package json file and still use it.

Request…not so much LOL

cowboysdude

@0m4r meh either way LOL

BKeyport

@cowboysdude Been playing with changing over anyway (to luxon), and all I’ve been able to do for sure is make MM not come up at all.

There needs to be MUCH better documentation on how to build out with external modules. It don’t make sense.

sdetweil

@bkeyport explain more. externals are used in node_helper, and some can be used in module name.js as loaded by getScripts()

if the lib shows useage as a < script … />
link, then u can use it in getScripts

BKeyport

@sdetweil I’m trying to get luxon up and running.

Supports Node.js 6+. Install via NPM:

npm install --save luxon

const { DateTime } = require("luxon");

Do I need to use node_helper to get it going, then?

https://moment.github.io/luxon/#/install

sdetweil

@bkeyport require only works in node_helper

the doc also gives u a < script approach

still npm install
then getScripts to load the file from node_modules folder/luxon folder

the use in modulename.js as shown for browser

BKeyport

@sdetweil Oh, so I set up the require in node_helper, and use it accordingly in the main module script? Nice.

sdetweil

@bkeyport no. one OR the other

BKeyport

@sdetweil OK, I’m lost.

If Moment goes away, I’ll delete my modules.

sdetweil

@bkeyport if you don’t have a node_helper, the you use the getScripts approach

if u have both, then u have to do both

BKeyport

@sdetweil

I give up.

Suggestion for the main app -

Create a date-time service that hides what library you’re using. If you decide to replace the library in the future, you’ll need to update only one file.

That way, we don’t have to move at all - just convert from accessing moment directly to accessing the internal service.

In the meantime, I’m indeed dropping it.

sdetweil

@bkeyport I don’t understand dropping the library…

sadly its never that easy. code has to change.

as for the other.
can u do all you app in the browser side (module name.js)

if so then u load the new moment library with
npm install --save libname
and then (check syntax)

getScripts:
  return [ this.file("node_modules/libname/....")]
     // the file is whatever would be in the script tag

of u need to use node_helper, and need moment like stuff,

const ???? = require('libname')

if u need both, then u have to do both

BKeyport

Dropping it = Not going to bother until I have to.