MMM-doomsDay - The countdown module,

Mykle1

I hate to be the bearer of bad news, but as of this morning, the module is still not performing correctly. Yesterday, I set a simple test for tomorrow. It correctly reported 2 Days Left. This morning (7:09am) it still reports 2 Days Left. I’ve made only the changes that you have advised.

sorry. no screenshot. I’m not at my normal computer

Mykle1

@Mykle1

{
    			module: 'MMM-doomsDay',
    			position: 'top_right', // This can be any of the regions, best results in center regions
    			config: {
        			doomsDay: "2017-03-03 24:00:00", // the end day of the countdown, 
        			toWhat: 'Pay Day is in', // the title of your countdown event
				present: 'Benjamin Pile!',
				updateInterval: 1 * 3600000,
				singular: 'more day!', // what it should say when it's only one day left, default is `Day Left`
				plural: 'more days', // what it should say when it's more days left, default is `Days Left`
				}
		},

Mykle1

@broberg

Just glanced at the mirror and doomsDay is now reporting 1 more day. I don’t know at what time that occurred.

Mykle1

@Mykle1

Reporting the correct present: message this morning. I’ll now set a week long countdown and see how that goes. I’ll try not to bother you anymore

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

And thank you for all the beta testing!

I know I said I would try not to bother you anymore with this but . . .

I set doomsDay: "2017-03-15 24:00:00", which is the Ides of March, just as a test. I keep testing because I really want this module to work for me. Well, as of 8:50am today, 2017-03-04. the module is reporting 12 More Days instead of 11. The last test didn’t update the Days Left until late morning, early afternoon. I wouldn’t mind if it was slow in updating by an hour or two but it’s no good to me if it’s 12 hours behind

Sorry

broberg

@Mykle1 Okay, do a new git pull now. I have altered the method of rounding the numbers, which I should have done from the beginning if I knew better :P

Anyhow. Try the new version!

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

Anyhow. Try the new version!

I’ll get it right now. Thanks for dealing with this for me.

Did the git pull

I changed my test to the 7th as a 3 day test. I didn’t want to wait till the 15th to see if it was working correctly. It’s reporting 3 Days Left so that’s an improvement right away. I’ll check it in the morning. Thanks again

strawberry 3.141

@broberg date and time stuff can get really painful, that’s why I’m using moment for those tasks. there are some clever brains that thought about all kind of edge cases etc. you might want to check it out http://momentjs.com/docs/#/displaying/to/

broberg

@strawberry-3.141 Yeah I’ve noticed. If this module keeps misbehaving I will look in to the moment.js instead. looka a lot simpler, thanks for the link!

yawns

@strawberry-3.141
Absolutely right, moment.js makes life a lot easier when it comes to times and dates.

Snille

Hi there! I just posted a PR to you on github, adding the “passed” text via the config. And also let the “toWhat” event to still be shown when the event has passed (makes more sense i think if you use the “passed” text.) :)

broberg

@Snille There is already a text being displayed once the day has passed, not configurable, but, there is one :D

Snille

@broberg I know, that’s why I only made it configurable. :) Then ppl don’t have to change your code to set their own message. :)

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

If this module keeps misbehaving

Hey Bro, I just wanted to report that my last 3 day test worked correctly, without a hitch. When I looked at my mirror this morning, it said, “Did it work?” :thumbsup_tone1:

broberg

Finally got around to adding the option to change the text displayed when the doomsDay has passed as @Snille suggested!

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

Finally got around to adding the option to change the text displayed when the doomsDay has passed as @Snille suggested!

So I should do a git pull?

broberg

@Mykle1 Only if you feel like it!
But the latest is the coolest, don’t you think? ;)

Mykle1

@broberg said in MMM-doomsDay - The countdown module,:

Only if you feel like it!

Of course I feel like it.

But the latest is the coolest, don’t you think?

No doubt! I’m a huge fan of this module. :thumbsup:

Mykle1

@broberg
Actually, I won’t know for 26 days. I’ll let you know then!

broberg

@Mykle1 Hahaha, fair enough :thumbsup: