Cant use showEnd icloud cal

[blvk]

Hey,

hopefully you can help me. If already tryed to try this fix but it dont work for me.
https://github.com/MagicMirrorOrg/MagicMirror/issues/2629

My problem, i got a Calendar form my icloud cal. I already got every informations i want.

This is my ics

BEGIN:VEVENT
CREATED:20240922T101541Z
DTEND;VALUE=DATE:20250104
DTSTAMP:20240922T101542Z
DTSTART;VALUE=DATE:20241216
LAST-MODIFIED:20240922T101541Z
SEQUENCE:0
SUMMARY:Urlaub Jan
UID:66E9674A-B97F-41DC-B25E-DE2D2C4DFF3B
URL;VALUE=URI:
X-APPLE-CREATOR-IDENTITY:com.apple.mobilecal
X-APPLE-CREATOR-TEAM-IDENTITY:0000000000
TRANSP:OPAQUE
END:VEVENT

                {
                        "module": "calendar",
                        "header": "Urlaub",
                        "position": "top_left",
                        "config": {
                                showEnd: true,
                                showEndsOnlyWithDuration: true,
                                maximumEntries: 8,
                                "calendars": [
                                        {
                                                "symbol": "calendar",
                                                "url": "http://192.168.178.3:8080/modules/calendars/3920BBAD-278C-4EAB-AF16-9442B82D2459.ics"
                                        },
                                ]
                        }
                },

The showEnd dont work, i got only the start date of my holidays.

What do i wrong?

[evroom]

@sdetweil

My Google Calendar remark was more aimed at the basic.ics we get from it.
I see now it added an unnecessary discussion.
However it did take me some time to find out that the screen you showed is only seen after clicking the More Options button; my bad.

Your evaluation of showEnd and showEndsOnlyWithDuration is quite useful.

Btw, one time in the Dutch parliament there was a big confusion about voting for something.
If you do not want XXX, then vote yes, if you want XXX then vote no.
Of course this went wrong.

Concluding: all my tests passed, meaning it works as designed.
I will raise an issue for a feature request, but you can either reject it or put it on the bottom of your list of todo’s.

[sdetweil]

@blvk also need

tineFornat:"absolute"

[blvk]

@sdetweil said in Cant use showEnd icloud cal:

@blvk also need

tineFornat:"absolute"

Nothing changed

[sdetweil]

@blvk turn off showOnlyWithDuration

this is a whole day, multiday event
duration is tor a short term event

[blvk]

@sdetweil said in Cant use showEnd icloud cal:

@blvk turn off showOnlyWithDuration

set to false, no changes, do you need some more informations i can share?

[sdetweil]

@blvk sorry, didn’t think it thru

because your events are full day (no time)

DTSTART;VALUE=DATE:20241216

there is no duration

we do not show end for full day events
we could, but don’t

if (this.config.showEnd) {
	if (this.config.showEndsOnlyWithDuration && event.startDate === event.endDate) {
	    // no duration here, don't display end
	} else {
//----- we do this
		timeWrapper.innerHTML += "-";
			timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
	}
}
	// For full day events we use the fullDayEventDateFormat
	if (event.fullDayEvent) {
        	//subtract one second so that fullDayEvents end at 23:59:59, and not at 0:00:00 on the next day
	       event.endDate -= ONE_SECOND;
/// then change the display of both to just the start 
               timeWrapper.innerHTML = CalendarUtils.capFirst(moment(event.startDate, "x").format(this.config.fullDayEventDateFormat));

[sdetweil]

@blvk I just added this to the next release calendar
you can get my test version and try it out
see https://forum.magicmirror.builders/topic/19070/call-for-testers-updated-calendar-module

if showEnd:true, and start date is different then end date, then
add end date on using dateEndFormat
— this (dateEndFormat) might collide with dateEndFormat on events WITH time… need feedback

[evroom]

@sdetweil

At first sight I do not like it too much.
Daily repeating events have an end time now that does not make really sense (23:59) and the Holliday end time only makes sense when the dateEndFormat is extended to see the date.
And that makes it pretty crowded in the date/time column.

IMHO :-)

timeFormat: "absolute",
showEnd: true,
showEndsOnlyWithDuration: true,
//dateEndFormat: "HH:mm",
dateEndFormat: "dddd MMM D - HH:mm",

I currently have
showEndsOnlyWithDuration: true,
but
showEndsOnlyWithDuration: false,
does not seem to do anything.

timeFormat: "absolute",
showEnd: false,
showEndsOnlyWithDuration: true,
dateEndFormat: "HH:mm",
//dateEndFormat: "dddd MMM D - HH:mm",

Regards,

E.J.

[sdetweil]

@evroom thanks… that was what I was afraid of

can you change line calendar.js 439 to be like this, use the FullDayEventFormat, so not different that begin

							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.fullDayEventDateFormat));

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

calendar.js

~/MagicMirror/modules/default/calendar/calendar.js

this.config.fullDayEventDateFormat

showEnd: true,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: true,