MMM-Remote-Control

rkorell

@sdetweil
Good point!
Unfortunately I’ve already DONE the upgrade of remote-control - and now it doesn’t work anymore :-)

rkorell

@sdetweil
just ran a testrun of your upgrade script:

pi@MagicMirrorPi5:~/MagicMirror $ bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)"
update log will be in /home/pi/MagicMirror/installers/upgrade.log

doing test run = true, NO updates will be applied!

Check current Node installation ...
Node currently installed. Checking version number.
Minimum Node version: v22.18.0
Installed Node version: v20.18.1
Node should be upgraded.
Node.js upgrade defered, doing test run
Check current NPM installation ...
NPM currently installed. Checking version number.
Minimum npm version: V10.9.2
Installed npm version: V10.8.2
npm should be upgraded.
npm upgrade defered, doing test run  ...

saving custom.css
reverting to master branch from _fix_clipping, saving changed files
would restore file modules/default/weather/current.njk before switch back to master branch
would restore file package-lock.json before switch back to master branch
would restore file package.json before switch back to master branch
error: Your local changes to the following files would be overwritten by checkout:
        package-lock.json
        package.json
Please commit your changes or stash them before you switch branches.
Aborting
unable to change back to master branch, stopping execution

What does the last message mean?
“unable to change back to master branch, stopping execution”
What have I to do?

rkorell

@sdetweil
BTW: Do you know if it is possible to restore the “old” version from remote-control?
May THIS is the better option for me?

sdetweil

@rkorell can you tell me when old was? luckily this module uses tags for releases, so you could restore to one of the previous releases…

in the module folder do

git fetch --all --tags

then when we figure out which release to try, we can

git checkout <tag_name>

Release 3.2.1 was about 5 months ago.

rkorell

@sdetweil I’ve found V3.3.2 and just try "git checkout 1f451ce "

sdetweil

@rkorell if you pull the tags, you can use the tag name

git checkout v3.3.2

rkorell

@sdetweil
For some really strange reasons, neither

pi@MagicMirrorPi5:~/MagicMirror/modules/MMM-Remote-Control $ git fetch --all --tags
pi@MagicMirrorPi5:~/MagicMirror/modules/MMM-Remote-Control $ git fetch --tags

currently give any feedback…

So I’ve worked with the found git-hash:

git checkout 1f451ce

This at least worked and rolled back to V. 3.3.2.

Unfortunately some dependencies (package-lock.json ???) are not strict enough, so the rollback produces an error message:

[ERROR] Error when loading MMM-Remote-Control: require() of ES Module /home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/uuid/dist-node/index.js from /home/pi/MagicMirror/modules/MMM-Remote-Control/API/api.js not supported.

So I downgraded UUID:

cd ~/MagicMirror/modules/MMM-Remote-Control
npm install uuid@9.0.1
npm ci --omit=dev

With this module is running again.

From now on I’m in a in ‘detached HEAD’ state - but this seems OK.
Thanks for your time, effort and always great help!

Ralf

sdetweil

@rkorell I was just about to add that you needed to redo the npm install for the module after deleting the node_modules folder
else you were trying to run the new dependencies with the old code

but you fixed it…

rkorell

@sdetweil
Yes :-)

In fact I’ve used

npm ci --omit=dev

this does the deletion of the node_modules folder inherently AFAIK …

Thanks again, dear Sam!

Ralf

sdetweil

@rkorell said in MMM-Remote-Control:

npm ci

be careful… the package.json was built and tested on a cloud based virtual machine.
pi and other hardware types MAY need a different version of a dependency, i’ve only seen it myself twice in 6 years, but

npm ci uses the exact package.json
npm install will get the appropriate for this platform, even if the version changes.

anyhow… I use npm install --omit=dev when I do the installs script or MMM-Config

rkorell

@sdetweil
OK; thanks for this hint.
May npm install has avoided the resulting error which I had to solve…

Anyway: Thanks a LOT!
Regards,
Ralf

KristjanESPERANTO

Thanks for the feedback!

Since Sam has already addressed some of the issues, I won’t go into them again.

A few problems were mentioned, some of which I have just addressed with v4.1.0. E.g.:

Restart/Shutdown: Should now also work on systems without PM2.
Minimize: Now says “restart to restore” so you know how to undo it.

About the monitor control issue:

This would be tricky to get running by default everywhere because every system uses different commands (X11/Wayland/etc). You have to check the Monitor Control docs and configure the right commands for your specific setup - the defaults won’t work everywhere.

About the “npm install/npm ci” topic:

Yes, npm ci can be problematic for modules with native dependencies that need platform-specific builds. However, MMM-Remote-Control only uses pure JavaScript dependencies (marked, qrcode, simple-git, swagger-ui-dist, uuid) - no native modules that require compilation.

For this module, npm ci is actually the better choice because:

Guarantees exact tested versions which the developers released
Faster installation (no dependency resolution)
Same behavior in CI and production
No change on the package-lock.json

So the warning about npm ci is valid in general, but doesn’t apply here.

About the microupdates. Since the test suite does not a lot parts yet, some details simply go unnoticed after major changes. If you are not experiencing any problems with the module, you do not need to install every update.

About node update: I recommend using nvm for node updates. This is also what is offered as default for Linux on the official download page. This makes many things easier - like if something does not work after an update, you can easily switch back to the previous node version. So you don’t need to be so afraid of updates.

KristjanESPERANTO

@S374n said in MMM-Remote-Control:

First update changes my main.css - took me a while to figure it out and redo all my customizations.

You should not change main.css. All customizations should be made in custom.css: https://docs.magicmirror.builders/modules/customcss.html#custom-css

sdetweil

@KristjanESPERANTO n also allows you to change version on the fly.

One nvm ‘benefit’, it stores the node versions in the users home folder at .nvm

So, on a multi-user system each user could have different node versions.

As MagicMirror is deployed as only user, it’s functionally the same.

One n benefit, it stores the version in the /usr/ local folder
So it requires sudo to make the change, cannot be accidental

KristjanESPERANTO

@sdetweil said in MMM-Remote-Control:

So it requires sudo to make the change, …

This can also be seen as a disadvantage 🙂

sdetweil

@KristjanESPERANTO maybe, if you never use sudo, but we use it very often

meikelrix

@KristjanESPERANTO Hi, I very much like MMM-Remote-Control!

The last update has possibly introduced an error with respect to the “Custom Menu Items” => I have a menu item which still shows, but the sub menu items don’t show anymore?

Else wise please let me repeat: excellent job on MMM-Remote-Control!

meikelrix

said in MMM-Remote-Control:

@KristjanESPERANTO Hi, I very much like MMM-Remote-Control!

The last update has possibly introduced an error with respect to the “Custom Menu Items” => I have a menu item which still shows, but the sub menu items don’t show anymore?

Else wise please let me repeat: excellent job on MMM-Remote-Control!

FWIW: I’m using the showModuleApiMenu: true setting in config.js as well and the submenus there don’t show either, any more?

KristjanESPERANTO

@meikelrix I’ll take a look asap :-)

KristjanESPERANTO

@meikelrix Please check new release 4.1.1 🙂