How to add modules. For absolute beginners.

TheSij

@sdetweil - apologies, I was in the wrong directory. This is the terminal response…

> magicmirror@2.12.0 start /home/pi/MagicMirror
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[2020-07-27 22:56:11.226] [LOG]    Starting MagicMirror: v2.12.0
[2020-07-27 22:56:11.233] [LOG]    Loading config ...
[2020-07-27 22:56:11.238] [LOG]    Loading module helpers ...
[2020-07-27 22:56:11.240] [LOG]    No helper found for module: alert.
[2020-07-27 22:56:11.290] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.291] [LOG]    Module helper loaded: updatenotification
[2020-07-27 22:56:11.291] [LOG]    No helper found for module: clock.
[2020-07-27 22:56:11.643] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.644] [LOG]    Module helper loaded: calendar
[2020-07-27 22:56:11.645] [LOG]    No helper found for module: currentweather.
[2020-07-27 22:56:11.646] [LOG]    No helper found for module: weatherforecast.
[2020-07-27 22:56:11.678] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.678] [LOG]    Module helper loaded: newsfeed
[2020-07-27 22:56:11.679] [LOG]    No helper found for module: MMM-TFL.
[2020-07-27 22:56:11.681] [ERROR]  WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
[2020-07-27 22:56:11.682] [LOG]    Loading module helpers ...
[2020-07-27 22:56:11.683] [LOG]    No helper found for module: alert.
[2020-07-27 22:56:11.683] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.684] [LOG]    Module helper loaded: updatenotification
[2020-07-27 22:56:11.684] [LOG]    No helper found for module: clock.
[2020-07-27 22:56:11.685] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.685] [LOG]    Module helper loaded: calendar
[2020-07-27 22:56:11.685] [LOG]    No helper found for module: currentweather.
[2020-07-27 22:56:11.686] [LOG]    No helper found for module: weatherforecast.
[2020-07-27 22:56:11.686] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.686] [LOG]    Module helper loaded: newsfeed
[2020-07-27 22:56:11.687] [LOG]    No helper found for module: MMM-TFL.
[2020-07-27 22:56:11.688] [ERROR]  App threw an error during load
[2020-07-27 22:56:11.689] [ERROR]  Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:41:16)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Function.Module._load (internal/modules/cjs/loader.js:531:27)
    at Module.require (internal/modules/cjs/loader.js:685:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:786:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10)
    at Module.load (internal/modules/cjs/loader.js:645:32)
[2020-07-27 22:56:11.690] [ERROR]  Whoops! There was an uncaught exception...
[2020-07-27 22:56:11.690] [ERROR]  Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:41:16)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Function.Module._load (internal/modules/cjs/loader.js:531:27)
    at Module.require (internal/modules/cjs/loader.js:685:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:786:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10)
    at Module.load (internal/modules/cjs/loader.js:645:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js',
    '/home/pi/MagicMirror/js/app.js',
    '/home/pi/MagicMirror/js/electron.js',
    '/home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js',
    undefined
  ]
}
[2020-07-27 22:56:11.696] [ERROR]  MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
[2020-07-27 22:56:11.697] [ERROR]  If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
[2020-07-27 22:56:11.814] [LOG]    Launching application.

sdetweil

@TheSij said in How to add modules. For absolute beginners.:

[2020-07-27 22:56:11.690] [ERROR] Error: Cannot find module ‘async’

i suspect you did not do the required install in the
MagicMirror/modules/MMM-PrayerTime folder

per the instructions

Installation
Navigate into your MagicMirror's modules folder
execute git clone https://github.com/slametps/MMM-PrayerTime.git

**if this module does not run correctly,** try npm install async

TheSij

@sdetweil said in How to add modules. For absolute beginners.:

I am 110% sure I installed the module in the right directory. I always check before I execute it. I’ve just checked the directory, and the module repository is in the right place. I’m executing the ‘npm install async’ command now. Fingers crossed!

sdetweil

@TheSij said in How to add modules. For absolute beginners.:

I’ve just checked the directory, and the module repository is in the right place.

what does that mean?

sdetweil

I opened an issue on the MMM-PrayerTime module github, for him to create a package.json file for this async dependency and let the system handle it
https://github.com/slametps/MMM-PrayerTime/issues/43

TheSij

@sdetweil - as in, the files for that module is in the MM modules folder. Sorry if I’m using the wrong terminology.

So, after running the ‘npm install async’, it found three low vulnerabilities, which I’ve asked for them to be fixed.

TheSij

@sdetweil - thanks. I think I’ve got it working. The module is finally showing in the MM dashboard. Thanks very much for the guidance, and @Mykle1.

sdetweil

@TheSij ignore the vulnerabilities, more trouble than its worth

TheSij

@sdetweil - too late. Sorry, I went ahead before getting this advice. I’ll remember for next time.

sdetweil

@TheSij many times the ‘fixes’ force new code, which breaks old code, so you fix one problem, but the system is dead.

more times than not fixing adds new issues to the list, different than u started with. almost NEVER does the list go away.
and some of the vulnerabilities matter IF you have your pi connected to the internet where others are interacting with it (logon, save money, messages, …) MM is just pulling update notices. not allowing unsolicited inbound connections…