MMM-NOAA - Another Weather Module

Nystro0m

Hi!

Im stuck on the “Gather Wather Stuff” Message. Or “Samlar väderinformation” since im running a Swedish pi.
First of thanks for sharing the module, it looks badass.

Ive been diagnosing alot without any luck but this is what ive done to confirm my config:
Ive been checking my api-key and pws with another module from RedNax67 called MMM_Wunderground.
And i can get that one to work.

I also encounter this message on re-installing the module (can’t remember if it was there on the initial install).

npm WARN mmm-noaa@1.0.0 No repository field.

This is my module config:


{
    disabled: false,
    module: 'MMM-NOAA',
    position: 'top_right',
    config: {
        apiKey: "Y507ba7785XXXXXXX",          // https://www.wunderground.com/weather/api  select the middle plan... 
    useAir: false,             //set to false if you do not want to use Air Quality Index
    airKey: "Y507ba7785XXXXXXX",  //IF you want Air Quality Index
		pws: "IUHAMMAR4",       // go here to find your pws: https://www.wunderground.com/wundermap
                lat: "59.609900",        // need this for sunrise/sunset  if left blank none will show  -- find them here: http://www.latlong.net/
		lon: "16.544809",       // need this for sunrise/sunset  if left blank none will show
		showClock: true,            //Hides or shows clock
		dformat: false,             //for M/D/YYYY format, false for D/M/YYYY
		showClock: true,
		format: "24",             // 12 or 24 hour format.. will default to 12 hour if none selected.
		ampm: false,                 //to show AM and PM on Sunrise/Sunset time
		showGreet: false,          //deafult is false - to show greeting under clock and above date
                    name: "",                  // Your name
		showWind: false,
                    showDate: false,
}

Do you have any other ideas what i can try to get it running?

barnosch

uncomment the “air stuff” for the moment

 /*    if (this.config.useAir != false || aquis != undefined) {
            var aqius = this.air.aqius;
            var aqi = document.createElement("div");
            aqi.classList.add("xsmall", "bright");
            if (aqius < 51) {
                aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
            } else if (aqius > 50 && aqius < 101) {
                aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
            } else if (aqius > 100 && aqius < 151) {
                aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
            } else if (aqius > 150 && aqius < 201) {
                aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
            } else {
                aqi.innerHTML = this.translate("Air Quality Index: ") + "" + aqius + "";
            }
            wrapper.appendChild(aqi);
        } */

@cowboysdude needs to check it, since the “aquis” variabel is undefined it quits. Had the same error and i needed some time to find the cause

edit: while i am reading i guess it is just a typo in the first line. should be “aqius” instead of “aquis” ;)

edit2: yes. thats it. just change
the line

if (this.config.useAir != false || aquis != undefined) {

to

if (this.config.useAir != false || aqius != undefined) {

and you are good to go again.

Sadly i have no idea how to push the fix to the git repository

Nystro0m

@barnosch

It did work like a charm, thanks alot dude!
Also thanks to @Mykle1 for chatting with me and updating me on the social status of @cowboysdude hehe.
For a first time post, i must say you guys have impressed me of how welcoming a Forum can be. It’s rare from my experience.

Mykle1

@barnosch said in MMM-NOAA - Another Weather Module:

and you are good to go again.
Sadly i have no idea how to push the fix to the git repository

Nice catch you guys.

Nice remedy @barnosch

If you go to the modules repo https://github.com/cowboysdude/MMM-NOAA
and click on the file you want to fix, then click on the “pencil” icon to the right, github will fork the repo for you. There you can make the edit and submit a pull request which will go to cowboysdude

Mykle1

@Nystro0m said in MMM-NOAA - Another Weather Module:

Also thanks to @Mykle1 for chatting with me and updating me on the social status of @cowboysdude hehe.

I just finishing texting with @cowboysdude. I told him, “Don’t rush home from work. Someone else fixed your $h1t”.

:^)

barnosch

cool. thats easy.
Thanks for the explanation. Fix added ;)

Mykle1

@barnosch said in MMM-NOAA - Another Weather Module:

cool. thats easy.
Thanks for the explanation. Fix added ;)

You’re welcome.

I’m sure @cowboysdude will appreciate it

cowboysdude

Thank you @Mykle1 and @barnosch

Merged the pull request! :)

Mykle1

@cowboysdude said in MMM-NOAA - Another Weather Module:

Merged the pull request! :)

He ran all the way home just to fix his module.

Yeah, he’s that good! :^)

And, well done @barnosch !

barnosch

thanks guys. Very nice to have some guys like you here. Like this it’s fun.