MMM-BMW-DS (A different kind of weather module)

Mykle1

Fixed an issue that was brought to my attention by github user 73cirdan. I don’t know if he is the same as @cirdan but I would guess they are one and the same person. My thanks!

Do a git pull for the updated file or install as per the readme

cirdan

Yep, that’s me, thanks for the fix mate

jorgeb1502

@mykle1

I have another request for this module. Is it possible to show the time in 24h instead of am/pm?

Mykle1

@jorgeb1502 said in MMM-BMW-DS (A different kind of weather module):

Is it possible to show the time in 24h instead of am/pm?

Let me take a look at it. That should not be a problem. :-)

Mykle1

@jorgeb1502

Feature

This really should have been included from the beginning. I guess it just didn’t cross my mind. Anyway, . . .

The module will now read the timeFormat: 12, (or 24) of your config and display the correct time format.

Do a git pull or install as per the readme

EDIT: Thanks CBD!

Mykle1

Minor Update

**Now with sound support for rain, thunder and wind

Download:

[card:mykle1/MMM-BMW-DS]

Version 1.0.4

You can use your own mp3 sound files as long as you name them rain.mp3, thunder.mp3 and wind.mp3 and place them in the sounds folder of the module itself.

git pull or install as per the readme

sdetweil

i just installed this module, and the default CSS causes the display to take over the entire screen…

css:1, fixes it… I ‘assume’ the default should be 1?

Mykle1

@sdetweil said in MMM-BMW-DS (A different kind of weather module):

i just installed this module, and the default CSS causes the display to take over the entire screen…
css:1, fixes it… I ‘assume’ the default should be 1?

Sorry the module is giving you trouble. You should not have a “default.css” file at all. In the css folder of the module there should only be 6 css files, named:

MMM-BMW-DS1.css
MMM-BMW-DS2.css
MMM-BMW-DS3.css
MMM-BMW-DS4.css
MMM-BMW-DS5.css
MMM-BMW-DS6.css

Maybe the way I implemented this, or documented this, is not very clear. I do apologize for that. If you have a suggestion for cleaning this up I would appreciate that, or if the problem is something else then please assist me in understanding and correcting.

sdetweil

your readme

  css: "1",                         // 1-6 (default, Clean, Lord of the Rings, Handwriting, etc)

ok, what is ‘default’?

ie, the setting if one doesn’t chose anything?

if I do not supply the line above, what value will be used

the screen shots show a line at the bottom of the page, so I ASSUME this must be the ‘default’ behavior…

Mykle1

@sdetweil said in MMM-BMW-DS (A different kind of weather module):

if I do not supply the line above, what value will be used

Ok, I see. I’m off to dinner right now but I will correct that when I return. I’m sorry for the trouble and thank you for pointing that out to me.

Mykle1

@sdetweil

Ok, this is what I’ve done. I don’t know if this is the proper way of doing it but it does work.

// Gets correct css file from config.js
    getStyles: function() {
      if(this.config.css != ""){
        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS" + this.config.css + ".css"];
      } else {
        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS1.css"]; // default.css
      }
    },

sdetweil

@mykle1 easier if u just declare a defaults section in your module.js which has css: 1

The when it is merged with the user supplied config, there will always be something set.

Then u don’t need the if/then at all

Mykle1

@sdetweil

I don’t know how I missed that. Thanks again for showing me the error of my ways. :-)

// Module config defaults.
    defaults: {
        apiKey: "", // Get FREE API key from darksky.net
        tempUnits: "C", // C  or F
        lat: "40.123456", // Latitude
        lng: "-74.123456", // Longitude
        css: "1", // 1=default, 2=Clean, 3=Lord of the Rings, 4=handwriting, 5=Julee, 6=Englebert
        ownTitle: "Current Conditions", // Default = Current Conditions
        useHeader: false, // true if you want a header
        header: "Your Header", // Any text you want. useHeader must be true
        maxWidth: "100%",
        animationSpeed: 3000,
        initialLoadDelay: 4250,
        retryDelay: 2500,
        updateInterval: 5 * 60 * 1000,

cirdan

Mykle, kids called me at work today. magic mirror is making weird noises. 😀

Afraid for hardware failure I went home only to find out mmmbmwds had added sounds and it rained for the first time.

Would you consider building in a config switch to enable/disable sounds?

sdetweil

Rename the mp3 files to something else

Mykle1

@cirdan said in MMM-BMW-DS (A different kind of weather module):

Would you consider building in a config switch to enable/disable sounds?

git pull in the MMM-BMW-DS directory and playSounds: "no" in the new config option. :thumbsup:

Why can’t everything I try to do with modules be that easy?

cirdan

@mykle1 tnx for the quick fix.
(At last peace returns to the grey havens 😁)

RV Knight

Hi, sorry about bringing back up this old post. I’m currently having issues with it, it’s displaying in the bottom with acquiring you weather but doesn’t go any further than that. I’ve checked the config as far as I can tell but I’m still having issues, would it be possible to have some help? Thanks

Mykle1

@RV-Knight

Please post your config entry for MMM-BMW-DS (in a code block) so I can take a look at it for you. It should look something like this:

{
            disabled: false,
            module: "MMM-BMW-DS",
            position: "bottom_bar",
            config: {
                apiKey: "123456789123456789", // Your api key from darksky.net
                ownTitle: "Current Conditions",
                tempUnits: "F", // C of F
                lat: '42.123456',
                lng: '-74.123456',
                css: "2",
                playSounds: "no",
                useHeader: false, // true if you want a header
                header: "Your header",
                maxWidth: "100%",
            }
        },

You can also start your mirror using npm start dev. Click the Console tab in the window that opens (top left) and report any errors (appearing in RED). You may have to scroll

Mykle1

@RV-Knight

Have you made any progress?