Posts made by cohron

Just uploaded a MM module that supports OpenSprinkler. It connects to the demo.opensprinkler.com by default. Still needs lots of enhancements but it works.

https://github.com/johnny-co/MMM-OpenSprinkler/

Re: MMM-ScreenLogic - see data from your Pentair pool equipment
I just reactivated my MM and installed your ScreenLogic Module. I love it and worked out of the box.

If I could be so bold to make a few enhancement requests? I dont have a touch screen MM so i dont show controls, its more just a status board for me.

For the Pool Temp and Spa Temp status, perhaps turn the background green when on (Like the Nest turns blue).

Add a little flame to the right of the temp to show heater on.

below temp show: Heat Mode: Heater (85*)

I’ll try to upload a pic but it keeps erroring out.

Anyway love the module and stay safe in this pandemic.

Re: MMM-ScreenLogic - see data from your Pentair pool equipment
I just reactivated my MM and installed your ScreenLogic Module. I love it and worked out of the box.

If I could be so bold to make a few enhancement requests? I dont have a touch screen MM so i dont show controls, its more just a status board for me.

For the Pool Temp and Spa Temp status, perhaps turn the background green when on (Like the Nest turns blue).

Add a little flame to the right of the temp to show heater on.

below temp show: Heat Mode: Heater (85*)

I’ll try to upload a pic but it keeps erroring out.

Anyway love the module and stay safe in this pandemic.

@j.e.f.f why not add it to github and make it part of the master so updates won’t overwrite your work.?

@Anhalter42 I spend some time going through the calendar module code, i can read it fairly well, for the syntax i dont understand there is always google. After review, I see why there are no separate fetchInterval’s for each calendar. Each calendar’s events are added to an array, then sorted together also the dom (html table) is created from scratch on each interval. Without a tremendous restructuring of code, setting up separate interval timers, persisting the ical events array, etc. the value to adding this is limited.

Your comments help me immensely, thank you. I reviewed the template module, i’l start playing with that and do a Hello World module exercise when i return home at the end of the month.

@Anhalter42 Definately, and excellent point about not changing the existing option name. I’m hoping to implement a (swimming) pool module in the next couple of months. I haven’t coded (VB) in over a decade so i am reading up about Github (great concept btw). Not sure if i need to branch or pull request or what just yet. I think i can handle learning JS and use the existing modules to reference. This will be a great exercise for me before i jump into full coding.

@strawberry-3.141 Strawberry, your friggin awesome for your involvement here. Unfortunately the ical.js and node-ical.js were not my problem. I did however solve my issue but not sure of the cause.
The icloud calendars urls were no longer valid but still were active in icloud.com. I simply unmarked each calendar as public, clicked save, marked it again as public which generated a new url. A quick copy and paste of each one got the calendar working again. now if i can figure out why the url stopped working in the first place. Hopefully this wont happen again, but we will see.

Also if you have a moment, im trying to figure out how to view the start up outputs where i could have seen each calendar trying to load and likely getting an error. is it in a log somewhere or a special way to start the app?

@Anhalter42 so should the fetchInterval be moved to the calendar array since some calendars only need to be updated once (holidays) and others more often. just a thought have a defaultFetchInterval at the module level and fetchInterval for calendar level?

@cohron
Now it seems the calendar MMM are no longer loading my multiple icloud ics urls. it had been working for a couple of weeks and just stopped. My office365 is loading just fine. I know this is vague just need to figure out where to start looking.

The hi/lo on hourly are reversed, but the daily shows correctly.