@mumblebaj Thank you for asking! 🙂 Since I want to redesign a few things on the inside, I have not looked for any further discussion for now.

My current plan is roughly this: First make the scripts more efficient (they are currently very storage and time consuming) and then automate the whole process using GitHub hooks and actions. I’ll try to accomplish this in the next few months 🚀

Once I’ve done that, I’ll look for the discussion about the official list.

On this occasion: What is the status of MMM-PGA? 😁 It would be nice if you put at least one of the screenshots into the repository and add keywords in the package.json.

@myayo001 Just remove the the line const fetch = require("fetch"); in the file node-helper.js in the module’s directory.

Meanwhile, there have been some changes to the module list. E.g.

• If you click on a maintainer’s name, you will get a list of all modules by that maintainer :smiley:
• Dark mode switch
• Style changes
• Many module maintainers added screenshots and keywords and fixed listed issues
• GitHub stars are displayed
• New sort option: number of stars
• Module tags are now clickable
• Screenshots are now clickable
• Optimized mobile view

And some more …

@mumblebaj Just an idea: Maybe the node version used in Cron could be to old. When you run a script manually in your terminal, your full user environment (including things like .bashrc or .zshrc) is loaded. Cron runs in a much more minimal environment — it often doesn’t load your shell config files, so tools like nvm (Node Version Manager) might not be available.

How to fix it:

• Use the full path to Node: Find it with which node and use that path in your cron job.
• Set the environment manually in cron: You can define your PATH at the top of the cron file.
• Source nvm in your script: If you use nvm, add source ~/.nvm/nvm.sh and nvm use <version> before calling node.

@chrisfr1976 Great. I have just adjusted the list in the wiki accordingly :-)

@MZ-BER How did you do the update?

cd ~/MagicMirror/modules/MMM-PublicTransportHafas
git pull
npm ci

@mumblebaj Many thanks for the tips! :smiley:

I have meanwhile written to the operators of the website to see if they can offer an API. If not, I will probably follow your suggested approach.

Nice! I think the real-time clock is a useful new feature for the MM. With that we should be able to wake up the Raspberry Pi automatically without any external device.

@mart11 This should be fixed since we released version 3.0.0 😀 Please update and check.

for MagicMirror purposes, is there a preferred style to be used for modules?

@kayakbabe I agree with Sam, but here’s a more detailed answer anyway: This depends on where you are. In some modules there are no rules for this - there and in your own modules it is, as Sam says, up to you.

However, to avoid poor code style, such as spaghetti code and inconsistently formatted code, which not only make maintenance and further development more difficult, but also affect team collaboration, many projects use static code analysis tools such as prettier and ESLint for checking code quality.

In the MagicMirror core (and with this in the default modules), we use the ESLint object-shorthand rule (see https://archive.eslint.org/docs/rules/object-shorthand) to ensure that only the shorthand version is used.