Offline
@sdetweil said in Config option with array of multiple values?:
maybe what you wanted was
if ( that.config.validSenders.includes(mailObj.sender[0].address) && (daysAgo >= 0 && daysAgo <= that.config.daysToDisplay) ) {this is two outer compares (with one inner)
I just tried this and it works. Not sure why the extra set of parentheses are needed but I’m not going to argue. 8^)
Thanks!
@sdetweil said in Config option with array of multiple values?:
generally when you expand the number of items in an array to objects ({}) you start to get thinking about what happens if you decide to add another entry in the object…
so in javascript you can NAME the elements
validSenders: [ { url:"mom@example.com", name:"Mom", color:"#ff0000" }, { url"dad@example.com", name:"Dad", color:"#00ff00" }, { url:"son@example.com", name:"Son", color:"#0000ff" }, ]that way the code is not sensitive to the order of the elements
validSenders.forEach(sender =>{ if (sender.name =="Dad") { do_something(sender.url) } })
So in this scenario, you have validSenders the array and, for example, validSenders.url as one attribute(?) of the array? In your example, where does “sender” come from? It’s not one of the named elements. Is it a sort of temporary variable that gets handed the array … object(?) … so in the first iteration of the forEach (which I assume loops through each entry in the validSenders array), sender would contain(?) url:"mom@example.com", name:“Mom”, and color:“#ff0000”? And sender.url would be “mom@example.com”?
That makes sense. I apologize for not knowing the terminology; I’m very new to the whole OOP sort of thing.
you can also use the array.filter() function
let selected_sender = validSenders.filter(sender=>{ if(sender.url==mailObj.sender[0].address) return true else return false }) if(selected_sender.length>0){ // we found a matching sender }the filter function passes each element array in turn to the function
if you want the element in the output array return true,
if not return false
Could this return false if it doesn’t match but an index if it matches so that one could refer to validSenders.color[selected_sender] to get the right attribute?
I really kinda wish I had a spare RPi laying around so I could do this testing on something other than my production mirror. (I mean, everyone’s aware that it’s a work-in-progress but I don’t want to muck it up.)
- that.config.validSenders.includes(mailObj.sender[0].address)
- daysAgo >= 0
- daysAgo <= that.config.daysToDisplay
the last two CANNOT be true at the same time
I’m not sure I understand… if daysToDisplay is, say, 50 and daysAgo = 25, then the last two would both be true?
What I’m trying to do is make sure that the sender of an e-mail is in the list of valid senders and that the date the e-mail was sent is not more than daysToDisplay days ago.
maybe what you wanted was
if ( that.config.validSenders.includes(mailObj.sender[0].address) && (daysAgo >= 0 && daysAgo <= that.config.daysToDisplay) ) {this is two outer compares (with one inner)
I thought I tried that but even so, I don’t understand how that’s different from what I had. I thought that “If A && B && C” would be the same as “If A && (B && C)” – in either case, all three have to be true for the whole thing to be true.
I’m working on a module and it mostly works. I’d like to expand its functionality a bit though and to do that I’m thinking about changing an array I have into an array of multiple values. That is, I currently have defined and am using:
validSenders: [ "mom@example.com",
"dad@example.com",
"son@example.com",
]
My code uses it thusly:
if (!that.config.validSenders || that.config.validSenders.includes(mailObj.sender[0].address)) {
What I’d like to do is change that to look like this:
validSenders: [ { "mom@example.com", "Mom", "#ff0000" },
{ "dad@example.com", "Dad", "#00ff00" },
{ "son@example.com", "Son", "#0000ff" },
]
but I don’t know a) if that’s right, b) how I would do the check in the if statement above, and c) how I would access the other parts of each element. Heck, I don’t even know if that syntax is right. (I know nothing of Javascript.)
Any help with this would be much appreciated. It’s totally unnecessary but I think it could enhance the usability of the module for others.
And if I might digress for a moment, I have this code in my module:
if (that.config.validSenders.includes(mailObj.sender[0].address)) {
if (daysAgo >= 0 && daysAgo <= that.config.daysToDisplay) {
which works fine.
But if I combine those two IF statements, it doesn’t.
if (that.config.validSenders.includes(mailObj.sender[0].address) && \
daysAgo >= 0 && daysAgo <= that.config.daysToDisplay) {
It doesn’t work even if I remember to remove the second closing brace at the end.
Thanks!
I don’t know if this will work for you but I’ve set up a google calendar called “Dinner Menu” that I use for planning meals for the week. I enter an all-day event for each day with the main dish and, occasionally, sides. Actually, I mostly duplicate previous events as I’ve put the ingredients in the description for most of the meals to help with planning the weekly shopping.
I’m now setting up a MagicMirror and am using an instance of the stock calendar module to list the next 7 days of dinners. (One of the primary reasons for setting this up is to get my son to stop asking “What’s for dinner” every day.)
Here’s what it looks like on the MM:
Actually, that’s from a few days ago; I got rid of the icon on the left for a cleaner look. So far, it’s pretty much solved the problem and it’s not even properly set up yet.
I haven’t looked into recipe modules yet; I might look for a calendar module that can show the description for an event to show today’s meal and the comments I’ve entered for it (usually a list of ingredients) but that’s down the road.
@sdetweil Thanks to a comment on another thread, I’ve found the answer – I needed to restart the RPi. Once I did that, both the MoonPhase and MMM-Earth modules started working.
I tried using MMM-MoonPhase and didn’t have any luck there either. Here is my config for that:
{
module: "MMM-MoonPhase",
position: "top_left",
config: {
updateInterval: 43200000,
hemisphere: "N",
resolution: "detailed",
basicColor: "white",
title: true,
phase: true,
size: 200,
moonAlign: "center",
textAlign: "center",
alpha: 0.7,
riseAndSet: {
display: false,
lat: 37.xxxxx,
lon: -122.xxxxx,
gmtOffset: -8.0
}
}
},
Here’s what I’m seeing:
I’m starting to think that maybe it’s something more basic with my setup as MMM-SystemStats doesn’t work either (just shows “Loading…” for each item).
The moon phase isn’t, of course, critical, but it would be nice to get working.
Oh dear. Looks like I’ve got my work cut out for me. 8^) I think I’ll see if I can dig up another RPi to use for testing so I don’t muck up the “production” one. 8^)
Thanks for your help!
@sdetweil Okay, I think that makes sense. Thanks!
I installed the MMM-Moon module and put in the default config from the git page and all I see is “No Image!”. Has anyone else gotten this to work?
Here’s my config:
{
module: "MMM-Moon",
position: "top_left",
config: {
// Coordinates for my place:
lat: 37.nnnnn,
lon: -122.nnnnn,
timezone: "America/Los_Angeles"
}
},
@sdetweil Thanks again! That gives me what I need to move further.
It looks like I need a module to display the images (I know I’ve seen some modules that do that) and one to handle the keypress that can send a notification to the image module (and the image module needs to be able to process the notification.)
Or, I’ve seen modules that (I think) can change the layout dynamically, perhaps that could work too.
Thanks!