remoteFile in compliments module

bhepler · Jan 10, 2017, 2:20 AM

@skr Because I’m a crap coder in Javascript.

Sorry for not helping earlier, folks. I was at a wedding and delivering my mirror as a gift. I’ll investigate and see if I can’t improve the mirror code.

You should not ever have to modify the compliments.js file. You should be able to pull it off with just modifications to the config.js file.

DvdEnde · Jan 10, 2017, 9:45 AM

@schlachtkreuzer6
Because it worked with you as it should be, so I changed my whole MM installation.
I did manage to keep the compliments unchanged too.
:D I am happy …

@strawberry-3-141 @yawns thanks guys. Your info helped me too a lot!

DvdEnde · Jan 10, 2017, 9:47 AM

@skr I am working on that now.
@strawberry-3-141 has some good information in this project:
https://forum.magicmirror.builders/topic/240/soccer-standings

I am struggling with the CORS at the moment but it is solvable…

schlachtkreuzer6 · Jan 10, 2017, 1:42 PM

@DvdEnde Great :) did you manage to run the weather-dependent compliments? My goal is to add all weather conditions based compliments. The normal compliments work, just need some time to load after starting MM from 30 seconds to 3mins. But if a add all of them:

day_sunny
day_cloudy
cloudy
cloudy_windy
showers
rain
thunderstorm
snow
fog
night_clear
night_cloudy
night_showers
night_rain
night_thunderstorm
night_snow
night_alt_cloudy_wind

in this format:

 ],
        "fog" : [
                "fog, oh no :("
 ],
......

MM starts to show the default comliments. Any Idea?

jcorraliza · Jan 10, 2017, 2:54 PM

@schlachtkreuzer6 said in remoteFile in compliments module:

@DvdEnde Great :) did you manage to run the weather-dependent compliments? My goal is to add all weather conditions based compliments. The normal compliments work, just need some time to load after starting MM from 30 seconds to 3mins. But if a add all of them:
day_sunny
day_cloudy
cloudy
cloudy_windy
showers
rain
thunderstorm
snow
fog
night_clear
night_cloudy
night_showers
night_rain
night_thunderstorm
night_snow
night_alt_cloudy_wind
in this format:
 ],
        "fog" : [
                "fog, oh no :("
 ],
......
MM starts to show the default comliments. Any Idea?

This is the exact problem I’m running into as well. I can get the remoteFile to work if I just use the default times of day, but if I try using the currentweather objects, it just goes back to the default compliments.

schlachtkreuzer6 · Jan 10, 2017, 4:30 PM

@jcorraliza yeah… the only reason why i would use the remote file is the weather stuff, and obviously this feature has a bug, or we are to weak in coding ^^

bhepler · Jan 15, 2017, 6:47 PM

Okay, I have the weather integration working. I’ll spare you the process I went through to figure it out, but the short version is that I am a worse developer than I originally suspected. The remoteFile capability works by replacing the three compliment arrays (morning, afternoon & evening). The weather integration works (sensibly, IMHO) by adding weather-specific compliments to the existing arrays.

So in order to get them both working, you need to specify both the original arrays and the weather-specific arrays. You can delete any weather-specific arrays you wish, but you must have the morning, afternoon & evening arrays. Copy & paste this compliments.json file to your mirror and then modify accordingly.

{
  "morning": ["Morning compliment"],
  "afternoon": ["Afternoon compliment"],
  "evening": ["Evening compliment"],
  "day_sunny" : [
    "Day Sunny Compliment 1",
    "Day Sunny Compliment 2"
  ],
  "day_cloudy" : [
    "Day Cloudy Compliment 1",
    "Day Cloudy Compliment 2"
  ],
  "cloudy" : ["Cloud 1"],
  "cloudy_windy" : ["Cloud windy"],
  "showers" : ["Showers"],
  "rain" : ["Rain"],
  "thunderstorm" : ["Thunderstorm"],
  "snow" : ["Snow"],
  "fog" : ["Fog"],
  "night_clear" : ["Night clear"],
  "night_cloudy" : ["Night Cloudy"],
  "night_showers" : ["Night showers"],
  "night_rain" : ["Night Rain"],
  "night_thunderstorm" : ["Night thunderstorm"],
  "night_snow" : ["Night Snow"],
  "night_alt_cloudy_wind": ["Night Cloudy Winds"]
}

I’m going to work on this a bit and hopefully the next release of the MirrorMirror software will be a bit more friendly. As an aside, I’ve noticed that the weather integration technique continually adds to the arrays. So the memory usage will grow and grow at whatever frequency you set the compliment refresh. This isn’t terrible, as straight text doesn’t take a whole lot of memory. But it may have unintended effects if you leave your mirror running for months at a time or if you are expecting a true randomization of the compliments you enter.

schlachtkreuzer6 · Jan 18, 2017, 1:11 PM

@bhepler okay a bit weird^^ anyway thank you! It worked perfecly!
@Steff the config above :)

roramirez · Jan 19, 2017, 1:28 PM

@bhepler said in remoteFile in compliments module:

I’m going to work on this a bit and hopefully the next release of the MirrorMirror software will be a bit more friendly. As an aside, I’ve noticed that the weather integration technique continually adds to the arrays. So the memory usage will grow and grow at whatever frequency you set the compliment refresh. This isn’t terrible, as straight text doesn’t take a whole lot of memory. But it may have unintended effects if you leave your mirror running for months at a time or if you are expecting a true randomization of the compliments you enter.

Hi, when I worked in this feature I remember was a flashing about this.

If you can help how improved this is welcome :)

Snille · Jan 22, 2017, 10:17 AM

Hi! I’m using a separate compliments file (for each user). I’ve noticed that when I use non english characters they are not shown correctly.
The complement in the picture should say: “Tänk positivt”.
Now it says:

If I don’t use a compliments file and put the compliments directly in the config, it works fine.

What to do? :)

Best regards Snille