new update/upgrade script, ready for testing

rabbit83ka

Hi, great work! I Just used the script to update to 2.9.0 - the only thing I had to do manually was a

git reset --hard

before running the script (and afterwards restoring my backup of custom.css).

sdetweil

@BKeyport it could… it does traverse the modules already, but it currently only does the npm install part (to update to the current runtime dependencies) … but I could extend it easily to check for module updates (like the updatenotifier default module does) , and apply those

i am trying to get this tested so we can get it into the base (and off of my dropbox)

sdetweil

@rabbit83ka u should not have had to do the git reset --hard… please tell me why?

and my script saves and restores custom.css too

bhepler

I just gave this a try on my house mirror. I didn’t apply and received the following output:

doing test run = true
update log will be in /home/pi/MagicMirror/installers/upgrade.log
saving custom.css
bash: line 92: [: !=: unary operator expected
upgrading from version 2.8.0 to 2.9.0
fetching latest revisions
there are 1 local files that are different than the master repo

   package-lock.json

any *-lock.json files do not need to be saved
do you want to save these files for later   (Y/n)?n
skipping restore for package-lock.json, doing test run

processing dependency changes for active modules with package.json files
processing for module MMM-MovieListings . please wait
----------------------------------
skipped processing for MMM-MovieListings, doing test run
processing for module MMM-Ring . please wait
----------------------------------
skipped processing for MMM-Ring, doing test run
processing for module MMM-DarkSkyForecast . please wait
----------------------------------
skipped processing for MMM-DarkSkyForecast, doing test run
restoring custom.css
bash: line 260: [: !=: unary operator expected

This seems wrong. What can I do to help?

sdetweil

@bhepler ok, try again, fixed… assumed locale was set, wasn’t

BKeyport

@sdetweil I will clearly keep it watched… thanks for the info!

rabbit83ka

@sdetweil Same error than @satsatt

I had to restore custom.css because the git-reset deleted it (script backed up custom.css correctly).

sdetweil

@rabbit83ka hm… can u send me the install.log? same userid as here on gmail

i fixed the error that @satsatt had (or so I thought)
i check for english locale, if not set or not current, I add an alias to use english to get the right message output
then restore the the alias or remove it…

sdetweil

@rabbit83ka said in new update/upgrade script, ready for testing:

restore custom.css because the git-reset

yes, starting with version 2.9.0 they will no longer track it so changes should not be lost…
I will leave the save/restore in

Mykle1

@sdetweil

Used your update/upgrade script last night. No issues. Thank you, Sam. :thumbsup:

MM 2.8.0 -> 2.9.0
Ubuntu 18.04.3