new update/upgrade script, ready for testing

satsatt

sorry need to be away from terminal for 10h - thank’s alot

sdetweil

@satsatt ok, when u have time , try the script again… thanks SO much for your help

BKeyport

Love this concept - question though - from what I’ve read (bits and pieces admittedly), it looks like it only handles the main software - could this be expanded to traverse your module directories and update them, so it could be run, say nightly, to check for and apply updates to everything?

rabbit83ka

Hi, great work! I Just used the script to update to 2.9.0 - the only thing I had to do manually was a

git reset --hard

before running the script (and afterwards restoring my backup of custom.css).

sdetweil

@BKeyport it could… it does traverse the modules already, but it currently only does the npm install part (to update to the current runtime dependencies) … but I could extend it easily to check for module updates (like the updatenotifier default module does) , and apply those

i am trying to get this tested so we can get it into the base (and off of my dropbox)

sdetweil

@rabbit83ka u should not have had to do the git reset --hard… please tell me why?

and my script saves and restores custom.css too

bhepler

I just gave this a try on my house mirror. I didn’t apply and received the following output:

doing test run = true
update log will be in /home/pi/MagicMirror/installers/upgrade.log
saving custom.css
bash: line 92: [: !=: unary operator expected
upgrading from version 2.8.0 to 2.9.0
fetching latest revisions
there are 1 local files that are different than the master repo

   package-lock.json

any *-lock.json files do not need to be saved
do you want to save these files for later   (Y/n)?n
skipping restore for package-lock.json, doing test run

processing dependency changes for active modules with package.json files
processing for module MMM-MovieListings . please wait
----------------------------------
skipped processing for MMM-MovieListings, doing test run
processing for module MMM-Ring . please wait
----------------------------------
skipped processing for MMM-Ring, doing test run
processing for module MMM-DarkSkyForecast . please wait
----------------------------------
skipped processing for MMM-DarkSkyForecast, doing test run
restoring custom.css
bash: line 260: [: !=: unary operator expected

This seems wrong. What can I do to help?

sdetweil

@bhepler ok, try again, fixed… assumed locale was set, wasn’t

BKeyport

@sdetweil I will clearly keep it watched… thanks for the info!

rabbit83ka

@sdetweil Same error than @satsatt

I had to restore custom.css because the git-reset deleted it (script backed up custom.css correctly).

sdetweil

@rabbit83ka hm… can u send me the install.log? same userid as here on gmail

i fixed the error that @satsatt had (or so I thought)
i check for english locale, if not set or not current, I add an alias to use english to get the right message output
then restore the the alias or remove it…

sdetweil

@rabbit83ka said in new update/upgrade script, ready for testing:

restore custom.css because the git-reset

yes, starting with version 2.9.0 they will no longer track it so changes should not be lost…
I will leave the save/restore in

Mykle1

@sdetweil

Used your update/upgrade script last night. No issues. Thank you, Sam. :thumbsup:

MM 2.8.0 -> 2.9.0
Ubuntu 18.04.3

sdetweil

@Mykle1 cool… did u have extra modules also ?

Mykle1

@sdetweil said in new update/upgrade script, ready for testing:

cool… did u have extra modules also ?

Meaning other than the defaults? I have nearly all of my modules installed, as well as my favorites from other devs. Did something happen to them? hahah

sdetweil

@Mykle1 no. Just checking on how it was handled.

Could u email me the Upgrade log

Mykle1

@sdetweil

Where is it saved to? I can’t seem to find it in Home or the MagicMirror dir

sdetweil

@Mykle1 in the installers folder… (where the install script is and where the upgrade and pm2 scripts should go

dang it… u mean you didn’t READ the message the script put out about where the log is? lol…

Mykle1

@sdetweil said in new update/upgrade script, ready for testing:

u mean you didn’t READ the message the script put out about where the log is? lol…

uhhhh . . . real men don’t read messages. ;-)

Sent the file to your gmail

bhepler

@sdetweil - Hmm. Curious. Test run of the script looked good. Added the apply keyword and I’m getting a git error.

any *-lock.json files do not need to be saved
do you want to save these files for later   (Y/n)?n
fatal: Unable to create '/home/pi/MagicMirror/.git/index.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

there were merge errors
you should examine and resolve them
using the command git log --oneline --decorate
a31546b (HEAD -> master, tag: v2.8.0) Merge pull request #1717 from MichMich/develop

Then a bunch of commit statements. There is no git process running at the moment, but that index.lock file does exist. After deleting that file, it worked like a charm. Thanks!