MMM-RottenTomatoes displays awaiting update

[sdetweil]

@airs747 said in MMM-RottenTomatoes displays awaiting update:

’m think about a better way (take the first movie on the site?) and commit to github

find the github repo for the module you fixed,
fork it (now YOU have a linked ‘copy’)

make the same changes, commit to YOUR copy
and then offer a Pull Request (new pull request button) to the source to fix the problem for all

[4r3st3r]

Hi, thanks for all the help so far! When I cloned the parnic’s rt-scraper and MMM-RottenTomatoes fork it still just displayed “awaiting update”. Has anyone else managed to get this module fixed?

[rdemets]

@airs747 Hi. I tried that, but I didn’t find any instance of homepage-top-box-office in index.js. I can see in the code source the movies_sidebar, but I don’t know where to place it. Can you please give more details about what you did ? I’ve installed RottenTomatoes via parnic code, and the rt-scrapper linked to it. Thank you very much.

[rdemets]

@tomyboy96 Same here, did you get it to work ? Thanks

[tomyboy96]

@rdemets
Nope… still nothing…

[lavolp3]

@sdetweil @airs747
There is already a fix that is PRd to the rt-scraper module. Unfortunately since February already.
The problem is that it would need to be merged and published as an npm module to be properly installed here.

[tomyboy96]

@lavolp3

Is this something that can be installed manually?

[lavolp3]

@tomyboy96 I would try to overwrite index.js with the one from the PR.

/*
MIT License

Copyright (c) 2017 Adam Moses

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/

// parses the HTML body that the request operation received
// uses the cheerio package to achieve this
function parseRottenTomatoesHTML(fileData) {
    var cheerio = require("cheerio");
    // prep the return object
    var allTomatoData = { openingThisWeek: [ ]
                           , boxOffice: [ ]
                           , comingSoon: [ ] };
    var errorFlag = true;
    // sanity check that this is rotten tomatoes web html
    if (fileData.indexOf('Rotten Tomatoes') != -1) {
        // set error flag to false for passing sanity check
        errorFlag = false;
        // load the html into the cheerio doc
        var fullDoc = cheerio.load(fileData);
        // find the stub for movies opening this week
        var openingThisWeekDoc = cheerio.load(fullDoc('[id="opening-this-week"]').html());        
        // iterate through movies and strip useful parts, add each to return object
        openingThisWeekDoc('tr').each(function() {
            var movieDoc = cheerio.load(openingThisWeekDoc(this).html());
            var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
            var movieTitle = movieDoc('.media-lists__td-title').text().trim();
            var movieDate  = movieDoc('.media-lists__td-date').text().trim();
            var movieObj = {
                meter: movieMeter, 
                title: movieTitle, 
                date: movieDate
            };
            allTomatoData.openingThisWeek[allTomatoData.openingThisWeek.length] = movieObj;
        });    
        // find the stub for top box office this week            
        var topBoxOfficeDoc = cheerio.load(fullDoc('[id="top-box-office"]').html()); 
        // iterate through movies and strip useful parts, add each to return object        
        topBoxOfficeDoc('tr').each(function() {
            var movieDoc = cheerio.load(topBoxOfficeDoc(this).html());
            var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
            var movieTitle = movieDoc('.media-lists__td-title').text().trim();
            var movieGross = movieDoc('.media-lists__td-date').text().trim();
            var movieObj = {
                meter: movieMeter, 
                title: movieTitle, 
                gross: movieGross
            };
            allTomatoData.boxOffice[allTomatoData.boxOffice.length] = movieObj;            
        });  
        // find the stub for top movies coming soon
        var topComingSoonDoc = cheerio.load(fullDoc('[id="coming-soon-theaters"]').html());
        // iterate through movies and strip useful parts, add each to return object         
        topComingSoonDoc('tr').each(function() {
            var movieDoc = cheerio.load(topComingSoonDoc(this).html());
            var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
            var movieTitle = movieDoc('.media-lists__td-title').text().trim();
            var movieDate  = movieDoc('.media-lists__td-date').text().trim();
            var movieObj = {
                meter: movieMeter, 
                title: movieTitle, 
                date: movieDate
            };
            allTomatoData.comingSoon[allTomatoData.comingSoon.length] = movieObj;            
        });                  
    }
    // return error flag and the data  
    return {error: errorFlag, data: allTomatoData};
}

// makes a call to get the HTML from the rotten tomatoes front page
// uses the request package to achieve this
function requestRottenTomatoesHTML(callback) {
    var request = require("request");
    request({ uri: "http://www.rottentomatoes.com" }, 
        function(error, response, body) {
            if (!error) {
                var parsedData = parseRottenTomatoesHTML(body);
                if (parsedData.error == false)
                    callback(false, parsedData.data);
                else
                    callback(true, null);
            }
            else {
                callback(true, null);
            }
        });
}

// the export function exposed via the package
// uses a callback since the request call itself is asynchronous
exports.getRottenTomatoesScraperData = function(callback) {
    requestRottenTomatoesHTML(callback);
}
  
//  --- the end ---

That would be the manual DIRTY way. But since the PR is from Feb and not merged yet it is getting more unlikely.
Don’t know if this has been tried already

[tomyboy96]

@lavolp3

Nope not working…

if you change the id’s to “movies_sidebar”
and uri: “http://www.rottentomatoes.com/m/dream_horse”
It seems like it’s loading again. but the loading is not correct.

would be super good if there would be a way to manually add the PR just replacing the index do not work.

[sdetweil]

@lavolp3 where did the pr come from? what repo? git clone that repo to install and test