• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-RottenTomatoes displays awaiting update

Scheduled Pinned Locked Moved Unsolved Troubleshooting
25 Posts 10 Posters 6.9k Views 10 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • T Offline
    tomyboy96 Project Sponsor @haywire
    last edited by Apr 13, 2020, 4:06 PM

    Hey @haywire!

    I tried this but it did not work for me…

    Tried removing old MMM-RottenTomatoes and installing https://github.com/parnic/MMM-RottenTomatoes

    It got the “Awaiting update” message fixed but the only thing showing up now is the:
    box office, opening this week, coming soon
    without any movies.

    IMG_5851.jpg

    Using the same config.js as I did for the old MMM-RottenTomatoes

    Also tried manually removing rt-scraper and then cloning from https://github.com/parnic/NPMJS-rt-scraper but still no success…

    Any ideas?

    R 1 Reply Last reply May 12, 2020, 11:24 AM Reply Quote 0
    • A Offline
      airs747
      last edited by airs747 May 2, 2020, 5:55 PM May 2, 2020, 5:54 PM

      I found a (dirty) workaround.
      Inspecting https://www.rottentomatoes.com/m/dream_horse, you can see the sidebar that used to be on the homepage. The structure is the same as before, except that the name of the div-element is different than assumed in the rt-scraper code.

      So, this is what I did to get it working:

      1. Go to the node-modules/rt-scraper directory in your MagicMirror installation dir.
      2. Edit index.js
      3. Replace the three instances of “homepage-top-box-office” with “movies_sidebar”
      4. Replace the request uri rottentomatoes.com to rottentomatoes.com/m/dream_horse
      5. Restart MagicMirror and you should now see the RT movie listing appearing again.

      Now, this is dirty, because of the Dream Horse link. I’m think about a better way (take the first movie on the site?) and commit to github. But for now we can at least enjoy the movie listings again.

      S R 2 Replies Last reply May 2, 2020, 6:07 PM Reply Quote 0
      • S Offline
        sdetweil @airs747
        last edited by May 2, 2020, 6:07 PM

        @airs747 said in MMM-RottenTomatoes displays awaiting update:

        ’m think about a better way (take the first movie on the site?) and commit to github

        find the github repo for the module you fixed,
        fork it (now YOU have a linked ‘copy’)

        make the same changes, commit to YOUR copy
        and then offer a Pull Request (new pull request button) to the source to fix the problem for all

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        L 1 Reply Last reply Aug 10, 2020, 8:55 PM Reply Quote 0
        • 4 Offline
          4r3st3r
          last edited by May 11, 2020, 3:04 PM

          Hi, thanks for all the help so far! When I cloned the parnic’s rt-scraper and MMM-RottenTomatoes fork it still just displayed “awaiting update”. Has anyone else managed to get this module fixed?

          1 Reply Last reply Reply Quote 0
          • R Offline
            rdemets @airs747
            last edited by May 12, 2020, 11:22 AM

            @airs747 Hi. I tried that, but I didn’t find any instance of homepage-top-box-office in index.js. I can see in the code source the movies_sidebar, but I don’t know where to place it. Can you please give more details about what you did ? I’ve installed RottenTomatoes via parnic code, and the rt-scrapper linked to it. Thank you very much.

            1 Reply Last reply Reply Quote 0
            • R Offline
              rdemets @tomyboy96
              last edited by May 12, 2020, 11:24 AM

              @tomyboy96 Same here, did you get it to work ? Thanks

              T 1 Reply Last reply Aug 10, 2020, 8:32 PM Reply Quote 0
              • T Offline
                tomyboy96 Project Sponsor @rdemets
                last edited by Aug 10, 2020, 8:32 PM

                @rdemets
                Nope… still nothing…

                1 Reply Last reply Reply Quote 0
                • L Offline
                  lavolp3 Module Developer @sdetweil
                  last edited by Aug 10, 2020, 8:55 PM

                  @sdetweil @airs747
                  There is already a fix that is PRd to the rt-scraper module. Unfortunately since February already.
                  The problem is that it would need to be merged and published as an npm module to be properly installed here.

                  How to troubleshoot modules
                  MMM-soccer v2, MMM-AVStock

                  T 1 Reply Last reply Aug 10, 2020, 8:56 PM Reply Quote 0
                  • T Offline
                    tomyboy96 Project Sponsor @lavolp3
                    last edited by Aug 10, 2020, 8:56 PM

                    @lavolp3

                    Is this something that can be installed manually?

                    L 1 Reply Last reply Aug 10, 2020, 8:59 PM Reply Quote 0
                    • L Offline
                      lavolp3 Module Developer @tomyboy96
                      last edited by lavolp3 Aug 10, 2020, 9:01 PM Aug 10, 2020, 8:59 PM

                      @tomyboy96 I would try to overwrite index.js with the one from the PR.

                      /*
                      MIT License
                      
                      Copyright (c) 2017 Adam Moses
                      
                      Permission is hereby granted, free of charge, to any person obtaining a copy
                      of this software and associated documentation files (the "Software"), to deal
                      in the Software without restriction, including without limitation the rights
                      to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
                      copies of the Software, and to permit persons to whom the Software is
                      furnished to do so, subject to the following conditions:
                      
                      The above copyright notice and this permission notice shall be included in all
                      copies or substantial portions of the Software.
                      
                      THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
                      IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
                      FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
                      AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
                      LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
                      OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
                      SOFTWARE.
                      */
                      
                      // parses the HTML body that the request operation received
                      // uses the cheerio package to achieve this
                      function parseRottenTomatoesHTML(fileData) {
                          var cheerio = require("cheerio");
                          // prep the return object
                          var allTomatoData = { openingThisWeek: [ ]
                                                 , boxOffice: [ ]
                                                 , comingSoon: [ ] };
                          var errorFlag = true;
                          // sanity check that this is rotten tomatoes web html
                          if (fileData.indexOf('Rotten Tomatoes') != -1) {
                              // set error flag to false for passing sanity check
                              errorFlag = false;
                              // load the html into the cheerio doc
                              var fullDoc = cheerio.load(fileData);
                              // find the stub for movies opening this week
                              var openingThisWeekDoc = cheerio.load(fullDoc('[id="opening-this-week"]').html());        
                              // iterate through movies and strip useful parts, add each to return object
                              openingThisWeekDoc('tr').each(function() {
                                  var movieDoc = cheerio.load(openingThisWeekDoc(this).html());
                                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                                  var movieDate  = movieDoc('.media-lists__td-date').text().trim();
                                  var movieObj = {
                                      meter: movieMeter, 
                                      title: movieTitle, 
                                      date: movieDate
                                  };
                                  allTomatoData.openingThisWeek[allTomatoData.openingThisWeek.length] = movieObj;
                              });    
                              // find the stub for top box office this week            
                              var topBoxOfficeDoc = cheerio.load(fullDoc('[id="top-box-office"]').html()); 
                              // iterate through movies and strip useful parts, add each to return object        
                              topBoxOfficeDoc('tr').each(function() {
                                  var movieDoc = cheerio.load(topBoxOfficeDoc(this).html());
                                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                                  var movieGross = movieDoc('.media-lists__td-date').text().trim();
                                  var movieObj = {
                                      meter: movieMeter, 
                                      title: movieTitle, 
                                      gross: movieGross
                                  };
                                  allTomatoData.boxOffice[allTomatoData.boxOffice.length] = movieObj;            
                              });  
                              // find the stub for top movies coming soon
                              var topComingSoonDoc = cheerio.load(fullDoc('[id="coming-soon-theaters"]').html());
                              // iterate through movies and strip useful parts, add each to return object         
                              topComingSoonDoc('tr').each(function() {
                                  var movieDoc = cheerio.load(topComingSoonDoc(this).html());
                                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                                  var movieDate  = movieDoc('.media-lists__td-date').text().trim();
                                  var movieObj = {
                                      meter: movieMeter, 
                                      title: movieTitle, 
                                      date: movieDate
                                  };
                                  allTomatoData.comingSoon[allTomatoData.comingSoon.length] = movieObj;            
                              });                  
                          }
                          // return error flag and the data  
                          return {error: errorFlag, data: allTomatoData};
                      }
                      
                      // makes a call to get the HTML from the rotten tomatoes front page
                      // uses the request package to achieve this
                      function requestRottenTomatoesHTML(callback) {
                          var request = require("request");
                          request({ uri: "http://www.rottentomatoes.com" }, 
                              function(error, response, body) {
                                  if (!error) {
                                      var parsedData = parseRottenTomatoesHTML(body);
                                      if (parsedData.error == false)
                                          callback(false, parsedData.data);
                                      else
                                          callback(true, null);
                                  }
                                  else {
                                      callback(true, null);
                                  }
                              });
                      }
                      
                      // the export function exposed via the package
                      // uses a callback since the request call itself is asynchronous
                      exports.getRottenTomatoesScraperData = function(callback) {
                          requestRottenTomatoesHTML(callback);
                      }
                        
                      //  --- the end ---
                      

                      That would be the manual DIRTY way. But since the PR is from Feb and not merged yet it is getting more unlikely.
                      Don’t know if this has been tried already

                      How to troubleshoot modules
                      MMM-soccer v2, MMM-AVStock

                      T S 2 Replies Last reply Aug 10, 2020, 9:19 PM Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 2 / 3
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy