• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-RottenTomatoes displays awaiting update

Scheduled Pinned Locked Moved Unsolved Troubleshooting
25 Posts 10 Posters 6.7k Views 10 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • T Offline
    tomyboy96 Project Sponsor @lavolp3
    last edited by Aug 10, 2020, 8:56 PM

    @lavolp3

    Is this something that can be installed manually?

    L 1 Reply Last reply Aug 10, 2020, 8:59 PM Reply Quote 0
    • L Offline
      lavolp3 Module Developer @tomyboy96
      last edited by lavolp3 Aug 10, 2020, 9:01 PM Aug 10, 2020, 8:59 PM

      @tomyboy96 I would try to overwrite index.js with the one from the PR.

      /*
      MIT License
      
      Copyright (c) 2017 Adam Moses
      
      Permission is hereby granted, free of charge, to any person obtaining a copy
      of this software and associated documentation files (the "Software"), to deal
      in the Software without restriction, including without limitation the rights
      to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
      copies of the Software, and to permit persons to whom the Software is
      furnished to do so, subject to the following conditions:
      
      The above copyright notice and this permission notice shall be included in all
      copies or substantial portions of the Software.
      
      THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
      IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
      FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
      AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
      LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
      OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
      SOFTWARE.
      */
      
      // parses the HTML body that the request operation received
      // uses the cheerio package to achieve this
      function parseRottenTomatoesHTML(fileData) {
          var cheerio = require("cheerio");
          // prep the return object
          var allTomatoData = { openingThisWeek: [ ]
                                 , boxOffice: [ ]
                                 , comingSoon: [ ] };
          var errorFlag = true;
          // sanity check that this is rotten tomatoes web html
          if (fileData.indexOf('Rotten Tomatoes') != -1) {
              // set error flag to false for passing sanity check
              errorFlag = false;
              // load the html into the cheerio doc
              var fullDoc = cheerio.load(fileData);
              // find the stub for movies opening this week
              var openingThisWeekDoc = cheerio.load(fullDoc('[id="opening-this-week"]').html());        
              // iterate through movies and strip useful parts, add each to return object
              openingThisWeekDoc('tr').each(function() {
                  var movieDoc = cheerio.load(openingThisWeekDoc(this).html());
                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                  var movieDate  = movieDoc('.media-lists__td-date').text().trim();
                  var movieObj = {
                      meter: movieMeter, 
                      title: movieTitle, 
                      date: movieDate
                  };
                  allTomatoData.openingThisWeek[allTomatoData.openingThisWeek.length] = movieObj;
              });    
              // find the stub for top box office this week            
              var topBoxOfficeDoc = cheerio.load(fullDoc('[id="top-box-office"]').html()); 
              // iterate through movies and strip useful parts, add each to return object        
              topBoxOfficeDoc('tr').each(function() {
                  var movieDoc = cheerio.load(topBoxOfficeDoc(this).html());
                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                  var movieGross = movieDoc('.media-lists__td-date').text().trim();
                  var movieObj = {
                      meter: movieMeter, 
                      title: movieTitle, 
                      gross: movieGross
                  };
                  allTomatoData.boxOffice[allTomatoData.boxOffice.length] = movieObj;            
              });  
              // find the stub for top movies coming soon
              var topComingSoonDoc = cheerio.load(fullDoc('[id="coming-soon-theaters"]').html());
              // iterate through movies and strip useful parts, add each to return object         
              topComingSoonDoc('tr').each(function() {
                  var movieDoc = cheerio.load(topComingSoonDoc(this).html());
                  var movieMeter = movieDoc('.media-lists__td-rating').text().trim();
                  var movieTitle = movieDoc('.media-lists__td-title').text().trim();
                  var movieDate  = movieDoc('.media-lists__td-date').text().trim();
                  var movieObj = {
                      meter: movieMeter, 
                      title: movieTitle, 
                      date: movieDate
                  };
                  allTomatoData.comingSoon[allTomatoData.comingSoon.length] = movieObj;            
              });                  
          }
          // return error flag and the data  
          return {error: errorFlag, data: allTomatoData};
      }
      
      // makes a call to get the HTML from the rotten tomatoes front page
      // uses the request package to achieve this
      function requestRottenTomatoesHTML(callback) {
          var request = require("request");
          request({ uri: "http://www.rottentomatoes.com" }, 
              function(error, response, body) {
                  if (!error) {
                      var parsedData = parseRottenTomatoesHTML(body);
                      if (parsedData.error == false)
                          callback(false, parsedData.data);
                      else
                          callback(true, null);
                  }
                  else {
                      callback(true, null);
                  }
              });
      }
      
      // the export function exposed via the package
      // uses a callback since the request call itself is asynchronous
      exports.getRottenTomatoesScraperData = function(callback) {
          requestRottenTomatoesHTML(callback);
      }
        
      //  --- the end ---
      

      That would be the manual DIRTY way. But since the PR is from Feb and not merged yet it is getting more unlikely.
      Don’t know if this has been tried already

      How to troubleshoot modules
      MMM-soccer v2, MMM-AVStock

      T S 2 Replies Last reply Aug 10, 2020, 9:19 PM Reply Quote 0
      • T Offline
        tomyboy96 Project Sponsor @lavolp3
        last edited by Aug 10, 2020, 9:19 PM

        @lavolp3

        Nope not working…

        if you change the id’s to “movies_sidebar”
        and uri: “http://www.rottentomatoes.com/m/dream_horse”
        It seems like it’s loading again. but the loading is not correct.

        would be super good if there would be a way to manually add the PR just replacing the index do not work.

        1 Reply Last reply Reply Quote 0
        • S Away
          sdetweil @lavolp3
          last edited by Aug 10, 2020, 9:37 PM

          @lavolp3 where did the pr come from? what repo? git clone that repo to install and test

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          L 1 Reply Last reply Aug 10, 2020, 10:54 PM Reply Quote 0
          • L Offline
            lavolp3 Module Developer @sdetweil
            last edited by Aug 10, 2020, 10:54 PM

            @sdetweil it’s old stuff as I see, has been explained before already
            https://forum.magicmirror.builders/post/70295

            When I install @parnic’s fork,

            1. I have a node.js error since the NodeHelper has not been declared in this file.
              This can be resolved by adding
            var NodeHelper = require("node_helper")
            

            below the declaration of the rt-scraper.

            1. then see only the headers and no movies as has been described above.

            That’s the problem with scrapers. Small cosmetic changes in the website break them.

            How to troubleshoot modules
            MMM-soccer v2, MMM-AVStock

            L S 2 Replies Last reply Aug 10, 2020, 10:57 PM Reply Quote 0
            • L Offline
              lavolp3 Module Developer @lavolp3
              last edited by lavolp3 Aug 10, 2020, 10:58 PM Aug 10, 2020, 10:57 PM

              RT has obviously changed their content more towards TV shows since cinemas are not well visited at the moment.

              How to troubleshoot modules
              MMM-soccer v2, MMM-AVStock

              1 Reply Last reply Reply Quote 0
              • S Away
                sdetweil @lavolp3
                last edited by Aug 10, 2020, 11:03 PM

                @lavolp3 yeh, one of the TV show scrapers failed too for similar cause.

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                1 Reply Last reply Reply Quote 0
                • T Offline
                  tomyboy96 Project Sponsor
                  last edited by Sep 3, 2020, 10:04 PM

                  Still nothing new here?

                  Saw that https://github.com/parnic/MMM-RottenTomatoes has gotten a new push but still seems like the same problem.

                  L 1 Reply Last reply Sep 4, 2020, 7:40 AM Reply Quote 0
                  • L Offline
                    lavolp3 Module Developer @tomyboy96
                    last edited by Sep 4, 2020, 7:40 AM

                    @tomyboy96 same for me. No movies showing up.

                    How to troubleshoot modules
                    MMM-soccer v2, MMM-AVStock

                    L 1 Reply Last reply Oct 20, 2020, 7:54 AM Reply Quote 0
                    • L Offline
                      lavolp3 Module Developer @lavolp3
                      last edited by Oct 20, 2020, 7:54 AM

                      @lavolp3 I tried to dig a bit deeper into the rt-scraper module again and it seems the references for the elements are all different from the current page.
                      The output of the module is empty and therefore we only see the headlines and no content.
                      I don’t think I’ll be able to fix it.

                      How to troubleshoot modules
                      MMM-soccer v2, MMM-AVStock

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 2 / 3
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy